Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-03 Thread Jiri Pirko
Mon, Apr 02, 2018 at 02:30:45PM CEST, rahul.lakkire...@chelsio.com wrote: >On Monday, April 04/02/18, 2018 at 14:41:43 +0530, Jiri Pirko wrote: >> Fri, Mar 30, 2018 at 08:42:00PM CEST, ebied...@xmission.com wrote: >> >Rahul Lakkireddy writes: >> > >> >> On Friday, March 03/30/18, 2018 at 16:09:07

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > > +static struct pxa_ssp_info pxa_ssp_infos[] = { > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name = "ssp2

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 6:35 PM, kbuild test robot wrote: > >drivers/mtd/nand/marvell_nand.c:2621:17: sparse: undefined identifier > 'pxad_filter_fn' >>> drivers/mtd/nand/marvell_nand.c:2621:17: sparse: call with no type! >In file included from drivers/mtd/nand/marvell_nand.c:21:0: >d

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > Hi, > > This serie is aimed at removing the dmaengine slave compat use, and transfer > knowledge of the DMA requestors into architecture code. > > This was discussed/advised by Arnd a couple of years back, it's almost time. > > The serie is d

[PATCH iproute2 rdma: Ignore unknown netlink attributes

2018-04-03 Thread Leon Romanovsky
From: Leon Romanovsky The check if netlink attributes supplied more than maximum supported is to strict and may lead to backward compatibility issues with old application with a newer kernel that supports new attribute. CC: Steve Wise Fixes: 74bd75c2b68d ("rdma: Add basic infrastructure for RDM

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread Jiri Pirko
Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >On 3/29/18 2:33 PM, Ido Schimmel wrote: >> From: Jiri Pirko >> >> This resolves race during initialization where the resources with >> ops are registered before driver and the structures used by occ_get >> op is initialized. So keep

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-03 Thread Siwei Liu
On Sun, Apr 1, 2018 at 9:11 AM, David Ahern wrote: > On 4/1/18 3:13 AM, Si-Wei Liu wrote: >> Hidden netdevice is not visible to userspace such that >> typical network utilities e.g. ip, ifconfig and et al, >> cannot sense its existence or configure it. Internally >> hidden netdev may associate wit

[PATCH] vhost-net: add limitation of sent packets for tx polling

2018-04-03 Thread 张海斌
handle_tx will delay rx for a long time when tx busy polling udp packets with small length(e.g. 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only sent-bytes but no single packet length. Tests were done between two Virtual Machines using netperf(UDP_STREAM, len=1), then a

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-04-03 Thread Pavel Machek
Hi! > > On Tue, 20 Mar 2018, Ingo Molnar wrote: > > > * Thomas Gleixner wrote: > > > > > > > > So I do think we could do more in this area to improve driver > > > > > performance, if the > > > > > code is correct and if there's actual benchmarks that are showing > > > > > real benefits. > > >

linux-next on x60: hangs when I request suspend was Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-04-03 Thread Pavel Machek
Hi! I wanted to re-test next (4.16.0-rc7-next-20180329), but that one does not suspend at all. I normally suspend by pressing power button in MATE, but that action currently results in machine hanging. Pavel On Mon 2018-03-26 10:3

Re: [Patch net] af_unix: remove redundant lockdep class

2018-04-03 Thread Paolo Abeni
On Mon, 2018-04-02 at 11:01 -0700, Cong Wang wrote: > After commit 581319c58600 ("net/socket: use per af lockdep classes for sk > queues") > sock queue locks now have per-af lockdep classes, including unix socket. > It is no longer necessary to workaround it. > > I noticed this while looking at a

Re: linux-next: build failure after merge of the tip tree

2018-04-03 Thread Peter Zijlstra
On Tue, Apr 03, 2018 at 03:41:22PM +1000, Stephen Rothwell wrote: > Caused by commit > > 9b8cce52c4b5 ("sched/wait: Remove the wait_on_atomic_t() API") > > interacting with commits > > d3be4d244330 ("xrpc: Fix potential call vs socket/net destruction race") > 31f5f9a1691e ("rxrpc: Fix app

[PATCH v2] net: phy: marvell10g: add thermal hwmon device

2018-04-03 Thread Russell King
Add a thermal monitoring device for the Marvell 88x3310, which updates once a second. We also need to hook into the suspend/resume mechanism to ensure that the thermal monitoring is reconfigured when we resume. Suggested-by: Andrew Lunn Signed-off-by: Russell King --- v2: update to apply to net

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Maxime Ripard
On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard > wrote: > > On Sat, Mar 17, 2018 at 05:28:47PM +0800, Chen-Yu Tsai wrote: > >> From: Icenowy Zheng > >> > >> There's a GMAC configuration register, which exists on A64/A83T/H3/H5 in > >

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: > On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: > > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard > > wrote: > > > On Sat, Mar 17, 2018 at 05:28:47PM +0800, Chen-Yu Tsai wrote: > > >> From: Icenowy Zheng > > >> > > >>

Re: possible deadlock in skb_queue_tail

2018-04-03 Thread Kirill Tkhai
On 02.04.2018 12:20, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 06b19fe9a6df7aaa423cd8404ebe5ac9ec4b2960 (Sun Apr 1 03:37:33 2018 +) > Merge branch 'chelsio-inline-tls' > syzbot dashboard link: > https://syzkaller.appspot.com/bug?extid=6b495100f17ca8554ab9

FW: gretap tunnel redirecting 2 different networks on destination host

2018-04-03 Thread Marc Roos
I see you are quite busy with discussing the patches etc. If this is the incorrect place to ask for a little help please let me know. I just got this from some one on stack overflow who got some answers here. -Original Message- Subject: gretap tunnel redirecting 2 different networks

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Chen-Yu Tsai
On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard wrote: > On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >> On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: >> > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard >> > wrote: >> > > On Sat, Mar 17, 2018 at 05:28:47PM +0800, C

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Icenowy Zheng
于 2018年4月3日 GMT+08:00 下午5:50:05, Maxime Ripard 写到: >On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >> On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: >> > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard >> > wrote: >> > > On Sat, Mar 17, 2018 at 05:28:47PM +0800, Ch

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Icenowy Zheng
于 2018年4月3日 GMT+08:00 下午5:53:08, Chen-Yu Tsai 写到: >On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard > wrote: >> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: >>> On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wrote: >>> > On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard >>> >

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Chen-Yu Tsai
On Tue, Apr 3, 2018 at 5:54 PM, Icenowy Zheng wrote: > > > 于 2018年4月3日 GMT+08:00 下午5:53:08, Chen-Yu Tsai 写到: >>On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard >> wrote: >>> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime Ripard wrote: On Tue, Mar 20, 2018 at 03:15:02PM +0800, Chen-Yu Tsai wro

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-04-03 Thread Chas Williams
On Tue, Apr 3, 2018 at 2:13 AM, Roopa Prabhu wrote: > On Mon, Apr 2, 2018 at 8:26 AM, Chas Williams <3ch...@gmail.com> wrote: >> On Mon, Apr 2, 2018 at 11:08 AM, Roopa Prabhu >> wrote: >>> > > [snip] > >>> they are popular...in-fact they are the default bridge mode on our >>> network switches. >

Re: [PATCH 00/47] Netfilter/IPVS updates for net-next

2018-04-03 Thread Pablo Neira Ayuso
Hi Rafal, On Tue, Apr 03, 2018 at 08:13:49AM +0200, Rafał Miłecki wrote: > Hi Pablo, > [...] > I see you mentioned changes from Felix in the pull request but: > 1) I don't see any commits from Felix listed below > 2) I don't think you sent any of these patches > > Can you take a look at what has

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-04-03 Thread Ingo Molnar
* Pavel Machek wrote: > > > > Yeah, so generic memcpy() replacement is only feasible I think if the > > > > most > > > > optimistic implementation is actually correct: > > > > > > > > - if no preempt disable()/enable() is required > > > > > > > > - if direct access to the AVX[2] registers

Re: [GIT PULL] remove in-kernel calls to syscalls

2018-04-03 Thread Ingo Molnar
* Linus Torvalds wrote: > On Mon, Apr 2, 2018 at 12:04 PM, Dominik Brodowski > wrote: > > > > This patchset removes all in-kernel calls to syscall functions in the > > kernel with the exception of arch/. > > Ok, this finished off my arch updates for today, I'll probably move on > to driver pul

[net-next V9 PATCH 02/16] xdp: introduce xdp_return_frame API and use in cpumap

2018-04-03 Thread Jesper Dangaard Brouer
Introduce an xdp_return_frame API, and convert over cpumap as the first user, given it have queued XDP frame structure to leverage. V3: Cleanup and remove C99 style comments, pointed out by Alex Duyck. V6: Remove comment that id will be added later (Req by Alex Duyck) V8: Rename enum mem_type to x

[net-next V9 PATCH 07/16] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-04-03 Thread Jesper Dangaard Brouer
The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data pointer address and uses virt_to_head_page() to retrieve struct page. Use the XDP return API to get away from such assumptions. Instead queue an xdp_frame, which all

[net-next V9 PATCH 03/16] ixgbe: use xdp_return_frame API

2018-04-03 Thread Jesper Dangaard Brouer
Extend struct ixgbe_tx_buffer to store the xdp_mem_info. Notice that this could be optimized further by putting this into a union in the struct ixgbe_tx_buffer, but this patchset works towards removing this again. Thus, this is not done. Signed-off-by: Jesper Dangaard Brouer --- drivers/net/et

[net-next V9 PATCH 06/16] tun: convert to use generic xdp_frame and xdp_return_frame API

2018-04-03 Thread Jesper Dangaard Brouer
From: Jesper Dangaard Brouer The tuntap driver invented it's own driver specific way of queuing XDP packets, by storing the xdp_buff information in the top of the XDP frame data. Convert it over to use the more generic xdp_frame structure. The main problem with the in-driver method is that the

[net-next V9 PATCH 00/16] XDP redirect memory return API

2018-04-03 Thread Jesper Dangaard Brouer
This is V9, but it's worth mentioning that V8 was send against net-next, because i40e got XDP_REDIRECT support in-between V6, and it doesn't exist in bpf-next yet. Most significant change in V8 was that page_pool only gets compiled into the kernel when a drivers Kconfig 'select' the feature. This

[net-next V9 PATCH 01/16] mlx5: basic XDP_REDIRECT forward support

2018-04-03 Thread Jesper Dangaard Brouer
This implements basic XDP redirect support in mlx5 driver. Notice that the ndo_xdp_xmit() is NOT implemented, because that API need some changes that this patchset is working towards. The main purpose of this patch is have different drivers doing XDP_REDIRECT to show how different memory models b

[net-next V9 PATCH 04/16] xdp: move struct xdp_buff from filter.h to xdp.h

2018-04-03 Thread Jesper Dangaard Brouer
This is done to prepare for the next patch, and it is also nice to move this XDP related struct out of filter.h. Signed-off-by: Jesper Dangaard Brouer --- include/linux/filter.h | 24 +--- include/net/xdp.h | 22 ++ 2 files changed, 23 insertions(

[net-next V9 PATCH 08/16] bpf: cpumap convert to use generic xdp_frame

2018-04-03 Thread Jesper Dangaard Brouer
The generic xdp_frame format, was inspired by the cpumap own internal xdp_pkt format. It is now time to convert it over to the generic xdp_frame format. The cpumap needs one extra field dev_rx. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h |1 + kernel/bpf/cpumap.c | 100 +

[net-next V9 PATCH 05/16] xdp: introduce a new xdp_frame type

2018-04-03 Thread Jesper Dangaard Brouer
This is needed to convert drivers tuntap and virtio_net. This is a generalization of what is done inside cpumap, which will be converted later. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h | 40 1 file changed, 40 insertions(+) diff --g

[net-next V9 PATCH 12/16] page_pool: refurbish version of page_pool code

2018-04-03 Thread Jesper Dangaard Brouer
Need a fast page recycle mechanism for ndo_xdp_xmit API for returning pages on DMA-TX completion time, which have good cross CPU performance, given DMA-TX completion time can happen on a remote CPU. Refurbish my page_pool code, that was presented[1] at MM-summit 2016. Adapted page_pool code to not

[net-next V9 PATCH 09/16] i40e: convert to use generic xdp_frame and xdp_return_frame API

2018-04-03 Thread Jesper Dangaard Brouer
Also convert driver i40e, which very recently got XDP_REDIRECT support in commit d9314c474d4f ("i40e: add support for XDP_REDIRECT"). V7: This patch got added in V7 of this patchset. Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 20 +++

[net-next V9 PATCH 10/16] mlx5: register a memory model when XDP is enabled

2018-04-03 Thread Jesper Dangaard Brouer
Now all the users of ndo_xdp_xmit have been converted to use xdp_return_frame. This enable a different memory model, thus activating another code path in the xdp_return_frame API. V2: Fixed issues pointed out by Tariq. Signed-off-by: Jesper Dangaard Brouer Reviewed-by: Tariq Toukan Acked-by: Sa

[net-next V9 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return_frame

2018-04-03 Thread Jesper Dangaard Brouer
New allocator type MEM_TYPE_PAGE_POOL for page_pool usage. The registered allocator page_pool pointer is not available directly from xdp_rxq_info, but it could be (if needed). For now, the driver should keep separate track of the page_pool pointer, which it should use for RX-ring page allocation.

[net-next V9 PATCH 11/16] xdp: rhashtable with allocator ID to pointer mapping

2018-04-03 Thread Jesper Dangaard Brouer
Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per RX-queue xdp_rxq_info. Instead of using the IDR infrastructure, which uses a radix tree, use a dynamic rhashtable, for creating ID to pointer lookup table, because

[net-next V9 PATCH 15/16] xdp: transition into using xdp_frame for return API

2018-04-03 Thread Jesper Dangaard Brouer
Changing API xdp_return_frame() to take struct xdp_frame as argument, seems like a natural choice. But there are some subtle performance details here that needs extra care, which is a deliberate choice. When de-referencing xdp_frame on a remote CPU during DMA-TX completion, result in the cache-lin

[net-next V9 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

2018-04-03 Thread Jesper Dangaard Brouer
This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page returns the page through the page allocator. And at the same time, have pages getting returned to the page_pool from ndp_xdp_xmit DMA completion. The perfo

[net-next V9 PATCH 16/16] xdp: transition into using xdp_frame for ndo_xdp_xmit

2018-04-03 Thread Jesper Dangaard Brouer
Changing API ndo_xdp_xmit to take a struct xdp_frame instead of struct xdp_buff. This brings xdp_return_frame and ndp_xdp_xmit in sync. This builds towards changing the API further to become a bulk API, because xdp_buff is not a queue-able object while xdp_frame is. V4: Adjust for commit 59655a5

RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Razvan Stefanescu
Hello Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, April 2, 2018 4:45 PM > To: Ioana Ciornei > Cc: Arnd Bergmann ; gregkh > ; Laurentiu Tudor > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Stuart Yoder ; Ruxandra > Ioana Ciocoi Radulesc

Re: [PATCH net-next RFC 0/5] ipv6: sr: introduce seg6local End.BPF action

2018-04-03 Thread Mathieu Xhonneux
2018-03-31 1:03 GMT+02:00 Alexei Starovoitov : > > On Fri, Mar 23, 2018 at 10:15:59AM +, Mathieu Xhonneux wrote: > > As of Linux 4.14, it is possible to define advanced local processing for > > IPv6 packets with a Segment Routing Header through the seg6local LWT > > infrastructure. This LWT imp

Re: possible deadlock in skb_queue_tail

2018-04-03 Thread Dmitry Vyukov
On Tue, Apr 3, 2018 at 11:50 AM, Kirill Tkhai wrote: > On 02.04.2018 12:20, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on net-next commit >> 06b19fe9a6df7aaa423cd8404ebe5ac9ec4b2960 (Sun Apr 1 03:37:33 2018 +) >> Merge branch 'chelsio-inline-tls' >> syzbot dashboard link: >>

Re: WARNING: refcount bug in should_fail

2018-04-03 Thread Dmitry Vyukov
On Tue, Apr 3, 2018 at 7:20 AM, Al Viro wrote: > On Mon, Apr 02, 2018 at 10:59:34PM +0100, Al Viro wrote: > >> FWIW, I'm going through the ->kill_sb() instances, fixing that sort >> of bugs (most of them preexisting, but I should've checked instead >> of assuming that everything's fine). Will pus

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-04-03 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 05:58:05PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 3, 2018 at 5:54 PM, Icenowy Zheng wrote: > > > > > > 于 2018年4月3日 GMT+08:00 下午5:53:08, Chen-Yu Tsai 写到: > >>On Tue, Apr 3, 2018 at 5:50 PM, Maxime Ripard > >> wrote: > >>> On Tue, Apr 03, 2018 at 11:48:45AM +0200, Maxime R

Re: possible deadlock in skb_queue_tail

2018-04-03 Thread Kirill Tkhai
On 03.04.2018 14:25, Dmitry Vyukov wrote: > On Tue, Apr 3, 2018 at 11:50 AM, Kirill Tkhai wrote: >> On 02.04.2018 12:20, syzbot wrote: >>> Hello, >>> >>> syzbot hit the following crash on net-next commit >>> 06b19fe9a6df7aaa423cd8404ebe5ac9ec4b2960 (Sun Apr 1 03:37:33 2018 +) >>> Merge branch

[PATCH net v6 1/4] ipv6: add a wrapper for ip6_dst_store() with flowi6 checks

2018-04-03 Thread Alexey Kodanev
Move commonly used pattern of ip6_dst_store() usage to a separate function - ip6_sk_dst_store_flow(), which will check the addresses for equality using the flow information, before saving them. There is no functional changes in this patch. In addition, it will be used in the next patch, in ip6_sk_

[PATCH net v6 4/4] ipv6: udp: set dst cache for a connected sk if current not valid

2018-04-03 Thread Alexey Kodanev
A new RTF_CACHE route can be created between ip6_sk_dst_lookup_flow() and ip6_dst_store() calls in udpv6_sendmsg(), when datagram sending results to ICMPV6_PKT_TOOBIG error: udp_v6_send_skb(), for example with vti6 tunnel: vti6_xmit(), get ICMPV6_PKT_TOOBIG error skb_dst_up

[PATCH net v6 0/4] ipv6: udp: set dst cache for a connected sk if current not valid

2018-04-03 Thread Alexey Kodanev
A new RTF_CACHE route can be created with the socket's dst cache update between the below calls in udpv6_sendmsg(), when datagram sending results to ICMPV6_PKT_TOOBIG error: dst = ip6_sk_dst_lookup_flow(...) ... release_dst: if (dst) { if (connected) { ip6_dst_store(s

[PATCH net v6 2/4] ipv6: allow to cache dst for a connected sk in ip6_sk_dst_lookup_flow()

2018-04-03 Thread Alexey Kodanev
Add 'connected' parameter to ip6_sk_dst_lookup_flow() and update the cache only if ip6_sk_dst_check() returns NULL and a socket is connected. The function is used as before, the new behavior for UDP sockets in udpv6_sendmsg() will be enabled in the next patch. Signed-off-by: Alexey Kodanev ---

[PATCH net v6 3/4] ipv6: udp: convert 'connected' to bool type in udpv6_sendmsg()

2018-04-03 Thread Alexey Kodanev
This should make it consistent with ip6_sk_dst_lookup_flow() that is accepting the new 'connected' parameter of type bool. Signed-off-by: Alexey Kodanev --- net/ipv6/udp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 5bc102b

Re: [PATCH] vhost-net: add limitation of sent packets for tx polling

2018-04-03 Thread Michael S. Tsirkin
On Tue, Apr 03, 2018 at 08:08:26AM +, haibinzhang(张海斌) wrote: > handle_tx will delay rx for a long time when tx busy polling udp packets > with small length(e.g. 1byte udp payload), because setting VHOST_NET_WEIGHT > takes into account only sent-bytes but no single packet length. > > Tests wer

[PATCH] kernel/bpf/syscall: fix warning defined but not used

2018-04-03 Thread Anders Roxell
There will be a build warning -Wunused-function if CONFIG_CGROUP_BPF isn't defined, since the only user is inside #ifdef CONFIG_CGROUP_BPF: kernel/bpf/syscall.c:1229:12: warning: ‘bpf_prog_attach_check_attach_type’ defined but not used [-Wunused-function] static int bpf_prog_attach_check_attac

Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden

2018-04-03 Thread Michael S. Tsirkin
On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote: > diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h > index aa40664..0827b7e 100644 > --- a/include/uapi/linux/virtio_net.h > +++ b/include/uapi/linux/virtio_net.h > @@ -80,6 +80,8 @@ struct virtio_net_config {

Re: [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

2018-04-03 Thread Michael S. Tsirkin
On Sun, Apr 01, 2018 at 05:13:08AM -0400, Si-Wei Liu wrote: > @@ -896,6 +898,68 @@ void qmp_device_del(const char *id, Error **errp) > } > } > > +int pci_get_busdevfn_by_id(const char *id, uint16_t *busnr, > + uint16_t *devfn, Error **errp) > +{ > +uint16_t bus

Re: [PATCH] vhost-net: add limitation of sent packets for tx polling

2018-04-03 Thread 张海斌
>On Tue, Apr 03, 2018 at 08:08:26AM +, haibinzhang wrote: >> handle_tx will delay rx for a long time when tx busy polling udp packets >> with small length(e.g. 1byte udp payload), because setting VHOST_NET_WEIGHT >> takes into account only sent-bytes but no single packet length. >> >> Tests w

Re: WARNING in add_uevent_var

2018-04-03 Thread Johannes Berg
On Sun, 2018-04-01 at 23:01 -0700, syzbot wrote: > So far this crash happened 5 times on net-next, upstream. > C reproducer: https://syzkaller.appspot.com/x/repro.c?id=6614377067184128 > Huh, fun. Looks like you're basically creating a new HWSIM radio with an insanely long name (4k!) and nothing

[RFC PATCH net] tcp: allow to use TCP Fastopen with MSG_ZEROCOPY

2018-04-03 Thread Alexey Kodanev
With TCP Fastopen we can have the following cases, which could also use MSG_ZEROCOPY flag with send() and sendto(): * sendto() + MSG_FASTOPEN flag, sk state can be in TCP_CLOSE at the start of tcp_sendmsg() * set socket option TCP_FASTOPEN_CONNECT, then connect() and send(), sk state in TCP_S

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-03 Thread Andrew Lunn
On Tue, Apr 03, 2018 at 08:43:27AM +0300, Alex Vesker wrote: > > > On 4/2/2018 12:12 PM, Jiri Pirko wrote: > >Fri, Mar 30, 2018 at 05:11:29PM CEST, and...@lunn.ch wrote: > >>>Please see: > >>>http://patchwork.ozlabs.org/project/netdev/list/?series=36524 > >>> > >>>I bevieve that the solution in t

Re: linux-next: build failure after merge of the tip tree

2018-04-03 Thread David Howells
Peter Zijlstra wrote: > I figured that since there were only a handful of users it wasn't a > popular API, also David very much knew of those patches changing it so > could easily have pulled in the special tip/sched/wait branch :/ I'm not sure I could, since I have to base on net-next. I'm not

Re: linux-next: build failure after merge of the tip tree

2018-04-03 Thread David Howells
Stephen Rothwell wrote: > + wait_var_event(&rxnet->nr_calls, !atomic_read(&rxnet->nr_calls)); I would prefer == 0 to ! as it's not really a true/false value. But apart from that, it's looks okay and you can add my Reviewed-by. David

Re: linux-next: build failure after merge of the tip tree

2018-04-03 Thread Peter Zijlstra
On Tue, Apr 03, 2018 at 01:39:08PM +0100, David Howells wrote: > Peter Zijlstra wrote: > > > I figured that since there were only a handful of users it wasn't a > > popular API, also David very much knew of those patches changing it so > > could easily have pulled in the special tip/sched/wait br

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-03 Thread Andrew Lunn
On Tue, Apr 03, 2018 at 11:12:52AM +, Razvan Stefanescu wrote: > DPAA2 offers several object-based abstractions for modeling network > related devices (interfaces, L2 Ethernet switch) or accelerators > (DPSECI - crypto and DPDCEI - compression), the latter not up-streamed yet. > They are modele

[PATCH iproute2-next 1/1] tc: jsonify connmark action

2018-04-03 Thread Roman Mashak
Signed-off-by: Roman Mashak --- tc/m_connmark.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tc/m_connmark.c b/tc/m_connmark.c index bcce41391398..45e2d05f1a91 100644 --- a/tc/m_connmark.c +++ b/tc/m_connmark.c @@ -114,16 +114,20 @@ static int print_connma

Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-04-03 Thread Michael S. Tsirkin
On Thu, Mar 15, 2018 at 11:42:41AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Hardware-realized virtio_pci devices can implement SR-IOV, so this > patch enables its use. The device in question is an upcoming Intel > NIC that implements both a virtio_net PF and virtio_net VFs. These

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

2018-04-03 Thread Andrew Lunn
> On Mon, Apr 02, 2018 at 08:55:27PM -0700, Richard Cochran wrote: > On Sun, Mar 25, 2018 at 04:01:49PM -0700, Florian Fainelli wrote: > > The best that I can think about and it still is a hack in some way, is > > to you have your time stamping driver create a proxy mii_bus whose > > purpose is jus

Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-04-03 Thread Michael S. Tsirkin
On Fri, Mar 16, 2018 at 09:40:34AM -0700, Alexander Duyck wrote: > On Fri, Mar 16, 2018 at 9:34 AM, Michael S. Tsirkin wrote: > > On Thu, Mar 15, 2018 at 11:42:41AM -0700, Alexander Duyck wrote: > >> From: Alexander Duyck > >> > >> Hardware-realized virtio_pci devices can implement SR-IOV, so thi

Re: [PATCH] vhost-net: add limitation of sent packets for tx polling

2018-04-03 Thread Michael S. Tsirkin
On Tue, Apr 03, 2018 at 12:29:47PM +, haibinzhang(张海斌) wrote: > > >On Tue, Apr 03, 2018 at 08:08:26AM +, haibinzhang wrote: > >> handle_tx will delay rx for a long time when tx busy polling udp packets > >> with small length(e.g. 1byte udp payload), because setting VHOST_NET_WEIGHT > >> ta

RE: [PATCH iproute2 rdma: Ignore unknown netlink attributes

2018-04-03 Thread Steve Wise
> -Original Message- > From: Leon Romanovsky > Sent: Tuesday, April 3, 2018 2:29 AM > To: Stephen Hemminger > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list r...@vger.kernel.org>; David Ahern ; Steve Wise > > Subject: [PATCH iproute2 rdma: Ignore unknown netlink attributes > > Fr

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

2018-04-03 Thread Edward Cree
On 03/04/18 02:08, Alexei Starovoitov wrote: > I like patch 3 and going to play with it. > How did you test it ? Just test_verifier and test_progs (the latter has a failure  "test_bpf_obj_id:FAIL:get-prog-info(fd) err 0 errno 2 i 0 type 1(1) info_len 80(40) jit_enabled 0 jited_prog_len 0 xlated_pr

Re: [PATCH net-next RFC 0/5] ipv6: sr: introduce seg6local End.BPF action

2018-04-03 Thread David Lebrun
On 04/03/2018 12:16 PM, Mathieu Xhonneux wrote: In patch 2 I was a bit concerned that: + struct seg6_bpf_srh_state *srh_state = (struct seg6_bpf_srh_state *) + &skb->cb; would not collide with other users of skb->cb, but it seems the way the ho

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-03 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 05:30:54PM -0700, Jacob Keller wrote: > On Mon, Apr 2, 2018 at 7:05 AM, Bjorn Helgaas wrote: > > +/* PCIe speed to Mb/s reduced by encoding overhead */ > > +#define PCIE_SPEED2MBS_ENC(speed) \ > > + ((speed) == PCIE_SPEED_16_0GT ? (16000*(128/130)) : \ > > +(s

Re: [PATCH net-next RFC 0/5] ipv6: sr: introduce seg6local End.BPF action

2018-04-03 Thread David Lebrun
On 04/03/2018 02:40 PM, David Lebrun wrote: On 04/03/2018 12:16 PM, Mathieu Xhonneux wrote: In patch 2 I was a bit concerned that: +   struct seg6_bpf_srh_state *srh_state = (struct seg6_bpf_srh_state *) +  &skb->cb; would not collide with othe

Re: [PATCH] net: improve ipv4 performances

2018-04-03 Thread Douglas Caetano dos Santos
Hi Anton, everyone, On 04/01/18 15:31, Anton Gary Ceph wrote: > As the Linux networking stack is growing, more and more protocols are > added, increasing the complexity of stack itself. > Modern processors, contrary to common belief, are very bad in branch > prediction, so it's our task to give hi

meine Spende an dich

2018-04-03 Thread Mrs Nelma
Hallo Lieber, ich habe eine Spende von 4.600.000,00 Euro, die ich Ihnen geben möchte, um den Armen und Waisen in Ihrer Gemeinde zu helfen ... Bitte antworten Sie für weitere Details, um meine Spende zu erhalten Grüße Nelma Ruaan

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread David Ahern
On 4/3/18 1:32 AM, Jiri Pirko wrote: > Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >> On 3/29/18 2:33 PM, Ido Schimmel wrote: >>> From: Jiri Pirko >>> >>> This resolves race during initialization where the resources with >>> ops are registered before driver and the structures us

Re: [PATCH net-next RFC 0/5] ipv6: sr: introduce seg6local End.BPF action

2018-04-03 Thread Eric Dumazet
On 04/03/2018 07:25 AM, David Lebrun wrote: > > What about saving and restoring the IPv6 CB, similarly to what TCP does with > tcp_v6_restore_cb() ? Note that TCP only moves IPCB around in skb->cb[] for cache locality gains. Now we switched to rb-tree for out-of-order queue, these gains might

Re: [net-next V9 PATCH 00/16] XDP redirect memory return API

2018-04-03 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 03 Apr 2018 13:07:36 +0200 > This is V9, but it's worth mentioning that V8 was send against > net-next, because i40e got XDP_REDIRECT support in-between V6, and it > doesn't exist in bpf-next yet. Most significant change in V8 was that > page_pool only get

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-03 Thread David Ahern
On 4/3/18 1:40 AM, Siwei Liu wrote: >> There are other use cases that want to hide a device from userspace. > > Can you elaborate your case in more details? Looking at the links > below I realize that the purpose of hiding devices in your case is > quite different from the our migration case. Part

Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.

2018-04-03 Thread Richard Cochran
On Tue, Apr 03, 2018 at 03:13:19PM +0200, Andrew Lunn wrote: > Have you tried implementing it using a phandle in the phy node, > pointing to the time stamping device? Not yet, but I'll take this up for V2, after the merge window... Thinking about MII, it really is a 1:1 connection between the MAC

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-03 Thread David Ahern
On 4/2/18 12:16 PM, Alexei Starovoitov wrote: > On Mon, Apr 02, 2018 at 12:09:44PM -0600, David Ahern wrote: >> On 4/2/18 12:03 PM, John Fastabend wrote: >>> >>> Can the above be a normal BPF helper that returns an >>> ifindex? Then something roughly like this patter would >>> work for all drivers

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-03 Thread Ulf Hansson
On 2 April 2018 at 16:26, Robert Jarzmik wrote: > Hi, > > This serie is aimed at removing the dmaengine slave compat use, and transfer > knowledge of the DMA requestors into architecture code. > > This was discussed/advised by Arnd a couple of years back, it's almost time. > > The serie is divided

Socket error queue with timestamping and SOF_TIMESTAMPING_OPT_CMSG

2018-04-03 Thread Miroslav Lichvar
I came across an interesting issue with error messages in sockets with enabled timestamping using the SOF_TIMESTAMPING_OPT_CMSG option. When the socket is connected and there is an error (e.g. due to destination unreachable ICMP), select() indicates there is an exception on the socket, but recvmsg(

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: >> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) }, > > This one is interesting, as you are dealing with an off-chip device, > and

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread Jiri Pirko
Tue, Apr 03, 2018 at 04:33:11PM CEST, dsah...@gmail.com wrote: >On 4/3/18 1:32 AM, Jiri Pirko wrote: >> Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >>> On 3/29/18 2:33 PM, Ido Schimmel wrote: From: Jiri Pirko This resolves race during initialization where the reso

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Arnd Bergmann
On Tue, Apr 3, 2018 at 5:18 PM, Robert Jarzmik wrote: > Arnd Bergmann writes: > >>> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >>> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) }, >>> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) }, >> >> This one is

[PATCH iproute2] ip/l2tp: remove offset and peer-offset options

2018-04-03 Thread Guillaume Nault
Ignore options "peer-offset" and "offset" when creating sessions. Keep them when dumping sessions in order to avoid breaking external scripts. "peer-offset" has always been a noop in iproute2. "offset" is now ignored in Linux 4.16 (and was broken before that). Signed-off-by: Guillaume Nault ---

Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-03 Thread Jiri Pirko
Sun, Apr 01, 2018 at 06:11:29PM CEST, dsah...@gmail.com wrote: >On 4/1/18 3:13 AM, Si-Wei Liu wrote: >> Hidden netdevice is not visible to userspace such that >> typical network utilites e.g. ip, ifconfig and et al, >> cannot sense its existence or configure it. Internally >> hidden netdev may asso

Re: Socket error queue with timestamping and SOF_TIMESTAMPING_OPT_CMSG

2018-04-03 Thread Soheil Hassas Yeganeh
On Tue, Apr 3, 2018 at 11:19 AM Miroslav Lichvar wrote: > > I came across an interesting issue with error messages in sockets with > enabled timestamping using the SOF_TIMESTAMPING_OPT_CMSG option. When > the socket is connected and there is an error (e.g. due to destination > unreachable ICMP), s

Re: [net-next V9 PATCH 00/16] XDP redirect memory return API

2018-04-03 Thread Jesper Dangaard Brouer
On Tue, 03 Apr 2018 10:54:27 -0400 (EDT) David Miller wrote: > From: Jesper Dangaard Brouer > Date: Tue, 03 Apr 2018 13:07:36 +0200 > > > This is V9, but it's worth mentioning that V8 was send against > > net-next, because i40e got XDP_REDIRECT support in-between V6, and it > > doesn't exist in

Re: [PATCH net v6 0/4] ipv6: udp: set dst cache for a connected sk if current not valid

2018-04-03 Thread Martin KaFai Lau
On Tue, Apr 03, 2018 at 03:00:06PM +0300, Alexey Kodanev wrote: > A new RTF_CACHE route can be created with the socket's dst cache > update between the below calls in udpv6_sendmsg(), when datagram > sending results to ICMPV6_PKT_TOOBIG error: > >dst = ip6_sk_dst_lookup_flow(...) >... > re

Re: [PATCH net 2/2] net: systemport: Fix sparse warnings in bcm_sysport_insert_tsb()

2018-04-03 Thread Al Viro
On Mon, Apr 02, 2018 at 03:58:56PM -0700, Florian Fainelli wrote: > skb->protocol is a __be16 which we would be calling htons() against, > while this is not wrong per-se as it correctly results in swapping the > value on LE hosts, this still upsets sparse. Adopt a similar pattern to > what other dr

Re: [net-next V9 PATCH 00/16] XDP redirect memory return API

2018-04-03 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 3 Apr 2018 18:07:16 +0200 > On Tue, 03 Apr 2018 10:54:27 -0400 (EDT) > David Miller wrote: > >> Don't worry, just resubmit when net-next opens back up. > > At that point in time, should I got back to posting it against the > bpf-next git-tree again? Any

Re: [PATCH net 1/2] net: bcmgenet: Fix sparse warnings in bcmgenet_put_tx_csum()

2018-04-03 Thread Al Viro
On Mon, Apr 02, 2018 at 03:58:55PM -0700, Florian Fainelli wrote: > skb->protocol is a __be16 which we would be calling htons() against, > while this is not wrong per-se as it correctly results in swapping the > value on LE hosts, this still upsets sparse. Adopt a similar pattern to > what other dr

Re: [PATCH net 1/2] net: bcmgenet: Fix sparse warnings in bcmgenet_put_tx_csum()

2018-04-03 Thread David Miller
From: Al Viro Date: Tue, 3 Apr 2018 17:29:33 +0100 > On Mon, Apr 02, 2018 at 03:58:55PM -0700, Florian Fainelli wrote: >> skb->protocol is a __be16 which we would be calling htons() against, >> while this is not wrong per-se as it correctly results in swapping the >> value on LE hosts, this still

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-03 Thread John Fastabend
On 04/03/2018 08:07 AM, David Ahern wrote: > On 4/2/18 12:16 PM, Alexei Starovoitov wrote: >> On Mon, Apr 02, 2018 at 12:09:44PM -0600, David Ahern wrote: >>> On 4/2/18 12:03 PM, John Fastabend wrote: Can the above be a normal BPF helper that returns an ifindex? Then something roughl

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

2018-04-03 Thread David Miller
From: John Fastabend Date: Tue, 3 Apr 2018 09:41:08 -0700 > On 04/03/2018 08:07 AM, David Ahern wrote: >> 4. What about other stacked devices - bonds and bridges - will those >> just work with the bpf helper? VRF is already handled of course. ;-) > > So if we simply handle this like other stacke

Re: [PATCH net 1/2] net: bcmgenet: Fix sparse warnings in bcmgenet_put_tx_csum()

2018-04-03 Thread Al Viro
On Tue, Apr 03, 2018 at 12:33:05PM -0400, David Miller wrote: > Yes Al, however the pattern choosen here is probably cheaper on little endian: > > __beXX val = x; > switch (val) { > case htons(ETH_P_FOO): >... > } > > This way only the compiler byte swaps the cons

  1   2   >