[PATCH net-next 2/2] cxgb4: properly initialize variables

2018-01-24 Thread Rahul Lakkireddy
memset variables to 0 to fix sparse warnings: drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:409:42: sparse: Using plain integer as NULL pointer drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:43:47: sparse: Using plain integer as NULL pointer Fixes: ad75b7d32f25 ("cxgb4: implement ethtool dum

[PATCH net-next 0/2] cxgb4: fix build error

2018-01-24 Thread Rahul Lakkireddy
Patch 1 fixes build error with compiling cudbg_zlib.c when CONFIG_ZLIB_DEFLATE macro is not defined. Patch 2 fixes following sparse warning: "Using plain integer as NULL pointer" Thanks, Rahul Rahul Lakkireddy (2): cxgb4: enable ZLIB_DEFLATE when building cxgb4 cxgb4: properly initialize var

[PATCH net-next 1/2] cxgb4: enable ZLIB_DEFLATE when building cxgb4

2018-01-24 Thread Rahul Lakkireddy
Fixes: drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:39:5: error: redefinition of 'cudbg_compress_buff' int cudbg_compress_buff(struct cudbg_init *pdbg_init, ^~~ In file included from drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:23:0: drivers/net/ethernet/chel

Re: [RFC net-next 1/8] pkt_cls: make tc_can_offload_extack() check chain index

2018-01-24 Thread Jiri Pirko
Tue, Jan 23, 2018 at 10:33:33PM CET, jakub.kicin...@netronome.com wrote: >No upstream drivers seem to allow offload of chains other than 0. mlxsw does. And I know that Intel was talking about adding the support to i40e iirc. >Save driver developers typing and make tc_can_offload_extack() >check

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-24 Thread Benjamin Poirier
On 2018/01/22 10:01, Alexander Duyck wrote: [...] > > > > If the patch that I submitted for the current vmware issue is merged, > > the significant commits that are left are: > > > > 0a8047ac68e5 e1000e: Fix msi-x interrupt automask (v4.5-rc1) > > Fixes a problem in the irq disabling of the

Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload_init()

2018-01-24 Thread Jiri Pirko
Wed, Jan 24, 2018 at 03:45:58AM CET, jakub.kicin...@netronome.com wrote: >Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__() >and add a new implementation which also takes flags argument. We will >only set extack if flags indicate that offload is forced (skip_sw) >otherwise driv

Re: [RFC net-next 1/8] pkt_cls: make tc_can_offload_extack() check chain index

2018-01-24 Thread Jakub Kicinski
On Wed, 24 Jan 2018 09:28:44 +0100, Jiri Pirko wrote: > Tue, Jan 23, 2018 at 10:33:33PM CET, jakub.kicin...@netronome.com wrote: > >No upstream drivers seem to allow offload of chains other than 0. > > mlxsw does. And I know that Intel was talking about adding the support > to i40e iirc. An, I

[patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor

2018-01-24 Thread Jiri Pirko
From: Yuval Mintz Driver periodically samples all neighbors configured in device in order to update the kernel regarding their state. When finding an entry configured in HW that doesn't show in neigh_lookup() driver logs an error message. This introduces a race when removing multiple neighbors -

Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload_init()

2018-01-24 Thread Jakub Kicinski
On Wed, 24 Jan 2018 09:52:16 +0100, Jiri Pirko wrote: > >@@ -606,9 +606,9 @@ struct tc_cls_common_offload { > > }; > > > > static inline void > >-tc_cls_common_offload_init(struct tc_cls_common_offload *cls_common, > >- const struct tcf_proto *tp, > >- s

[PATCH 4.14-stable] xfrm: Fix a race in the xdst pcpu cache.

2018-01-24 Thread Steffen Klassert
commit 76a4201191814a0061cb5c861fafb9ecaa764846 upstream. We need to run xfrm_resolve_and_create_bundle() with bottom halves off. Otherwise we may reuse an already released dst_enty when the xfrm lookup functions are called from process context. Fixes: c30d78c14a813db39a647b6a348b428 ("xfrm: add

Re: [PATCH] net: make sure skb_dst is valid before using

2018-01-24 Thread Xin Long
On Wed, Jan 24, 2018 at 6:42 AM, Roman Kapl wrote: > Tunnel devices often use skb_dst(skb)->ops, but ops are not implemented > for metadata tunnel destinations. Use skb_valid_dst to check if skb_dst > is a real (non-metadata) destination. > > Such packets can easily be crafted using tc tunnel_key

From: Mr.Ahmed Owain

2018-01-24 Thread Mr.Ahmed Owain
Good Day, Please accept my apologies for writing you a surprise letter.I am Mr.Ahmed Owain, account Manager with an investment bank here in Burkina Faso.I have a very important business I want to discuss with you.There is a draft account opened in my firm by a long-time client of our bank.I have t

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Phil Sutter
Hi Stephen, On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: > On Tue, 23 Jan 2018 17:40:47 +0100 > Phil Sutter wrote: > > > The following command segfaults if enp0s31f6 does not exist: > > > > | # ip -6 route add default proto ra metric 20100 \ > > | nexthop via fe80:52:0:2

[PATCH net-next 4/6] net/smc: make wait for work request uninterruptible

2018-01-24 Thread Ursula Braun
Work requests are needed for every ib_post_send(), among them the ib_post_send() to signal closing. If an smc socket program is cancelled, the smc connections should be cleaned up, and require sending of closing signals to the peer. This may fail, if a wait for a free work request is needed, but is

[PATCH net-next 6/6] net/smc: continue waiting if peer signals write_shutdown

2018-01-24 Thread Ursula Braun
If the peer sends a shutdown WRITE, this should not affect sending in general, and waiting for send buffer space in particular. Stop waiting of the local socket for send buffer space only, if peer signals closing, but not if peer signals just shutdown WRITE. Signed-off-by: Ursula Braun --- net/s

[PATCH net-next 5/6] net/smc: improve state change handling after close wait

2018-01-24 Thread Ursula Braun
When a socket is closed or shutdown, smc waits for data being transmitted in certain states. If the state changes during this wait, the close switch depending on state should be reentered. In addition, state change is avoided if sending of close or shutdown fails. Signed-off-by: Ursula Braun ---

[PATCH net-next 2/6] net/smc: simplify function smc_clcsock_accept()

2018-01-24 Thread Ursula Braun
Cleanup to avoid duplicate code in smc_clcsock_accept(). No functional change. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index ef743b9f..05cbcd3a6f60 100644 --- a/net/sm

[PATCH net-next 3/6] net/smc: get rid of tx_pend waits in socket closing

2018-01-24 Thread Ursula Braun
There is no need to wait for confirmation of pending tx requests for a closing connection, since pending tx slots are dismissed when finishing a connection. Signed-off-by: Ursula Braun --- net/smc/smc_cdc.c | 11 --- net/smc/smc_cdc.h | 1 - net/smc/smc_close.c | 25

[PATCH net-next 1/6] net/smc: use local struct sock variables consistently

2018-01-24 Thread Ursula Braun
Cleanup to consistently exploit the local struct sock definitions. No functional change. Signed-off-by: Ursula Braun --- net/smc/af_smc.c| 33 + net/smc/smc_close.c | 38 -- 2 files changed, 37 insertions(+), 34 deletions(-)

[PATCH net-next 0/6] net/smc: socket closing improvements

2018-01-24 Thread Ursula Braun
Dave, while the first 2 patches are just small cleanups, the remaing patches affect socket closing. Thanks, Ursula Ursula Braun (6): net/smc: use local struct sock variables consistently net/smc: simplify function smc_clcsock_accept() net/smc: get rid of tx_pend waits in socket closing n

Re: [PATCH bpf-next] selftests/bpf: make 'dubious pointer arithmetic' test useful

2018-01-24 Thread Daniel Borkmann
On 01/24/2018 05:05 AM, Alexei Starovoitov wrote: > mostly revert the previous workaround and make > 'dubious pointer arithmetic' test useful again. > Use (ptr - ptr) << const instead of ptr << const to generate large scalar. > The rest stays as before commit 2b36047e7889. > > Fixes: 2b36047e7889

[PATCH 2/4] xfrm: fix error flow in case of add state fails

2018-01-24 Thread Steffen Klassert
From: Aviad Yehezkel If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismeny Signed-off-by: Steffen Klassert

pull request (net): ipsec 2018-01-24

2018-01-24 Thread Steffen Klassert
1) Only offloads SAs after they are fully initialized. Otherwise a NIC may receive packets on a SA we can not yet handle in the stack. From Yossi Kuperman. 2) Fix negative refcount in case of a failing offload. From Aviad Yehezkel. 3) Fix inner IP ptoro version when decapsulating f

[PATCH 1/4] xfrm: Add SA to hardware at the end of xfrm_state_construct()

2018-01-24 Thread Steffen Klassert
From: Yossi Kuperman Current code configures the hardware with a new SA before the state has been fully initialized. During this time interval, an incoming ESP packet can cause a crash due to a NULL dereference. More specifically, xfrm_input() considers the packet as valid, and yet, anti-replay m

[PATCH 4/4] xfrm: fix boolean assignment in xfrm_get_type_offload

2018-01-24 Thread Steffen Klassert
From: "Gustavo A. R. Silva" Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Steffen Klassert --- net/xfrm

[PATCH 3/4] xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version

2018-01-24 Thread Steffen Klassert
From: Yossi Kuperman IPSec tunnel mode supports encapsulation of IPv4 over IPv6 and vice-versa. The outer IP header is stripped and the inner IP inherits the original Ethernet header. Tcpdump fails to properly decode the inner packet in case that h_proto is different than the inner IP version.

Re: [PATCH] net: make sure skb_dst is valid before using

2018-01-24 Thread Roman Kapl
On 01/24/2018 10:16 AM, Xin Long wrote: On Wed, Jan 24, 2018 at 6:42 AM, Roman Kapl wrote: Tunnel devices often use skb_dst(skb)->ops, but ops are not implemented for metadata tunnel destinations. Use skb_valid_dst to check if skb_dst is a real (non-metadata) destination. Such packets can easi

Re: BUG: 4.14.11 unable to handle kernel NULL pointer dereference in xfrm_lookup

2018-01-24 Thread Steffen Klassert
On Fri, Jan 19, 2018 at 03:45:46PM +0100, Tobias Hommel wrote: > > I tried to strip down the system configuration and was able to reproduce the > problem with a minimal configuration: > * ipsets are not used anymore > * no firewall markings are used any longer > * iptables are "completely empty",

Re: [bpf-next PATCH v4 0/7] Series short description

2018-01-24 Thread Daniel Borkmann
On 01/22/2018 07:35 PM, John Fastabend wrote: > The sockmap sample is pretty simple at the moment. All it does is open > a few sockets attach BPF programs/sockmaps and sends a few packets. Btw, the subject from cover letter says 'Series short description'. > However, for testing and debugging I w

Re: [bpf-next PATCH v4 2/7] bpf: add sendmsg option for testing BPF programs

2018-01-24 Thread Daniel Borkmann
On 01/22/2018 07:35 PM, John Fastabend wrote: > When testing BPF programs using sockmap I often want to have more > control over how sendmsg is exercised. This becomes even more useful > as new sockmap program types are added. > > This adds a test type option to select type of test to run. Current

SO_REUSEADDR semantics and bind conflicts

2018-01-24 Thread Gilberto Bertin
I'm trying to understand the details of SO_REUSEADDR behaviour. I think I've found some inconsistencies in how bind conflicts are handled. In particular, TCP and UDP behaviour seems to differ. Let’s start with simplest TCP cases. Case 1: * Socket A: bound to 0.0.0.0 tcp/1234; SO_REUSEADDR absent

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

2018-01-24 Thread David Woodhouse
On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: > On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: > > > > The BPF interpreter has been used as part of the spectre 2 attack > > CVE-2017-5715. > > > > A quote from goolge project zero blog: > > "At this point, it would normally be neces

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

2018-01-24 Thread Daniel Borkmann
On 01/24/2018 11:07 AM, David Woodhouse wrote: > On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: >> On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: >>> >>> The BPF interpreter has been used as part of the spectre 2 attack >>> CVE-2017-5715. >>> >>> A quote from goolge project zero blog

Re: [RFC net-next 0/8] use tc_can_offload_extack() throughout the drivers

2018-01-24 Thread Jiri Pirko
Tue, Jan 23, 2018 at 10:33:32PM CET, jakub.kicin...@netronome.com wrote: >Hi! > >I have a number of patches for drivers to use tc_can_offload_extack() >as requested, but I wanted to ask for early comments and one specific >question - should we assume that type_data in block_cbs is always going >to

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-24 Thread Nicolas Dichtel
Le 23/01/2018 à 18:08, Jiri Benc a écrit : > On Tue, 23 Jan 2018 17:37:11 +0100, Nicolas Dichtel wrote: >> When a virtual interface moves to another netns, the netlink RTM_DELLINK >> message >> contains the attribute IFLA_NEW_NETNSID, which identifies where the interface >> moves. The nsid may be

Re: [PATCH v6 07/36] nds32: Exception handling

2018-01-24 Thread Vincent Chen
2018-01-18 18:14 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch includes the exception/interrupt entries, pt_reg structure and >> related accessors. >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Greentime Hu > > Here

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

2018-01-24 Thread Jiri Benc
On Wed, 24 Jan 2018 11:53:11 +0100, Nicolas Dichtel wrote: > Le 23/01/2018 à 18:08, Jiri Benc a écrit : > > It would be much better if the whole (ifindex, netnsid) pair was > > returned. I think it could be added. > Sure. Do you plan to send a patch? I can do that but it will take a while. I'll

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Phil Sutter
On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: [...] > Also, it looks like read_family converts any address family it doesn't know > about to unspec > that is stupid behavior as well. I had a closer look and it is the best thing it could do. In all but one cases, the function

Re: [PATCH v6 07/36] nds32: Exception handling

2018-01-24 Thread Arnd Bergmann
On Wed, Jan 24, 2018 at 11:53 AM, Vincent Chen wrote: > 2018-01-18 18:14 GMT+08:00 Arnd Bergmann : >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> This patch includes the exception/interrupt entries, pt_reg structure and >>> related accessors. >>> >>> Signe

Re: [PATCH v6 07/36] nds32: Exception handling

2018-01-24 Thread Arnd Bergmann
On Wed, Jan 24, 2018 at 12:09 PM, Arnd Bergmann wrote: > On Wed, Jan 24, 2018 at 11:53 AM, Vincent Chen wrote: >> 2018-01-18 18:14 GMT+08:00 Arnd Bergmann : > Ok. I still wonder about the kernel part of this though: is it a good idea > for user space to configure whether the kernel does unaligne

Re: [PATCH v6 20/36] nds32: Signal handling support

2018-01-24 Thread Arnd Bergmann
On Wed, Jan 24, 2018 at 1:56 AM, Vincent Chen wrote: > 2018-01-18 18:30 GMT+08:00 Arnd Bergmann : >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> This patch adds support for signal handling. >>> >>> Signed-off-by: Vincent Chen >>> Signed-off-by: Greentime

[PATCH net-next 0/3] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Christian Brauner
Hi, Based on the previous discussion this enables passing a IFLA_IF_NETNSID property along with RTM_SETLINK and RTM_DELLINK requests. The patch for RTM_NEWLINK will be sent out in a separate patch since there are more corner-cases to think about. Best, Christian Christian Brauner (3): rtnetlin

[PATCH net-next 1/3] rtnetlink: enable IFLA_IF_NETNSID in do_setlink()

2018-01-24 Thread Christian Brauner
RTM_{NEW,SET}LINK already allow operations on other network namespaces by identifying the target network namespace through IFLA_NET_NS_{FD,PID} properties. This is done by looking for the corresponding properties in do_setlink(). Extend do_setlink() to also look for the IFLA_IF_NETNSID property. Th

Re: [PATCH v6 16/36] nds32: DMA mapping API

2018-01-24 Thread Arnd Bergmann
On Tue, Jan 23, 2018 at 12:52 PM, Greentime Hu wrote: > Hi, Arnd: > > 2018-01-23 16:23 GMT+08:00 Greentime Hu : >> Hi, Arnd: >> >> 2018-01-18 18:26 GMT+08:00 Arnd Bergmann : >>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: From: Greentime Hu This patch adds support for the

[PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter()

2018-01-24 Thread Sathya Perla
When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags. This flag (via tc_in_hw()) must be checked before issuing the call to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the call to query st

[PATCH net-next 2/3] rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK

2018-01-24 Thread Christian Brauner
- Backwards Compatibility: If userspace wants to determine whether RTM_SETLINK supports the IFLA_IF_NETNSID property they should first send an RTM_GETLINK request with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply does not include IFLA_IF_NETNSID userspace should assume

[PATCH net-next 3/3] rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK

2018-01-24 Thread Christian Brauner
- Backwards Compatibility: If userspace wants to determine whether RTM_DELLINK supports the IFLA_IF_NETNSID property they should first send an RTM_GETLINK request with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply does not include IFLA_IF_NETNSID userspace should assume

[PATCH net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket

2018-01-24 Thread Sowmini Varadhan
allow the application to set SO_ZEROCOPY on the underlying sk of a PF_RDS socket Signed-off-by: Sowmini Varadhan --- net/core/sock.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index 72d14b2..3c75adc 100644

[PATCH net-next 6/7] selftests/net: add support for PF_RDS sockets

2018-01-24 Thread Sowmini Varadhan
Add support for basic PF_RDS client-server testing in msg_zerocopy Signed-off-by: Sowmini Varadhan --- tools/testing/selftests/net/msg_zerocopy.c | 65 +++- 1 files changed, 64 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/net/msg_zerocopy.c b/too

Re: [PATCH] net:l2tp: Allow MAC to be configured via netlink

2018-01-24 Thread Guillaume Nault
On Wed, Jan 24, 2018 at 04:58:44PM +1300, Isaac Lee wrote: > The linux kernel by default uses random MAC address > for l2tp interfaces. However, there are situations > where it is desirable to have a deterministic MAC address. > > A sample scenario would be where the host IP stack is attached > di

[PATCH net-next 5/7] rds: zerocopy Tx support.

2018-01-24 Thread Sowmini Varadhan
If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg() are pinned. The pinning uses the accounting infrastructure added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY p

[PATCH net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules

2018-01-24 Thread Sowmini Varadhan
RDS would like to use the helper functions for managing pinned pages added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY pages") Signed-off-by: Sowmini Varadhan --- include/linux/skbuff.h |3 +++ net/core/skbuff.c |6 -- 2 files changed, 7 insertions(+), 2 deletions(-)

[PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

2018-01-24 Thread Sowmini Varadhan
Send a cookie with sendmsg() on PF_RDS sockets, and process the returned batched cookies in do_recv_completion() Signed-off-by: Sowmini Varadhan --- tools/testing/selftests/net/msg_zerocopy.c | 119 --- 1 files changed, 88 insertions(+), 31 deletions(-) diff --git a/too

[PATCH net-next 4/7] rds: support for zcopy completion notification

2018-01-24 Thread Sowmini Varadhan
RDS removes a datagram (rds_message) from the retransmit queue when an ACK is received. The ACK indicates that the receiver has queued the RDS datagram, so that the sender can safely forget the datagram. When all references to the rds_message are quiesced, rds_message_purge is called to release res

[PATCH net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock

2018-01-24 Thread Sowmini Varadhan
The existing model holds a reference from the rds_sock to the rds_message, but the rds_message does not itself hold a sock_put() on the rds_sock. Instead the m_rs field in the rds_message is assigned when the message is queued on the sock, and nulled when the message is dequeued from the sock. We

[PATCH net-next 0/7] RDS zerocopy support

2018-01-24 Thread Sowmini Varadhan
This patch series follows up on the RFC and subsequent review comments at https://patchwork.ozlabs.org/cover/862248/ Review comments addressed are - drop MSG_PEEK change for sk_error_queue - (patch4) batch of SO_EE_ORIGIN_MAX_ZCOOKIES (#defined to 8) is sent up as part of the data in the error n

Re: [Intel-wired-lan] [PATCH] igb: add VF trust infrastructure

2018-01-24 Thread Corinna Vinschen
On Jan 24 03:41, Brown, Aaron F wrote: > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > > Behalf Of Alexander Duyck > > Sent: Monday, January 22, 2018 2:58 PM > > To: intel-wired-lan ; Netdev > > > > Cc: Corinna Vinschen > > Subject: Re: [Intel-wired-lan] [PATCH] igb: ad

Re: [PATCH net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-24 Thread Ido Schimmel
On Tue, Jan 23, 2018 at 07:13:43PM -0800, David Ahern wrote: > IPv6 allows routes to be installed when the device is not up (admin up). > Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really > there is no reason for IPv6 to allow it, so check the flags and deny if > device is a

[PATCH v2 1/2] net/ibm/emac: add 8192 rx/tx fifo size

2018-01-24 Thread Ivan Mikhaylov
emac4syn chips has availability to use 8192 rx/tx fifo buffer sizes, in current state if we set it up in dts 8192 as example, we will get only 2048 which may impact on network speed. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/ibm/emac/core.c |6 ++ drivers/net/ethernet/ibm/em

[PATCH v2 2/2] net/ibm/emac: wrong bit is used for STA control register write

2018-01-24 Thread Ivan Mikhaylov
STA control register has areas of mode and opcodes for opeations. 18 bit is using for mode selection, where 0 is old MIO/MDIO access method and 1 is indirect access mode. 19-20 bits are using for setting up read/write operation(STA opcodes). In current state 'read' is set into old MIO/MDIO mode wit

[PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

2018-01-24 Thread Wang YanQing
If we then OR this with 0x40, then the value of 6th bit (0th is first bit) become known, so the right mask is 0xbf instead of 0xcf. Signed-off-by: Wang YanQing --- Documentation/networking/filter.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/fil

Re: [PATCH v2] wcn36xx: release resources in case of error

2018-01-24 Thread Kalle Valo
Ramon Fried writes: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Change-Id: I924bd7489b60243c0a0cbaa716caf924f11d7587 > Signed-off-by: Ramon Fried This compiled now, thanks. But I did som

Hello dear

2018-01-24 Thread verify
Hello dear My name is abudul Ahassan, I work with one of the leading Banks here in Africa. I have a business proposal worth 18$million dollars for more information contact me on my private email (maliahassan57@gmail. com) I urgently hope to get your response as soon as possible. Yours Sinc

Re: [PATCH net-next] [net] softnet_data: Split time_squeeze counter to provide budget_squeeze

2018-01-24 Thread Patrick Talbert
On Tue, Jan 23, 2018 at 6:07 PM, Eric Dumazet wrote: > On Tue, 2018-01-23 at 10:37 -0500, Patrick Talbert wrote: >> Add a 'budget_squeeze' counter to be able to differenciate between a >> NAPI poll ending with outstanding work because of a lack of budget >> (netdev_budget) versus ending because of

Re: [RFC] batman-adv: always assume 2-byte packet alignment

2018-01-24 Thread Sven Eckelmann
On Mittwoch, 24. Januar 2018 12:21:37 CET Matthias Schiffer wrote: > NIC drivers generally try to ensure that the "network header" is aligned > to a 4-byte boundary. This is not always possible: When Ethernet frames are > encapsulated in other packets with 4-byte aligned headers, the inner > Ethern

RE: [net-next v2 15/15] i40e: link_down_on_close private flag support

2018-01-24 Thread Stachura, Mariusz
>On Tue, 23 Jan 2018 10:55:33 +, Stachura, Mariusz wrote: >> Hello Kuba, > >Hi Mariusz! > >> First of all sorry for a long response. >> >> Did you have a chance to try it using instruction I've sent? > >Unfortunately, I can't take the machine with Fortville down ATM to swap >kernels. Is this

Re: [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks

2018-01-24 Thread Eric Dumazet
On Tue, 2018-01-23 at 23:57 -0800, Lawrence Brakmo wrote: > This patchset adds support for: > > - direct R or R/W access to many tcp_sock fields > - passing up to 4 arguments to sock_ops BPF functions > - tcp_sock field bpf_sock_ops_cb_flags for controlling callbacks > - optionally calling sock_op

[PATCH net-next 3/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK

2018-01-24 Thread Christian Brauner
- Backwards Compatibility: If userspace wants to determine whether RTM_DELLINK supports the IFLA_IF_NETNSID property they should first send an RTM_GETLINK request with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply does not include IFLA_IF_NETNSID userspace should assume

[PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Christian Brauner
Hi, Based on the previous discussion this enables passing a IFLA_IF_NETNSID property along with RTM_SETLINK and RTM_DELLINK requests. The patch for RTM_NEWLINK will be sent out in a separate patch since there are more corner-cases to think about. Best, Christian Changelog 2018-01-24: * Preserve

[PATCH net-next 2/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK

2018-01-24 Thread Christian Brauner
- Backwards Compatibility: If userspace wants to determine whether RTM_SETLINK supports the IFLA_IF_NETNSID property they should first send an RTM_GETLINK request with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply does not include IFLA_IF_NETNSID userspace should assume

[PATCH net-next 1/3 V1] rtnetlink: enable IFLA_IF_NETNSID in do_setlink()

2018-01-24 Thread Christian Brauner
RTM_{NEW,SET}LINK already allow operations on other network namespaces by identifying the target network namespace through IFLA_NET_NS_{FD,PID} properties. This is done by looking for the corresponding properties in do_setlink(). Extend do_setlink() to also look for the IFLA_IF_NETNSID property. Th

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-01-24 Thread Tal Gilboa
Hi Eric, My choice of words in my comment was misplaced, and I apologies. It completely missed the point. I understand, of course, the importance of optimizing real-life scenarios. We are currently evaluating this patch and if/how it might affect our customers. We would also evaluate your sug

Re: [PATCH 4.14-stable] xfrm: Fix a race in the xdst pcpu cache.

2018-01-24 Thread David Miller
From: Steffen Klassert Date: Wed, 24 Jan 2018 10:13:25 +0100 > commit 76a4201191814a0061cb5c861fafb9ecaa764846 upstream. > > We need to run xfrm_resolve_and_create_bundle() with > bottom halves off. Otherwise we may reuse an already > released dst_enty when the xfrm lookup functions are > called

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2018-01-24 Thread Eric Dumazet
On Wed, 2018-01-24 at 16:42 +0200, Tal Gilboa wrote: > Hi Eric, > My choice of words in my comment was misplaced, and I apologies. It > completely missed the point. I understand, of course, the importance of > optimizing real-life scenarios. > > We are currently evaluating this patch and if/how

Re: [PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

2018-01-24 Thread Edward Cree
On 24/01/18 07:48, Wang YanQing wrote: > If we then OR this with 0x40, then the value of 6th bit (0th is first bit) > become known, so the right mask is 0xbf instead of 0xcf. > > Signed-off-by: Wang YanQing > --- > Documentation/networking/filter.txt | 2 +- > 1 file changed, 1 insertion(+), 1 de

[PATCH net-next V2] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan

2018-01-24 Thread Ganesh Goudar
implement ndo_set_vf_vlan for mgmt netdevice to configure the PCIe VF. Original work by: Casey Leedom Signed-off-by: Ganesh Goudar --- V2: changing htonl() to cpu_to_be32() to maintain consistency --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 ++ drivers/net/ethernet/chelsio/cxgb4

Re: [PATCH net-next 1/2] kcm: Only allow TCP sockets to be attached to a KCM mux

2018-01-24 Thread Guillaume Nault
On Tue, Jan 23, 2018 at 05:00:13PM -0800, Tom Herbert wrote: > TCP sockets for IPv4 and IPv6 that are not listeners or in closed > stated are allowed to be attached to a KCM mux. > > Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module") > Reported-by: syzbot+8865eaff7f9acd593...@syzkal

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Nicolas Dichtel
Hi, Le 24/01/2018 à 15:26, Christian Brauner a écrit : > Hi, > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > RTM_NEWLINK will be sent out in a separate patch since there are more > corner-cases

Re: [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks

2018-01-24 Thread Alexei Starovoitov
On 1/24/18 6:14 AM, Eric Dumazet wrote: On Tue, 2018-01-23 at 23:57 -0800, Lawrence Brakmo wrote: This patchset adds support for: - direct R or R/W access to many tcp_sock fields - passing up to 4 arguments to sock_ops BPF functions - tcp_sock field bpf_sock_ops_cb_flags for controlling callbac

Re: [PATCH 4.14-stable] xfrm: Fix a race in the xdst pcpu cache.

2018-01-24 Thread Greg KH
On Wed, Jan 24, 2018 at 09:57:06AM -0500, David Miller wrote: > From: Steffen Klassert > Date: Wed, 24 Jan 2018 10:13:25 +0100 > > > commit 76a4201191814a0061cb5c861fafb9ecaa764846 upstream. > > > > We need to run xfrm_resolve_and_create_bundle() with > > bottom halves off. Otherwise we may reus

Re: pull request (net): ipsec 2018-01-24

2018-01-24 Thread David Miller
From: Steffen Klassert Date: Wed, 24 Jan 2018 10:47:09 +0100 > 1) Only offloads SAs after they are fully initialized. >Otherwise a NIC may receive packets on a SA we can >not yet handle in the stack. >From Yossi Kuperman. > > 2) Fix negative refcount in case of a failing offload. >

Re: [PATCH net-next 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload_init()

2018-01-24 Thread David Miller
From: Jakub Kicinski Date: Tue, 23 Jan 2018 18:45:58 -0800 > Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__() > and add a new implementation which also takes flags argument. We will > only set extack if flags indicate that offload is forced (skip_sw) > otherwise driver error

Re: [PATCH] net: make sure skb_dst is valid before using

2018-01-24 Thread Nicolas Dichtel
Le 24/01/2018 à 10:49, Roman Kapl a écrit : > On 01/24/2018 10:16 AM, Xin Long wrote: >> On Wed, Jan 24, 2018 at 6:42 AM, Roman Kapl wrote: >>> Tunnel devices often use skb_dst(skb)->ops, but ops are not implemented >>> for metadata tunnel destinations. Use skb_valid_dst to check if skb_dst >>> is

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 10:19:24 +0100 Phil Sutter wrote: > Hi Stephen, > > On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: > > On Tue, 23 Jan 2018 17:40:47 +0100 > > Phil Sutter wrote: > > > > > The following command segfaults if enp0s31f6 does not exist: > > > > > > | # ip

Re: [PATCH] bpf, doc: Correct one wrong value in "Register value tracking"

2018-01-24 Thread Daniel Borkmann
On 01/24/2018 08:48 AM, Wang YanQing wrote: > If we then OR this with 0x40, then the value of 6th bit (0th is first bit) > become known, so the right mask is 0xbf instead of 0xcf. > > Signed-off-by: Wang YanQing Applied to bpf-next, thanks Wang!

Re: rtl8xxxu: Fix trailing semicolon

2018-01-24 Thread Kalle Valo
Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt > Acked-by: Jes Sorensen Patch applied to wireless-drivers-next.git, thanks. 8054a275de08 rtl8xxxu: Fix trailin

Re: [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks

2018-01-24 Thread Eric Dumazet
On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote: > > Most of the time, Yes, but it's the other way around this time. > I specifically asked Larry to do it this way, since net tree is > practically closed (only critical fixes allowed). > When 4.15 is released on Sunday we'll send this p

Re: [PATCH net-next V2] cxgb4/cxgb4vf: add support for ndo_set_vf_vlan

2018-01-24 Thread David Miller
From: Ganesh Goudar Date: Wed, 24 Jan 2018 20:44:07 +0530 > implement ndo_set_vf_vlan for mgmt netdevice to configure > the PCIe VF. > > Original work by: Casey Leedom > Signed-off-by: Ganesh Goudar > --- > V2: changing htonl() to cpu_to_be32() to maintain consistency Applied, thanks.

Fw: [Bug 198571] New: [af_netlink]missing wakeup while closing af_netlink socket

2018-01-24 Thread Stephen Hemminger
Forwarding this to netdev because group may have different opinions. IMHO netlink is a multicast communication mechanism and therefore not it does not have the close semantics of other connection oriented protocols. Therefore this is not a bug. Begin forwarded message: Date: Wed, 24 Jan 2018 12:2

Re: [PATCH net-next 0/6] net/smc: socket closing improvements

2018-01-24 Thread David Miller
From: Ursula Braun Date: Wed, 24 Jan 2018 10:28:11 +0100 > while the first 2 patches are just small cleanups, the remaing > patches affect socket closing. Series applied, thanks!

Re: [PATCH net-next 0/2] cxgb4: fix build error

2018-01-24 Thread David Miller
From: Rahul Lakkireddy Date: Wed, 24 Jan 2018 13:31:03 +0530 > Patch 1 fixes build error with compiling cudbg_zlib.c when > CONFIG_ZLIB_DEFLATE macro is not defined. > > Patch 2 fixes following sparse warning: > "Using plain integer as NULL pointer" Series applied, thanks Rahul.

Re: [patch net] mlxsw: spectrum_router: Don't log an error on missing neighbor

2018-01-24 Thread David Miller
From: Jiri Pirko Date: Wed, 24 Jan 2018 10:02:09 +0100 > From: Yuval Mintz > > Driver periodically samples all neighbors configured in device > in order to update the kernel regarding their state. When finding > an entry configured in HW that doesn't show in neigh_lookup() > driver logs an erro

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-24 Thread Alexander Duyck
On Wed, Jan 24, 2018 at 12:35 AM, Benjamin Poirier wrote: > On 2018/01/22 10:01, Alexander Duyck wrote: > [...] >> > >> > If the patch that I submitted for the current vmware issue is merged, >> > the significant commits that are left are: >> > >> > 0a8047ac68e5 e1000e: Fix msi-x interrupt automas

Re: [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter()

2018-01-24 Thread Jiri Pirko
Wed, Jan 24, 2018 at 12:42:55PM CET, sathya.pe...@broadcom.com wrote: >When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns >error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags. > >This flag (via tc_in_hw()) must be checked before issuing the call >to delete a fi

Re: e1000e hardware unit hangs

2018-01-24 Thread Alexander Duyck
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote: > Hello, > > Anyone have any more suggestions for making e1000e work better? This is > from a 4.9.65+ kernel, > with these additional e1000e patches applied: > > e1000e: Fix error path in link detection > e1000e: Fix wrong comment related to link

[PATCH v2 net-next] net/ipv6: Do not allow route add with a device that is down

2018-01-24 Thread David Ahern
IPv6 allows routes to be installed when the device is not up (admin up). Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really there is no reason for IPv6 to allow it, so check the flags and deny if device is admin down. Signed-off-by: David Ahern --- v2 - missed setting err t

Re: e1000e hardware unit hangs

2018-01-24 Thread Neftin, Sasha
On 1/24/2018 18:11, Alexander Duyck wrote: On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote: Hello, Anyone have any more suggestions for making e1000e work better? This is from a 4.9.65+ kernel, with these additional e1000e patches applied: e1000e: Fix error path in link detection e1000e: F

Re: virtio_net occasionally stops sending packets

2018-01-24 Thread Brian Rak
Interestingly, we thought we had just been seeing this on the second nic.  However, we've went back through some older logs and realized that it's been happening on the first nic as well, though it's presenting itself slightly differently there (ping just says "Destination Host Unreachable"). 

Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK

2018-01-24 Thread Jiri Benc
On Wed, 24 Jan 2018 16:24:34 +0100, Nicolas Dichtel wrote: > I wonder if it would be possible to do something in the netlink framework, > like > NETLINK_LISTEN_ALL_NSID. > Having some ancillary data at the netlink socket level and a function like > nlsock_net() (instead of sock_net()) to get the c

Re: [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks

2018-01-24 Thread Alexei Starovoitov
On 1/24/18 7:48 AM, Eric Dumazet wrote: On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote: Most of the time, Yes, but it's the other way around this time. I specifically asked Larry to do it this way, since net tree is practically closed (only critical fixes allowed). When 4.15 is rel

  1   2   3   >