Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

Just to restore a bit of faith in syzbot, I've checked 4.15-rc9 commit log and 28 out of 212 commits turn out to be fixes for bugs found by syzbot: Alexei Starovoitov (1): bpf: fix 32-bit divide by zero Cong Wang (2): tipc: fix a memory leak in tipc_nl_node_get_link() tun: fix a

Re: [PATCH net-next] net: link_watch: mark bonding link events urgent

Mon, Jan 22, 2018 at 07:07:53AM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >It takes 1sec for bond link down notification to hit user-space >when all slaves of the bond go down. 1sec is too long for >protocol daemons in user-space relying on bond link notification >to failover/rec

[patch net-next 2/3] mlxsw: spectrum_router: Pass FIB node to LPM tree unlink function

From: Ido Schimmel Next patch will try to optimize the LPM tree and make sure only used prefix lengths are present, to avoid unnecessary look-ups. Pass the currently removed FIB node to the unlinking function as its associated prefix length is a potential candidate for removal from the tree. Si

[patch net-next 3/3] mlxsw: spectrum_router: Remove unnecessary prefix lengths from LPM tree

From: Ido Schimmel In commit fc922bb0dd94 ("mlxsw: spectrum_router: Use one LPM tree for all virtual routers") I tried to make sure only used prefix lengths are present in the LPM tree shared between all virtual routers. However, this optimization had to be removed in commit a69518cf0b4c ("mlxsw

[patch net-next 0/3] mlxsw: spectrum_router: Optimize LPM trees

From: Jiri Pirko Ido says: This set tries to optimize the structure of the LPM trees used for route lookup by avoiding lookups that are guaranteed not to return a result. This is done by making sure only used prefix lengths are present in the tree. First two patches are small preparatory steps

[patch net-next 1/3] mlxsw: spectrum_router: Use the nodes list as indication for empty FIB

From: Ido Schimmel Currently, each FIB (IPv4 / IPv6) in a virtual router holds a prefix usage that is used to choose a matching LPM tree, but also to check if the FIB is empty, so that the LPM tree could be unbound. Next patches will remove the reliance on the per-FIB prefix usage for LPM tree m

Re: [PATCH] igb: add VF trust infrastructure

Hi, Could somebody please review this patch? Thanks, Corinna On Jan 17 11:53, Corinna Vinschen wrote: > * Add a per-VF value to know if a VF is trusted, by default don't > trust VFs. > > * Implement netdev op to trust VFs (igb_ndo_set_vf_trust) and add > trust status to ndo_get_vf_config

***BULK*** MICROSOFT URGENT EMAIL ATTENTION

MICROSOFT URGENT EMAIL ATTENTION Lots of your messages are currently suspended because your E-mail box account needs to be verify now. Do verify now inother to receive your pending messages without no delay. ©2018 Microsoft Outlook Inc.

[PATCH] net: Make synchronize_net() be expedited only when it's really need

Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing synchronize_net() says: >When we hold RTNL mutex, we would like to spend some cpu cycles but not >block too long other processes waiting for this mutex. >We also want to setup/dismantle network features as fast as p

Re: [PATCH v6 06/36] nds32: Kernel booting and initialization

2018-01-20 0:41 GMT+08:00 Arnd Bergmann : > On Fri, Jan 19, 2018 at 5:34 PM, Greentime Hu wrote: >> Hi, Arnd: >> >> 2018-01-18 18:11 GMT+08:00 Arnd Bergmann : >>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>> >>> I had not looked at this patch in enough detail earlier, sorry about >>>

Re: [PATCH v6 06/36] nds32: Kernel booting and initialization

On Mon, Jan 22, 2018 at 10:49 AM, Greentime Hu wrote: > 2018-01-20 0:41 GMT+08:00 Arnd Bergmann : >>> This implementation is referenced from openrisc. >>> https://lkml.org/lkml/2017/11/17/228 >> >> It's correct on openrisc, because that has a reliable cycle counter, >> and that gets used in its d

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

Hi, Geert: 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : > Hi Greentime, > > On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : > On

[PATCH][next] devlink: fix memory leak on 'resource'

From: Colin Ian King Currently, if the call to devlink_resource_find returns null then the error exit path does not free the devlink_resource 'resource' and a memory leak occurs. Fix this by kfree'ing resource on the error exit path. Detected by CoverityScan, CID#1464184 ("Resource leak") Fixes

Re: [PATCH][next] devlink: fix memory leak on 'resource'

Mon, Jan 22, 2018 at 11:31:19AM CET, colin.k...@canonical.com wrote: >From: Colin Ian King > >Currently, if the call to devlink_resource_find returns null then >the error exit path does not free the devlink_resource 'resource' >and a memory leak occurs. Fix this by kfree'ing resource on the >error

esp spi incorrectly reported by ip -s x p

Hello everyone, I'm running strongSwan 5.6.1 on linux-4.14.x (slackware 14.2 64bit) with iproute 4.14.1 When I issue 'ip -x s p', I get this output: src 10.180.0.0/16 dst 10.81.110.10/32 uid 0 dir out action allow index 137 priority 375423 share any flag (0x) lifetime c

[PATCH v2 net 0/2] nbyte, cmp and text filter fixups

Changes: * Fixed up commit message * Removed not really related iproute2 patch from this thread. This fixes an oob read in em_nbyte and allows 'layer 0' in cmp and nbyte and em_text to actually match layer 0 rather than being the same as specifying layer 1. Wolfgang Bumiller (2): net: sched

[PATCH iproute2] tc/lexer: let quotes actually start strings

The lexer will go with the longest match, so previously the starting double quotes of a string would be swallowed by the [^ \t\r\n()]+ pattern leaving the user no way to actually use strings with escape sequences. Fix this by not allowing this case to start with double quotes. Signed-off-by: Wolfg

[PATCH v2 net 1/2] net: sched: em_nbyte: don't add the data offset twice

'ptr' is shifted by the offset and then validated, the memcmp should not add it a second time. Signed-off-by: Wolfgang Bumiller --- No changes in this patch net/sched/em_nbyte.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/em_nbyte.c b/net/sched/em_nbyte.c index

[PATCH v2 net 2/2] net: sched: fix TCF_LAYER_LINK case in tcf_get_base_ptr

TCF_LAYER_LINK and TCF_LAYER_NETWORK returned the same pointer as skb->data points to the network header. Use skb_mac_header instead. Signed-off-by: Wolfgang Bumiller --- Only change: fixed up commit message Previous comment: Alternatively this could return skb->head directly, but 'sk_buff->

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu wrote: > 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : >> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >>> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >>> Thank you and your ex

Re: [PATCH net-next v2 2/2] net/sched: act_csum: don't use spinlock in the fast path

hello Cong, On Sun, 2018-01-21 at 12:28 -0800, Cong Wang wrote: > > + params = rcu_dereference(p->params); > > I think you need rtnl_dereference() here, as we don't have RCU read lock here? you are right, thank you for spotting this. I will send v3 series today. regards, -- davide

[PATCH] RDS: Fix rds-ping inducing kernel panic

As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine. A local u

Re: [PATCH v2] smc: return booleans instead of integers

On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Fix function using_ipsec as sug

Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

Hi Guo, > This patch fix the bluetooth 6lowpan disconnect fail bug. > > The type of the same address type have different define value in HCI layer > and L2CAP layer.That makes disconnect fail due to wrong network type.User > will not be able to disconnect from console with the network type that u

Re: [PATCHv3] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

On Mon, Jan 22, 2018 at 01:27:19AM -0500, tedheadster wrote: > On Wed, Jan 3, 2018 at 1:44 PM, David Miller wrote: > > From: Neil Horman > > Date: Wed, 3 Jan 2018 13:09:23 -0500 > > > >> A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > >> WARN_ONS to trigger. Clean those

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

Hi David, There's a discussion about the ACPI vs generic MDIO/PHY change under initial version of the patchset, however the patches in question were for now abandoned from further re-sends. As the v4 has had no objections until now and: - patches 1-2 were Acked-by: Rafael J. Wysocki - mvpp2 patc

Re: [PATCH] Bluetooth: 6lowpan: Fix disconnect bug in 6lowpan

Hi Alex, On Wed, Jan 17, 2018 at 3:37 PM, Alexander Aring wrote: > Hi, > > 2018-01-17 7:15 GMT-05:00 Luiz Augusto von Dentz : >> Hi, >> >> On Wed, Jan 17, 2018 at 1:47 AM, Guo Yi wrote: >>> This patch fix the bluetooth 6lowpan disconnect fail bug. >>> >>> The type of the same address type have d

pull-request: mac80211-next 2018-01-22

Hi Dave, A few more (only four, really) changes have come in, so I figured since the merge window hasn't opened yesterday, I'd still send them to you. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 564737f981fb4b4b3266901508bb9b90d9d43d

[PATCH net-next] cxgb4: add geneve offload support for T6

Add geneve segmentation offload support of T6 cards. Original work by: Santosh Rastapur Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 2 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 71 - drivers/net/ethernet/chelsio/cxgb4/sge

Re: [PATCH net v3] gso: validate gso_type in GSO handlers

On Fri, Jan 19, 2018 at 09:29:18AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Validate gso_type during segmentation as SKB_GSO_DODGY sources > may pass packets where the gso_type does not match the contents. > > Syzkaller was able to enter the SCTP gso handler with a packet of >

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Thu, Jan 18, 2018 at 3:05 PM, Greg Kroah-Hartman wrote: > On Thu, Jan 18, 2018 at 02:01:28PM +0100, Dmitry Vyukov wrote: >> On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: >> > On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: >> >> >> >> If syzkaller can only test one

Re: WARNING in sysfs_warn_dup

On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov wrote: >> >> On Tue, Dec 19, 2017 at 10:01 AM, Greg KH wrote: >>> >>> On Mon, Dec 18, 2017 at 08:57:01AM -0800, syzbot wrote: >>> > Hello, >>> > >>> > syzkaller hit the following crash on >>>

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

Hi, Arnd: 2018-01-22 19:15 GMT+08:00 Arnd Bergmann : > On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu wrote: >> 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : > On Fri, Jan 19, 2018

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: > > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov wrote: > >> > >> On Tue, Dec 19, 2017 at 10:01 AM, Greg KH > >> wrote: > >>> > >>> On Mon, Dec 18, 2017 at 08:57:01AM -0800

Re: [PATCH bpf-next 0/4] libbpf: add XDP binding support

On 01/20/2018 09:28 AM, Éric Leblond wrote: > Hi, > > Le 20 janv. 2018 9:21 AM, Daniel Borkmann a écrit : > > On 01/20/2018 03:27 AM, Alexei Starovoitov wrote: > > On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote: > >> On 01/19/2018 12:43 AM, Eric Leblond wrote: >

[PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names

From: Vadim Lomovtsev It was found that ethtool provides unexisting module name while it queries the specified network device for associated driver information. Then user tries to unload that module by provided module name and fails. This happens because ethtool reads value of DRV_NAME macro, wh

Re: [PATCH net-next] tun: add missing rcu annotation

From: Jason Wang Date: Mon, 22 Jan 2018 10:55:38 +0800 > This patch fixes the following sparse warnings: > > drivers/net/tun.c:2241:15: error: incompatible types in comparison expression > (different address spaces) > > Fixes: cd5681d7d890 ("tuntap: rename struct tun_steering_prog to struct >

Re: [patch net-next 0/3] mlxsw: spectrum_router: Optimize LPM trees

From: Jiri Pirko Date: Mon, 22 Jan 2018 09:17:39 +0100 > From: Jiri Pirko > > Ido says: > > This set tries to optimize the structure of the LPM trees used for route > lookup by avoiding lookups that are guaranteed not to return a result. > This is done by making sure only used prefix lengths a

Re: [PATCH][next] devlink: fix memory leak on 'resource'

From: Colin King Date: Mon, 22 Jan 2018 10:31:19 + > From: Colin Ian King > > Currently, if the call to devlink_resource_find returns null then > the error exit path does not free the devlink_resource 'resource' > and a memory leak occurs. Fix this by kfree'ing resource on the > error exit

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 3:00 PM, Greg KH wrote: > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: >> On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: >> > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov wrote: >> >> >> >> On Tue, Dec 19, 2017 at 10:01 AM, Greg KH >> >> wro

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

From: Marcin Wojtas Date: Mon, 22 Jan 2018 14:00:37 +0100 > There's a discussion about the ACPI vs generic MDIO/PHY change under > initial version of the patchset, however the patches in question were > for now abandoned from further re-sends. But doesn't the results of that discussion determine

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

On Mon, Jan 22, 2018 at 09:35:25AM -0500, David Miller wrote: > From: Marcin Wojtas > Date: Mon, 22 Jan 2018 14:00:37 +0100 > > > There's a discussion about the ACPI vs generic MDIO/PHY change under > > initial version of the patchset, however the patches in question were > > for now abandoned fr

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 03:30:12PM +0100, Dmitry Vyukov wrote: > On Mon, Jan 22, 2018 at 3:00 PM, Greg KH wrote: > > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: > >> On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: > >> > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov

[PATCH iproute2-next] gre/gre6: Post merge fixes

Few minor changes after merge of 'master' into 'net-next' branch: 1) Follow 80 line length for printing erspan_index parameter as we did in master with commit 2a8d0f6e9c3f ("gre/tunnel: Print erspan_index using print_uint()"). 2) Remove remnants of encapsulation option printing: now

Re: [bisected] Forwarded packets occasionally has loopback output interface in Netfilter

On tor, 2018-01-11 at 10:18 -0800, Wei Wang wrote: > On Thu, Jan 11, 2018 at 9:25 AM, Anders K. Pedersen | Cohaesio > wrote: > > On tir, 2017-12-26 at 12:05 +0100, Anders K. Pedersen | Cohaesio > > wrote: > > > Hello, > > > > > > On one of our border routers, Netfilter is occasionally logging > >

[PATCH] sysfs: turn WARN() into pr_warn()

From: Greg Kroah-Hartman It's not good to crash the machine if panic_on_warn() is set just because someone made a stupid mistake of trying to create a sysfs file with the same name of an existing one. This makes the automated testing tools a lot harder to find the real bugs in the kernel. So ju

hi

-- I am Mrs Nicole i have a pending project of fulfillment to put in your hand, i will need your support to make this ream come through, could you le me know your interest to enable me give you further information, and I hereby advice that you send the below mentioned information I decided to

Re: [PATCH] sysfs: turn WARN() into pr_warn()

On Mon, Jan 22, 2018 at 3:57 PM, Greg KH wrote: > From: Greg Kroah-Hartman > > It's not good to crash the machine if panic_on_warn() is set just > because someone made a stupid mistake of trying to create a sysfs file > with the same name of an existing one. This makes the automated testing > to

Re: WARNING in sysfs_warn_dup

On Mon, Jan 22, 2018 at 3:45 PM, Greg KH wrote: > On Mon, Jan 22, 2018 at 03:30:12PM +0100, Dmitry Vyukov wrote: >> On Mon, Jan 22, 2018 at 3:00 PM, Greg KH wrote: >> > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: >> >> On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov >> >> wro

Re: len = bpf_probe_read_str(); bpf_perf_event_output(... len) == FAIL

Em Wed, Nov 22, 2017 at 10:42:22AM -0800, Gianluca Borello escreveu: > On Tue, Nov 21, 2017 at 2:31 PM, Alexei Starovoitov > wrote: > > > > yeah sorry about this hack. Gianluca reported this issue as well. > > Yonghong fixed it for bpf_probe_read only. We will extend > > the fix to bpf_probe_read_

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: > As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 > > Attempting an RDS connection from the IP address of an IPoIB interface > to itself causes a kernel panic due to a BUG_ON() being triggered. > Making the test less str

Re: [PATCH net-next] net: link_watch: mark bonding link events urgent

On Mon, Jan 22, 2018 at 12:13 AM, Jiri Pirko wrote: > Mon, Jan 22, 2018 at 07:07:53AM CET, ro...@cumulusnetworks.com wrote: >>From: Roopa Prabhu >> >>It takes 1sec for bond link down notification to hit user-space >>when all slaves of the bond go down. 1sec is too long for >>protocol daemons in u

Re: pull-request: mac80211-next 2018-01-22

From: Johannes Berg Date: Mon, 22 Jan 2018 14:15:00 +0100 > A few more (only four, really) changes have come in, so I figured > since the merge window hasn't opened yesterday, I'd still send them > to you. > > Please pull and let me know if there's any problem. I had to resolve a conflict in ma

Re: [PATCH v6 29/36] nds32: Build infrastructure

Hi, Arnd: 2018-01-18 19:00 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds Makefile, Kconfig and vmlinux.lds.S files required for >> building >> an nds32 kernel. >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Gre

Re: [PATCH net-next] cxgb4: add geneve offload support for T6

From: Ganesh Goudar Date: Mon, 22 Jan 2018 18:48:26 +0530 > Add geneve segmentation offload support of T6 cards. > > Original work by: Santosh Rastapur > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

2018-01-22 15:43 GMT+01:00 Andrew Lunn : > On Mon, Jan 22, 2018 at 09:35:25AM -0500, David Miller wrote: >> From: Marcin Wojtas >> Date: Mon, 22 Jan 2018 14:00:37 +0100 >> >> > There's a discussion about the ACPI vs generic MDIO/PHY change under >> > initial version of the patchset, however the pa

[PATCH] net: caif: remove redundant re-assignment of pointer pfrm

From: Colin Ian King The pointer pfrm is initialized and then later re-assigned the same value and hence the second assignment is redundant and can be removed. Cleans up clang warning: drivers/net/caif/caif_hsi.c:222:6: warning: Value stored to 'pfrm' during its initialization is never read Sig

Re: pull-request: mac80211-next 2018-01-22

On Mon, 2018-01-22 at 10:17 -0500, David Miller wrote: > From: Johannes Berg > Date: Mon, 22 Jan 2018 14:15:00 +0100 > > > A few more (only four, really) changes have come in, so I figured > > since the merge window hasn't opened yesterday, I'd still send them > > to you. > > > > Please pull and

Re: [PATCH v6 29/36] nds32: Build infrastructure

On Mon, Jan 22, 2018 at 4:20 PM, Greentime Hu wrote: BE >> >> I think it's better to drop GENERIC_IRQ_PROBE here, no modern driver >> should rely on that. > > I will drop it. > >>> +choice >>> + prompt "CPU type" >>> + default CPU_V3 >>> +config CPU_N15 >>> + bool "AndesCore N15"

3.400,000.00 Eur

Frau Mavis L Wanczyk wählen Sie zu erhalten, Cash Grant Kontakt mavislwanczyk...@gmail.com für Anspruch. This message was sent using IMP, the Internet Messaging Program.

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On Mon, Jan 22, 2018 at 10:40:53AM +0800, jianchao.wang wrote: > Hi Eric > > On 01/22/2018 12:43 AM, Eric Dumazet wrote: > > On Sun, 2018-01-21 at 18:24 +0200, Tariq Toukan wrote: > >> > >> On 21/01/2018 11:31 AM, Tariq Toukan wrote: > >>> > >>> > >>> On 19/01/2018 5:49 PM, Eric Dumazet wrote: > >

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

From: Leon Romanovsky Date: Mon, 22 Jan 2018 17:10:54 +0200 > On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: >> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c >> index 8557a1cae041..5fbf635d17cb 100644 >> --- a/net/rds/ib_send.c >> +++ b/net/rds/ib_send.c >> @@ -506,7 +506,7 @@ in

Re: [PATCH net-next] net: link_watch: mark bonding link events urgent

Mon, Jan 22, 2018 at 04:14:17PM CET, ro...@cumulusnetworks.com wrote: >On Mon, Jan 22, 2018 at 12:13 AM, Jiri Pirko wrote: >> Mon, Jan 22, 2018 at 07:07:53AM CET, ro...@cumulusnetworks.com wrote: >>>From: Roopa Prabhu >>> >>>It takes 1sec for bond link down notification to hit user-space >>>when

Re: [PATCH] net: caif: remove redundant re-assignment of pointer pfrm

From: Colin King Date: Mon, 22 Jan 2018 15:25:43 + > From: Colin Ian King > > The pointer pfrm is initialized and then later re-assigned the same > value and hence the second assignment is redundant and can be removed. > > Cleans up clang warning: > drivers/net/caif/caif_hsi.c:222:6: warni

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

From: Andrew Lunn Date: Mon, 22 Jan 2018 15:43:42 +0100 > On Mon, Jan 22, 2018 at 09:35:25AM -0500, David Miller wrote: >> From: Marcin Wojtas >> Date: Mon, 22 Jan 2018 14:00:37 +0100 >> >> > There's a discussion about the ACPI vs generic MDIO/PHY change under >> > initial version of the patchs

[PATCH net-next] net: stmmac: do not use a bitwise AND operator with a bool operand

Doing a bitwise AND between a bool and an int is generally not a good idea. The bool will be promoted to an int with value 0 or 1, the int is generally regarded as true with a non-zero value, thus ANDing them has the potential to yield an undesired result. This commit fixes the following smatch wa

[PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write

STA control register has areas of mode and opcodes for opeations. 18 bit is using for mode selection, where 0 is old MIO/MDIO access method and 1 is indirect access mode. 19-20 bits are using for setting up read/write operation(STA opcodes). In current state 'read' is set into old MIO/MDIO mode wit

[PATCH 1/2] net/ibm/emac: add 8192 rx/tx fifo size

emac4syn chips has availability to use 8192 rx/tx fifo buffer sizes, in current state if we set it up in dts 8192 as example, we will get only 2048 which may impact on network speed. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/ibm/emac/core.c |6 ++ drivers/net/ethernet/ibm/em

Re: [PATCH v6 29/36] nds32: Build infrastructure

Hi, Arnd: 2018-01-22 23:38 GMT+08:00 Arnd Bergmann : > On Mon, Jan 22, 2018 at 4:20 PM, Greentime Hu wrote: > BE >>> >>> I think it's better to drop GENERIC_IRQ_PROBE here, no modern driver >>> should rely on that. >> >> I will drop it. >> +choice + prompt "CPU type" +

[PATCH net-next v2] net: link_watch: mark bonding link events urgent

From: Roopa Prabhu It takes 1sec for bond link down notification to hit user-space when all slaves of the bond go down. 1sec is too long for protocol daemons in user-space relying on bond notification to recover (eg: multichassis lag implementations in user-space). Since the link event code alrea

Re: iproute2 net-next

On 1/15/18 8:29 PM, Jakub Kicinski wrote: > About the branches - what should we base our patches on for net-next? > Most -next repos just use the master, but it seems that in case of > iproute2-next.git the net-next branch is still active, and there is > an inactive net-next branch in iproute2.git.

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

2018-01-22 16:57 GMT+01:00 David Miller : > From: Andrew Lunn > Date: Mon, 22 Jan 2018 15:43:42 +0100 > >> On Mon, Jan 22, 2018 at 09:35:25AM -0500, David Miller wrote: >>> From: Marcin Wojtas >>> Date: Mon, 22 Jan 2018 14:00:37 +0100 >>> >>> > There's a discussion about the ACPI vs generic MDIO/

Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write

On Monday, January 22, 2018 5:00:38 PM CET Ivan Mikhaylov wrote: > STA control register has areas of mode and opcodes for opeations. 18 bit is > using for mode selection, where 0 is old MIO/MDIO access method and 1 is > indirect access mode. 19-20 bits are using for setting up read/write > operatio

Re: [PATCH net-next v2] net: link_watch: mark bonding link events urgent

Mon, Jan 22, 2018 at 05:07:19PM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >It takes 1sec for bond link down notification to hit user-space >when all slaves of the bond go down. 1sec is too long for >protocol daemons in user-space relying on bond notification >to recover (eg: mult

Re: [PATCH 01/10] net: separate SIOCGIFCONF handling from dev_ioctl()

Looks nice: Reviewed-by: Christoph Hellwig

Re: [PATCH 02/10] devinet_ioctl(): take copyin/copyout to caller

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 03/10] ip_rt_ioctl(): take copyin to caller

> case SIOCGSTAMP: > @@ -884,8 +885,12 @@ int inet_ioctl(struct socket *sock, unsigned int cmd, > unsigned long arg) > break; > case SIOCADDRT: > case SIOCDELRT: > + if (copy_from_user(&rt, p, sizeof(struct rtentry))) > + return -EFAU

stmmac smatch error rx_queue_routing

Hello stmmac peeps, I found this smatch error: drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:132 dwmac4_tx_queue_routing() error: buffer overflow 'route_possibilities' 5 <= 254 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:133 dwmac4_tx_queue_routing() error: buffer overflow 'route_

Re: [PATCH 04/10] kill dev_ifsioc()

On Thu, Jan 18, 2018 at 07:37:49PM +, Al Viro wrote: > From: Al Viro > > it's been equivalent to sock_do_ioctl() since 2009... > > Signed-off-by: Al Viro Note that we have two different dev_ifsioc() defintions, which is a little weird. But the net/socket.c one does indeed seem superflous

[PATCH iproute2-next 2/2] gre/gre6: Unify attribute addition to netlink buffer

There are couple of minor improvements: 1) Check erspan_ver == 2 in gre6. It still could be 1 if erspan_idx is 0. 2) Add tunnel encapsulation attributes only when collect metadata not in effect in gre. 3) Trivial: address checkpatch issues. Signed-off-by: Serhey Popovych --- i

Re: [PATCH 05/10] kill bond_ioctl()

On Thu, Jan 18, 2018 at 07:37:50PM +, Al Viro wrote: > From: Al Viro > > another sock_do_ioctl() equivalent Except for the additional data copy. Which might be worth mentioning in the changelog.

[PATCH iproute2-next 0/2] ip/tunnel: Unify collect metadata handling

With this series I want to unify collect metadata handling in tunnels: 1) Use "collect_metadata" name for JSON and "external" keyword for non-JSON printing. Do not *print* any options when tunnel in collect metadata mode: gre6 already do this, so just apply to others. 2)

[PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

Print only "external" if collect meta data attribute is given: rest of parameters are irrelevant. This is to follow gre6. For JSON output use "collect_metadata" for iptnl, ip6tnl and gre to match with vxlan, geneve and gre6 modules. Signed-off-by: Serhey Popovych --- ip/link_gre.c| 27 +++

Re: [PATCH 10/10] kill kernel_sock_ioctl()

Looks fine, Reviewed-by: Christoph Hellwig

Re: stmmac smatch error rx_queue_routing

Hi Niklas, On 22-01-2018 16:43, Niklas Cassel wrote: > Hello stmmac peeps, > > I found this smatch error: > > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:132 > dwmac4_tx_queue_routing() error: > buffer overflow 'route_possibilities' 5 <= 254 > drivers/net/ethernet/stmicro/stmmac/dwmac4_co

Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote: > + if (tb[IFLA_GRE_COLLECT_METADATA]) { > + print_bool(PRINT_ANY, "collect_metadata", "external", true); > + return; > + } Nacked-by: Jiri Benc Don't ever use "collect_metadata" for anything visible to th

Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

Jiri Benc wrote: > On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote: >> +if (tb[IFLA_GRE_COLLECT_METADATA]) { >> +print_bool(PRINT_ANY, "collect_metadata", "external", true); >> +return; >> +} > > Nacked-by: Jiri Benc > > Don't ever use "collect_metadata"

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

On 1/22/2018 3:24 AM, Kees Cook wrote: As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work

[PATCH net] pppoe: take ->needed_headroom of lower device into account on xmit

In pppoe_sendmsg(), reserving dev->hard_header_len bytes of headroom was probably fine before the introduction of ->needed_headroom in commit f5184d267c1a ("net: Allow netdevices to specify needed head/tailroom"). But now, virtual devices typically advertise the size of their overhead in dev->need

Re: [PATCH iproute2] tc/lexer: let quotes actually start strings

On Mon, 22 Jan 2018 11:53:46 +0100 Wolfgang Bumiller wrote: > The lexer will go with the longest match, so previously > the starting double quotes of a string would be swallowed by > the [^ \t\r\n()]+ pattern leaving the user no way to > actually use strings with escape sequences. > Fix this by n

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

On 1/22/2018 7:47 AM, David Miller wrote: From: Leon Romanovsky Date: Mon, 22 Jan 2018 17:10:54 +0200 On Mon, Jan 22, 2018 at 03:24:15AM -0800, Kees Cook wrote: diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c index 8557a1cae041..5fbf635d17cb 100644 --- a/net/rds/ib_send.c +++ b/net/rds/ib_

[PATCH net-next v3 0/2] net/sched: remove spinlock from 'csum' action

Similarly to what has been done earlier with other actions [1][2], this series tries to improve the performance of 'csum' tc action, removing a spinlock in the data path. Patch 1 lets act_csum use per-CPU counters; patch 2 removes spin_{,un}lock_bh() calls from the act() method. test procedure (us

[PATCH net-next v3 2/2] net/sched: act_csum: don't use spinlock in the fast path

use RCU instead of spin_{,unlock}_bh() to protect concurrent read/write on act_csum configuration, to reduce the effects of contention in the data path when multiple readers are present. Signed-off-by: Davide Caratti --- include/net/tc_act/tc_csum.h | 16 ++-- net/sched/act_csum.c

[PATCH net-next v3 1/2] net/sched: act_csum: use per-core statistics

use per-CPU counters, like other TC actions do, instead of maintaining one set of stats across all cores. This allows updating act_csum stats without the need of protecting them using spin_{,un}lock_bh() invocations. Signed-off-by: Davide Caratti --- net/sched/act_csum.c | 10 -- 1 file

Re: [PATCH] net: Make synchronize_net() be expedited only when it's really need

On Mon, 2018-01-22 at 12:41 +0300, Kirill Tkhai wrote: > Commit be3fc413da9e "net: use synchronize_rcu_expedited()" introducing > synchronize_net() says: > > >When we hold RTNL mutex, we would like to spend some cpu cycles but not > >block too long other processes waiting for this mutex. >

[PATCH iproute2-next v2 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

Print only "external" if collect meta data attribute is given: rest of parameters are irrelevant. This is to follow gre6. For both JSON and non-JSON output use "external" for all tunnels including vxlan and geneve. Signed-off-by: Serhey Popovych --- ip/iplink_geneve.c |8 +--- ip/iplink

[PATCH iproute2-next v2 2/2] gre/gre6: Unify attribute addition to netlink buffer

There are couple of minor improvements: 1) Check erspan_ver == 2 in gre6. It still could be 1 if erspan_idx is 0. 2) Add tunnel encapsulation attributes only when collect metadata not in effect in gre. 3) Trivial: address checkpatch issues. Signed-off-by: Serhey Popovych --- i

[PATCH iproute2-next v2 0/2] ip/tunnel: Unify collect metadata handling

With this series I want to unify collect metadata handling in tunnels: 1) Use "external" name for JSON and non-JSON output. Do not *print* any options when tunnel in collect metadata mode: gre6 already do this, so just apply to others. 2) Do not *add* any attributes when confi

[PATCH iproute2-next 1/8] utils: Introduce get_addr_rta()

It is used to get address from netlink attribute to inet_prefix data structure. Use memcpy() with constant value to let complier optimize by replacing a call by inlining load/store instructions. Signed-off-by: Serhey Popovych --- include/utils.h |1 + lib/utils.c | 82

[PATCH iproute2-next 0/8] ip: Introduce and use get_addr_rta()

Now we enhance get_addr() to return additional information about address (e.g. if it unspecified or multicast) we want to have same functionality for attributes in netlink message. Introduce and use get_addr_rta() that parses given netlink attribute into @inet_prefix data structure in the same way

  1   2   3   >