Re: DPAA Ethernet traffice troubles with Linux kernel

2018-01-19 Thread Joakim Tjernlund
On Thu, 1970-01-01 at 00:00 +, Madalin-cristian Bucur wrote: > > > -Original Message- > > From: Joakim Tjernlund [mailto:joakim.tjernl...@infinera.com] > > Sent: Tuesday, January 16, 2018 7:58 PM > > To: and...@lunn.ch > > Subject: Re: DPAA Ethernet traffice troubles with Linux kernel

Re: [PATCH net] net: validate untrusted gso packets

2018-01-19 Thread Jason Wang
On 2018年01月19日 08:53, Willem de Bruijn wrote: And what you propose here is just a very small subset of the necessary checking, more comes at gso header checking. So even if we care performance, it only help for some specific case. It also fixed the bug that Eric sent a separate patch for, as t

[patch net-next 7/7] mlxsw: spectrum_acl: Add support for mirror action

2018-01-19 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for mirror action. Only one mirror action can be set per rule. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../mellanox/mlxsw/core_acl_flex_actions.c | 87 +- .../mellanox/mlxsw/core_acl_flex_actions.h

[patch net-next 2/7] mlxsw: core: Convert fwd_entry_ref list to be generic per-block resource list

2018-01-19 Thread Jiri Pirko
From: Jiri Pirko Since the resource list needs to be used also for other entries different to fwd_entry_ref, make the list generic. For that purpose, introduce a resource structure with couple of helpers that the code which need to store a per-block resource should use. Signed-off-by: Jiri Pirko

[patch net-next 0/7] mlxsw: Add support for mirror action with flower

2018-01-19 Thread Jiri Pirko
From: Jiri Pirko Arkadi says: Add support for mirror action with flower classifier. The first 3 patches introduce a generic per-block resource infra. The last 4 patches add support for flow based span. Arkadi Sharshevsky (4): mlxsw: spectrum_acl: Add support for mirroring action mlxsw: spec

[patch net-next 5/7] mlxsw: spectrum: Extend and export SPAN API

2018-01-19 Thread Jiri Pirko
From: Arkadi Sharshevsky Extend SPAN API for ACL case. In case of ACL triggering the MPAR register shouldn't be configured. This patch also export those helpers for ACL usage. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 79 +

[patch net-next 6/7] mlxsw: spectrum: Extend mlxsw_afa_ops for counter index and implement for Spectrum

2018-01-19 Thread Jiri Pirko
From: Arkadi Sharshevsky Introduce extension of mlxsw_afa_ops in order to add/del mirroring and implement the ops for Spectrum. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../mellanox/mlxsw/core_acl_flex_actions.h | 4 ++ .../mellanox/mlxsw/spectrum_acl_flex_acti

[patch net-next 4/7] mlxsw: spectrum_acl: Add support for mirroring action

2018-01-19 Thread Jiri Pirko
From: Arkadi Sharshevsky The patch extends the trap action for mirroring. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../mellanox/mlxsw/core_acl_flex_actions.c | 33 ++ .../mellanox/mlxsw/core_acl_flex_actions.h | 2 ++ 2 files changed

[patch net-next 1/7] mlxsw: spectrum: Extend mlxsw_afa_ops for counter index and implement for Spectrum

2018-01-19 Thread Jiri Pirko
From: Jiri Pirko Introduce extension of mlxsw_afa_ops in order to get/put counter indexes and implement the ops for Spectrum. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- .../ethernet/mellanox/mlxsw/core_acl_flex_actions.h| 2 ++ .../mellanox/mlxsw/spectrum_acl_flex_actions.c

Re: [PATCH v2 00/31] Replacing net_mutex with rw_semaphore

2018-01-19 Thread Kirill Tkhai
On 18.01.2018 20:43, Andrei Vagin wrote: > On Mon, Nov 20, 2017 at 09:32:08PM +0300, Kirill Tkhai wrote: >> Hi, >> >> there is the second version of patchset introducing net_sem >> instead of net_mutex. The patchset adds net_sem in addition >> to net_mutex and allows pernet_operations to be async.

[patch net-next 3/7] mlxsw: core: Make counter index allocated inside the action append

2018-01-19 Thread Jiri Pirko
From: Jiri Pirko So far, the caller of mlxsw_afa_block_append_counter needed to allocate counter index by hand. Benefit from the previously introduced resource infra and counter_index_get/put callbacks, and allocate the counter index in place where it is needed, inside the action append function.

Re: [PATCH] smc: return boolean instead of integer in using_ipsec

2018-01-19 Thread Ursula Braun
On 01/19/2018 12:33 AM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/smc/smc.h | 2 +- > 1 file changed, 1 insertio

pull-request: wireless-drivers-next 2018-01-19

2018-01-19 Thread Kalle Valo
Hi Dave, a pull request to net-next tree for 4.16. This should be the last pull request in this cycle, unless Linus releases -rc9 of course. Only few patches so should be an easy one. Please let me know if there are any problems. Kalle The following changes since commit 79d891c1bbb6573cef31dbc20

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/18 07:51, Alexander Duyck wrote: > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier wrote: > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > > overrun interrupt bursts", v4.15-rc1).

Re: [PATCH net-next v3] xfrm: Add ESN support for IPSec HW offload

2018-01-19 Thread Steffen Klassert
On Mon, Jan 15, 2018 at 10:06:06AM -0800, Shannon Nelson wrote: > On 1/14/2018 1:39 AM, yoss...@mellanox.com wrote: > > From: Yossef Efraim > > > > This patch adds ESN support to IPsec device offload. > > Adding new xfrm device operation to synchronize device ESN. > > > > Signed-off-by: Yossef E

***BULK*** MICROSOFT WARNING NOTIFICATION

2018-01-19 Thread GALLOY Anne
MICROSOFT WARNING NOTIFICATION Lots of your incoming messages are currently suspended because your E-mail box account needs to be verify now. Do verify now inother to receive your pending messages without no delay. ©2018 Microsoft Outlook Inc.

[PATCH net-next] cxgb3: assign port id to net_device->dev_port

2018-01-19 Thread Ganesh Goudar
From: Arjun Vynipadath T3 devices have different ports on same PCI function, so using dev_port to identify ports. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/et

pull-request: can-next 2018-01-16

2018-01-19 Thread Marc Kleine-Budde
/sch_prio.c: work around gcc-4.4.4 union initializer issues (2018-01-18 21:11:31 -0500) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.16-20180119 for you to fetch changes up to

Re: [PATCH net-next v2] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Giuseppe CAVALLARO
On 1/19/2018 12:12 AM, Florian Fainelli wrote: Broadcom tags inserted by Broadcom switches put a 4 byte header after the MAC SA and before the EtherType, which may look like some sort of 0 length LLC/SNAP packet (tcpdump and wireshark do think that way). With ACS enabled in stmmac the packets wer

Re: [PATCH net] xfrm: Add SA to hardware at the end of xfrm_state_construct()

2018-01-19 Thread Steffen Klassert
On Wed, Jan 17, 2018 at 03:52:41PM +0200, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > Current code configures the hardware with a new SA before the state has been > fully initialized. During this time interval, an incoming ESP packet can cause > a crash due to a NULL dereference. More

Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

2018-01-19 Thread Steffen Klassert
On Thu, Jan 18, 2018 at 03:41:51PM +0200, Aviad Yehezkel wrote: > If add state fails in case of device offload, netdev refcount > will be negative since gc task is attempting to dev_free this state. > This is fixed by putting NULL in state dev field. > > Signed-off-by: Aviad Yehezkel > Signed-off

[PATCH] net: igmp: fix source address check for IGMPv3 reports

2018-01-19 Thread Felix Fietkau
Commit "net: igmp: Use correct source address on IGMPv3 reports" introduced a check to validate the source address of locally generated IGMPv3 packets. Instead of checking the local interface address directly, it uses inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the local subn

***BULK*** MICROSOFT WARNING MESSAGE ALERT

2018-01-19 Thread GALLOY Anne
MICROSOFT WARNING MESSAGE ALERT Lots of your messages are currently suspended because your E-mail box account needs to be verify now. Do verify now inother to receive your pending messages without no delay. ©2018 Microsoft Outlook Inc.

Re: [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-19 Thread Daniel Axtens
Pravin Shelar writes: > On Thu, Jan 18, 2018 at 5:28 PM, Daniel Axtens wrote: >> Pravin Shelar writes: >> >>> On Thu, Jan 18, 2018 at 5:08 AM, Daniel Axtens wrote: Pravin Shelar writes: > On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: >> When regular packets are forw

Darlehensangebot

2018-01-19 Thread 49986813
Schönen Tag, Sie benötigen einen echten Kredit online Ihre Rechnungen zu sichern? Startet ein neues Unternehmen? Sie benötigen einen persönlichen Kredit oder Business-Darlehen? Wir bieten ein Darlehen von € 10.000 bis € 500,000.000.00 mit 2% Zinsen pro Jahr und auch mit einem erschwinglichen Rückz

Re: [PATCH net v2] gso: validate gso_type if SKB_GSO_DODGY

2018-01-19 Thread Jason Wang
On 2018年01月19日 08:19, Willem de Bruijn wrote: From: Willem de Bruijn Validate gso_type during segmentation as SKB_GSO_DODGY sources may pass packets where the gso_type does not match the contents. Syzkaller was able to enter the SCTP gso handler with a packet of gso_type SKB_GSO_TCPV4. On en

Re: [PATCH net] net: qdisc_pkt_len_init() should be more robust

2018-01-19 Thread Jason Wang
On 2018年01月19日 11:59, Eric Dumazet wrote: From: Eric Dumazet Without proper validation of DODGY packets, we might very well feed qdisc_pkt_len_init() with invalid GSO packets. tcp_hdrlen() might access out-of-bound data, so let's use skb_header_pointer() and proper checks. Whole story is de

Re: [PATCH v6 03/36] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h

2018-01-19 Thread Greentime Hu
2018-01-18 17:56 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> It will be built failed if commit id: d25ea659 is selected. This patch >> can fix this build error. >> >> Signed-off-by: Greentime Hu > > The change is fine, but the refe

Re: [PATCH] netfilter: return booleans instead of integers

2018-01-19 Thread Pablo Neira Ayuso
On Thu, Jan 18, 2018 at 05:25:12PM -0600, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > These issues were detected with the help of Coccinelle. Applied, thanks.

Re: [PATCH] netfilter: nf_tables: Fix trailing semicolon

2018-01-19 Thread Pablo Neira Ayuso
On Tue, Jan 16, 2018 at 02:51:01PM +, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. Applied.

Re: KASAN: use-after-free Read in fib6_ifup (2)

2018-01-19 Thread Ido Schimmel
On Thu, Jan 18, 2018 at 09:58:01PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 564737f981fb4b4b3266901508bb9b90d9d43de8 > > So far this crash happened 18 times on mmots, net-next. > C reproducer is attached. > syzkaller reproducer is attached. > Raw conso

Re: DPAA Ethernet traffice troubles with Linux kernel

2018-01-19 Thread Andrew Lunn
> > commit 4d8ee1935bcd666360311dfdadeee235d682d69a > > Author: Florian Fainelli > > Date: Tue Aug 22 15:24:47 2017 -0700 > > fsl/man: Inherit parent device and of_node > > > > and was later addressed by this patch set: > > > > http://patchwork.ozlabs.org/project/netdev/list/?series=8462&state=*

[PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Florian Westphal
Mike Christie reports: Starting in 4.14 iscsi logins will fail around 50% of the time. Problem appears to be that iscsi_target_sk_data_ready() callback may return without doing anything in case it finds the login work queue is still blocked in sock_recvmsg(). Nicholas Bellinger says: It would

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/19 17:59, Benjamin Poirier wrote: > On 2018/01/18 07:51, Alexander Duyck wrote: > > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier > > wrote: > > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e:

Re: DPAA Ethernet traffice troubles with Linux kernel

2018-01-19 Thread Joakim Tjernlund
On Thu, 1970-01-01 at 00:00 +, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > > commit 4d8ee1935bcd666360311dfdadeee235d682d69a > > > Autho

[PATCH net-next v2 0/2] net/sched: remove spinlock from 'csum' action

2018-01-19 Thread Davide Caratti
Similarly to what has been done earlier with other actions [1][2], this series tries to improve the performance of 'csum' tc action, removing a spinlock in the data path. Patch 1 lets act_csum use per-CPU counters; patch 2 removes spin_{,un}lock_bh() calls from the act() method. test procedure (us

[PATCH net-next v2 2/2] net/sched: act_csum: don't use spinlock in the fast path

2018-01-19 Thread Davide Caratti
use RCU instead of spin_{,unlock}_bh() to protect concurrent read/write on act_csum configuration, to reduce the effects of contention in the data path when multiple readers are present. Signed-off-by: Davide Caratti --- include/net/tc_act/tc_csum.h | 16 ++-- net/sched/act_csum.c

[PATCH net-next v2 1/2] net/sched: act_csum: use per-core statistics

2018-01-19 Thread Davide Caratti
use per-CPU counters, like other TC actions do, instead of maintaining one set of stats across all cores. This allows updating act_csum stats without the need of protecting them using spin_{,un}lock_bh() invocations. Signed-off-by: Davide Caratti --- net/sched/act_csum.c | 10 -- 1 file

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Roman Gushchin
On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: > 2018-01-15 19:16 UTC+ ~ Roman Gushchin > > Bpftool doesn't recognize BPF_PROG_TYPE_CGROUP_DEVICE programs, > > so the prog show command prints the numeric type value: > > > > $ bpftool prog show > > 1: type 15 name bpf_prog1 t

[PATCH net-next 00/11] Aquantia atlantic driver new devices support

2018-01-19 Thread Igor Russkikh
This patchset introduces a support for new Aquantia hardware: AQC11x family with updated hardware (B1) and firmware (2.x and 3.x branches). For that, a number of improvements in overall driver model were done: - Firmware specific ops tables. Firmware 2.x and 3.x series support functions are no

[PATCH net-next 04/11] net: aquantia: Cleanup pci functions module

2018-01-19 Thread Igor Russkikh
Driver contained a dead code of maintaining multiple pci port instances. That will never be used since for each pci function a separate NIC instance is created. Simplify this, making pci module only responsible for pci resource management. NIC initialization is also simplified accordingly. Signed-

[PATCH net-next 05/11] net: aquantia: Remove create/destroy from hw ops

2018-01-19 Thread Igor Russkikh
These ops are not related to HW and are now implemented in pci module. Thus, remove these ops pointers and implementation. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 5 - .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 25 -

[PATCH net-next 03/11] net: aquantia: Convert hw and caps structures to const static pointers

2018-01-19 Thread Igor Russkikh
This removes unnecessary structure copying, and prepares the driver for separate firmware ops table introduction. We also remove extra copy of capabilities structure (which is const actually) and also replace it with a const pointer in aq_nic_cfg. Signed-off-by: Igor Russkikh --- drivers/net/et

[PATCH net-next 02/11] net: aquantia: Introduce new AQC devices and capabilities

2018-01-19 Thread Igor Russkikh
A number of new AQC devices is going to be released. To support more flexible capabilities management a number of static caps instances is now declared. Devices now are mainly differs by supported speeds, but in future more parameters will be customized. A set of AQC100 devices have fibre media, no

[PATCH net-next 01/11] net: aquantia: Introduce new device ids and constants

2018-01-19 Thread Igor Russkikh
New set of aquantia devices has an upgraded hardware (B1). The hardware interface is identical to B0. The difference will be in firmware which is incompatible with old one. Reorganized and removed duplicate speed and devid definitions Introduced explicit flow control configuration defines Signed-

[PATCH net-next 06/11] net: aquantia: Change confusing no_ff_addr to more meaningful name

2018-01-19 Thread Igor Russkikh
The address to check if HW is not dead/hang could be stored in capabilities, since it is a constant. Change its name to better reflect the idea. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_hw.h| 2 +- drivers/net/ethernet/aquantia/atlantic/aq_hw_utils.c

[PATCH net-next 09/11] net: aquantia: Introduce global AQC hardware reset sequence

2018-01-19 Thread Igor Russkikh
The detailed reset sequence ensures all HW components are in aligned state before NIC startup. It also supports cards with signed firmware (RBL) and checks if their FW is valid. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 1 + .../ethernet/aquantia/atl

[PATCH net-next 08/11] net: aquantia: Introduce support for new firmware on AQC cards

2018-01-19 Thread Igor Russkikh
This defines fw2x operations table and corresponding methods. Some of the functions are being shared with 1.x firmware Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/Makefile| 1 + drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 1 - .../aquantia/atlantic/hw

[PATCH net-next 10/11] net: aquantia: Report correct mediatype via ethtool

2018-01-19 Thread Igor Russkikh
For devices with known capabilities of Fibre media type we now report that to ethtool. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_

[PATCH net-next 11/11] net: aquantia: bump driver version to match aquantia internal numbering

2018-01-19 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index 9009f26..5265b93 100644 --- a/drivers/net/ethe

[PATCH net-next 07/11] net: aquantia: Introduce firmware ops callbacks

2018-01-19 Thread Igor Russkikh
New AQC cards will have an updated firmware with new binary interface. This patch extracts firmware specific operations into a separate table and prepares for the introduction of new fw 2.x and 3.x Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 27 ---

Re: [PATCH net v2] gso: validate gso_type if SKB_GSO_DODGY

2018-01-19 Thread Willem de Bruijn
On Fri, Jan 19, 2018 at 7:36 AM, Jason Wang wrote: > > > On 2018年01月19日 08:19, Willem de Bruijn wrote: >> >> From: Willem de Bruijn >> >> Validate gso_type during segmentation as SKB_GSO_DODGY sources >> may pass packets where the gso_type does not match the contents. >> >> Syzkaller was able to e

Re: [PATCH v6 24/36] nds32: Loadable modules

2018-01-19 Thread Greentime Hu
2018-01-18 18:41 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds support for loadable modules. > > One detail: > > You still seem to have both the ELF_REL and ELF_RELA based functions > implemented here, you should drop

Re: [PATCH net v2] gso: validate gso_type if SKB_GSO_DODGY

2018-01-19 Thread Willem de Bruijn
On Fri, Jan 19, 2018 at 9:25 AM, Willem de Bruijn wrote: > On Fri, Jan 19, 2018 at 7:36 AM, Jason Wang wrote: >> >> >> On 2018年01月19日 08:19, Willem de Bruijn wrote: >>> >>> From: Willem de Bruijn >>> >>> Validate gso_type during segmentation as SKB_GSO_DODGY sources >>> may pass packets where the

[PATCH net v3] gso: validate gso_type in GSO handlers

2018-01-19 Thread Willem de Bruijn
From: Willem de Bruijn Validate gso_type during segmentation as SKB_GSO_DODGY sources may pass packets where the gso_type does not match the contents. Syzkaller was able to enter the SCTP gso handler with a packet of gso_type SKB_GSO_TCPV4. On entry of transport layer gso handlers, verify that

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Greentime Hu
2018-01-18 19:02 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds nds32 CPU binding documents. >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Rick Chen >> Signed-off-by: Zong Li >> Signed-off-by: Greentime Hu >>

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Quentin Monnet
2018-01-19 14:17 UTC+ ~ Roman Gushchin > On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: [...] >> Looks good, thanks Roman! >> Would you mind updating the map names as well? It seems the >> BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > > He

Re: [PATCH net] net: validate untrusted gso packets

2018-01-19 Thread Willem de Bruijn
On Fri, Jan 19, 2018 at 3:19 AM, Jason Wang wrote: > > > On 2018年01月19日 08:53, Willem de Bruijn wrote: > > And what you propose here is just a very small subset of the > necessary checking, more comes at gso header checking. So even if we > care > performance, it only help for

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Arnd Bergmann
On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: > 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> This patch adds nds32 CPU binding documents. >>> >>> Signed-off-by: Vincent Chen >>> Signed-off-by: Rick Chen

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Greentime Hu
2018-01-19 22:52 GMT+08:00 Arnd Bergmann : > On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: >> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : >>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: From: Greentime Hu This patch adds nds32 CPU binding documents. Signed

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

2018-01-19 Thread jianchao.wang
Hi Tariq Very sad that the crash was reproduced again after applied the patch. --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c @@ -252,6 +252,7 @@ static inline bool mlx4_en_is_ring_empty(struct mlx4_en_rx_ring *ring) static inline void mlx4_e

[PATCH net-next] net: hns3: converting spaces into tabs to avoid checkpatch.pl warning

2018-01-19 Thread Salil Mehta
Spaces were mistakenly used instead of tabs in some of the code related to reset functionality, which caused checkpatch.pl errors. These were missed earlier so fixing them now. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ++-- 1 file changed, 2 insertions(+

Re: pull-request: wireless-drivers-next 2018-01-19

2018-01-19 Thread David Miller
From: Kalle Valo Date: Fri, 19 Jan 2018 10:59:33 +0200 > a pull request to net-next tree for 4.16. This should be the last pull > request in this cycle, unless Linus releases -rc9 of course. Only few > patches so should be an easy one. Please let me know if there are any > problems. Pulled, than

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Geert Uytterhoeven
Hi Greentime, On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: > 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : >> On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: >>> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime

Re: pull-request: can-next 2018-01-16,pull-request: can-next 2018-01-16

2018-01-19 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 19 Jan 2018 10:48:11 +0100 > this is a pull request for net-next/master consisting of 1 patch. > > This patch by Arnd Bergmann for the m_can driver silences a compiler > warning if CONFIG_PM is not selected. Pulled, thanks Marc.

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Greentime Hu
2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : > Hi Greentime, > > On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >> 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : >>> On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: 2018-01-18 19:02 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 201

Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

2018-01-19 Thread Geert Uytterhoeven
Hi Greentime, On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: > 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: >>> 2018-01-19 22:52 GMT+08:00 Arnd Bergmann : On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu wrote: > 2018-01-18

Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Eric Dumazet
On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > Mike Christie reports: > Starting in 4.14 iscsi logins will fail around 50% of the time. > > Problem appears to be that iscsi_target_sk_data_ready() callback may > return without doing anything in case it finds the login work queue > i

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

2018-01-19 Thread Eric Dumazet
On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: > Hi Tariq > > Very sad that the crash was reproduced again after applied the patch. > > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > @@ -252,6 +252,7 @@ static inline bool mlx4_en_is_

[PATCH net-next] net: Move net:netns_ids destruction out of rtnl_lock() and document locking scheme

2018-01-19 Thread Kirill Tkhai
Currently, we unhash a dying net from netns_ids lists under rtnl_lock(). It's a leftover from the time when net::netns_ids was introduced. There was no net::nsid_lock, and rtnl_lock() was mostly need to order modification of alive nets nsid idr, i.e. for: for_each_net(tmp) {

[bpf-next PATCH] samples/bpf: xdp_monitor include cpumap tracepoints in monitoring

2018-01-19 Thread Jesper Dangaard Brouer
The xdp_redirect_cpu sample have some "builtin" monitoring of the tracepoints for xdp_cpumap_*, but it is practical to have an external tool that can monitor these transpoint as an easy way to troubleshoot an application using XDP + cpumap. Specifically I need such external tool when working on Su

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Alexander Duyck
On Fri, Jan 19, 2018 at 5:36 AM, Benjamin Poirier wrote: > On 2018/01/19 17:59, Benjamin Poirier wrote: >> On 2018/01/18 07:51, Alexander Duyck wrote: >> > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier >> > wrote: >> > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build

Re: [PATCH v6 06/36] nds32: Kernel booting and initialization

2018-01-19 Thread Greentime Hu
Hi, Arnd: 2018-01-18 18:11 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > > I had not looked at this patch in enough detail earlier, sorry about > that. It should be > easy enough to fix though. > >> +#ifdef CONFIG_VGA_CONSOLE >> +struct screen_info screen_info

Re: [PATCH v6 06/36] nds32: Kernel booting and initialization

2018-01-19 Thread Arnd Bergmann
On Fri, Jan 19, 2018 at 5:34 PM, Greentime Hu wrote: > Hi, Arnd: > > 2018-01-18 18:11 GMT+08:00 Arnd Bergmann : >> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> >> I had not looked at this patch in enough detail earlier, sorry about >> that. It should be >> easy enough to fix though. >>

[PATCH iproute2 2/4] iptnl/ip6tnl: Unify ttl/hoplimit parsing routines

2018-01-19 Thread Serhey Popovych
Handle "inherit" case properly for gre6 and ip6tnl. Use get_u8() in gre to parse ttl/hoplimit. Be consistent about "hlim" alias to ttl/hoplimit support. Signed-off-by: Serhey Popovych --- ip/link_gre.c| 10 +++--- ip/link_gre6.c | 13 +++-- ip/link_ip6tnl.c | 14 +++

[PATCH iproute2 4/4] iplink: Use ll_name_to_index() instead of if_nametoindex()

2018-01-19 Thread Serhey Popovych
While benefit from using ll_name_to_index() with populated cache can potentially be exploited only in few places (e.g. bridge fdb/mdb/vlan show routines) there is another advantage of ll_name_to_index() over plain if_nametoindex(): in case of if_nametoindex() failure ll_name_to_index() will at

[PATCH iproute2 0/4] ip/tunnel: Minor cleanups and improvements

2018-01-19 Thread Serhey Popovych
It is small series of fixes and code cleanups: 1) Add space after encap-[ds]port parameter value in tunnel encapsulation options output. 2) Unify ttl/hoplimit parsing routines by using get_u8(), handling "inherit" and "hlim" as alias to "hoplimit" and "ttl" parameter name. 3

[PATCH iproute2 3/4] vti/vti6: Minor improvements

2018-01-19 Thread Serhey Popovych
In prepare of link_vti.c and link_vti6.c merge: 1) Make @fwmark of __u32 type instead of unsigned int in vti to match with rest tunneling code. 2) Report when unable to translate @link network device name to index instead of silently exiting in vti6. 3) Remove newline separating

[PATCH iproute2 1/4] tunnel: Add space between encap-dport and encap-sport in non-JSON output

2018-01-19 Thread Serhey Popovych
Fixes: bad76e6b1f44 ("ip/tunnel: Abstract tunnel encapsulation options printing") Fixes: e2d4588331fc ("ip: link_gre.c: add json output support") Signed-off-by: Serhey Popovych --- ip/tunnel.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ip/tunnel.c b/ip/tunnel.c in

Re: net: r8169: a question of memory barrier in the r8169 driver

2018-01-19 Thread Peter Zijlstra
On Fri, Jan 19, 2018 at 02:11:18AM +0100, Francois Romieu wrote: > Peter Zijlstra : > [...] > > There is only 1 variable afaict. Memory barriers need at least 2 in > > order to be able to do _anything_. > > I don't get your point: why don't {cur_tx, dirty_tx} qualify as said > two variables ? Th

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-19 Thread Guillaume Nault
On Tue, Jan 16, 2018 at 04:21:40PM +0800, Xin Long wrote: > ipv4 tunnels don't really set dev->hard_header_len properly, > we may should fix it in pppoe by using needed_headroom, > as what it doesn't in arp_create. > I'm a bit in doubt about which device needs to be fixed. Should ip_gre set ->har

Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Florian Westphal
Eric Dumazet wrote: > On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c > > b/drivers/target/iscsi/iscsi_target_nego.c > > index b686e2ce9c0e..3723f8f419aa 100644 > > --- a/drivers/target/iscsi/iscsi_target_nego.c > > +++ b/driver

Re: kernel BUG at net/core/skbuff.c:LINE! (2)

2018-01-19 Thread Xin Long
On Sat, Jan 20, 2018 at 1:19 AM, Guillaume Nault wrote: > On Tue, Jan 16, 2018 at 04:21:40PM +0800, Xin Long wrote: >> ipv4 tunnels don't really set dev->hard_header_len properly, >> we may should fix it in pppoe by using needed_headroom, >> as what it doesn't in arp_create. >> > I'm a bit in dou

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-19 Thread Marcin Wojtas
Hi Mika, 2018-01-18 14:00 GMT+01:00 Andrew Lunn : >> I CC'ed Mika since he is more familiar with handling these bits of ACPI >> specs - I wonder whether this is a problem that cropped up on x86 >> systems too. > > Hi Lorenzo > > There is nothing about MDIO, PHYs, Ethernet switches, etc in version

Fw: [Bug 198521] New: VRF: VRF device does not egress all broadcast(255.255.255.255) destined packet

2018-01-19 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 19 Jan 2018 12:59:23 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198521] New: VRF: VRF device does not egress all broadcast(255.255.255.255) destined packet https://bugzilla.kernel.org/show_bug.cgi?id=198521

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-19 Thread Andrew Lunn
> Since I have a code that can be tested and easily modified to use > different ACPI approaches with real platform MDIO controller > (mvmdio.c) and NIC (mvpp2.c), in coming weeks I may be able to find > some time to prepare a proof of concept based on GenericSerialBus. > Please expect some RFC patc

Re: [PATCH] caif: reduce stack size with KASAN

2018-01-19 Thread David Miller
From: Arnd Bergmann Date: Tue, 16 Jan 2018 17:34:00 +0100 > When CONFIG_KASAN is set, we can use relatively large amounts of kernel > stack space: > > net/caif/cfctrl.c:555:1: warning: the frame size of 1600 bytes is larger than > 1280 bytes [-Wframe-larger-than=] > > This adds convenience wra

[PATCH 00/32] Netfilter/IPVS updates for net-next

2018-01-19 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS updates for your net-next tree. Basically, a new extension for ip6tables, simplification work of nf_tables that saves us 500 LoC, allow raw table registration before defragmentation, conversion of the SNMP helper to use the ASN.1 code genera

[PATCH 02/32] netfilter: nf_tables: remove flag field from struct nft_af_info

2018-01-19 Thread Pablo Neira Ayuso
Replace it by a direct check for the netdev protocol family. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 6 -- net/netfilter/nf_tables_api.c | 2 +- net/netfilter/nf_tables_netdev.c | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/include

[PATCH 04/32] netfilter: nf_tables: remove struct nft_af_info parameter in nf_tables_chain_type_lookup()

2018-01-19 Thread Pablo Neira Ayuso
Pass family number instead, this comes in preparation for the removal of struct nft_af_info. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_ta

[PATCH 03/32] netfilter: nf_tables: no need for struct nft_af_info to enable/disable table

2018-01-19 Thread Pablo Neira Ayuso
nf_tables_table_enable() and nf_tables_table_disable() take a pointer to struct nft_af_info that is never used, remove it. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/net/netfilter/n

[PATCH 08/32] netfilter: x_tables: unbreak module auto loading

2018-01-19 Thread Pablo Neira Ayuso
From: Florian Westphal a typo causes module auto load support to never be compiled in. Fixes: 03d13b6868a2 ("netfilter: xtables: add and use xt_request_find_table_lock") Reported-by: Pablo Neira Ayuso Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/x_table

[PATCH 06/32] netfilter: nf_tables: get rid of pernet families

2018-01-19 Thread Pablo Neira Ayuso
Now that we have a single table list for each netns, we can get rid of one pointer per family and the global afinfo list, thus, shrinking struct netns for nftables that now becomes 64 bytes smaller. And call __nft_release_afinfo() from __net_exit path accordingly to release netnamespace objects on

[PATCH 09/32] netfilter: nf_tables: fix a typo in nf_tables_getflowtable()

2018-01-19 Thread Pablo Neira Ayuso
From: Wei Yongjun Fix a typo, we should check 'flowtable' instead of 'table'. Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend") Signed-off-by: Wei Yongjun Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH 05/32] netfilter: nf_tables: add single table list for all families

2018-01-19 Thread Pablo Neira Ayuso
Place all existing user defined tables in struct net *, instead of having one list per family. This saves us from one level of indentation in netlink dump functions. Place pointer to struct nft_af_info in struct nft_table temporarily, as we still need this to put back reference module reference co

[PATCH 22/32] netfilter: nf_nat_snmp_basic: remove useless comment

2018-01-19 Thread Pablo Neira Ayuso
From: Taehee Yoo Remove comments that do not let us know important information. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_nat_snmp_basic.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/net/ipv4/netfilter/nf_nat_sn

[PATCH 01/32] netfilter: nf_tables: remove nhooks field from struct nft_af_info

2018-01-19 Thread Pablo Neira Ayuso
We already validate the hook through bitmask, so this check is superfluous. When removing this, this patch is also fixing a bug in the new flowtable codebase, since ctx->afi points to the table family instead of the netdev family which is where the flowtable is really hooked in. Signed-off-by: Pab

[PATCH 21/32] netfilter: nf_defrag: move NF_CONNTRACK bits into #ifdef

2018-01-19 Thread Pablo Neira Ayuso
From: Arnd Bergmann We cannot access the skb->_nfct field when CONFIG_NF_CONNTRACK is disabled: net/ipv4/netfilter/nf_defrag_ipv4.c: In function 'ipv4_conntrack_defrag': net/ipv4/netfilter/nf_defrag_ipv4.c:83:9: error: 'struct sk_buff' has no member named '_nfct' net/ipv6/netfilter/nf_defrag_ip

[PATCH 24/32] netfilter: nf_nat_snmp_basic: replace ctinfo with dir.

2018-01-19 Thread Pablo Neira Ayuso
From: Taehee Yoo The snmp_translate() receives ctinfo data to get dir value only. because of caller already has dir value, we just replace ctinfo with dir. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_nat_snmp_basic.c | 7 ++- 1 file changed, 2 inse

[PATCH 19/32] netfilter: ipv6: nf_defrag: Pass on packets to stack per RFC2460

2018-01-19 Thread Pablo Neira Ayuso
From: Subash Abhinov Kasiviswanathan ipv6_defrag pulls network headers before fragment header. In case of an error, the netfilter layer is currently dropping these packets. This results in failure of some IPv6 standards tests which passed on older kernels due to the netfilter framework using clon

  1   2   3   >