[PATCH] netfilter: nf_tables: Release memory obtained by kasprintf

2017-09-20 Thread Arvind Yadav
Free memory region, if nf_tables_set_alloc_name is not successful. Signed-off-by: Arvind Yadav --- net/netfilter/nf_tables_api.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 9299271..393e37e 100644 ---

[net-next] macvlan: code refine to check data before using

2017-09-20 Thread Zhang Shengju
This patch checks data first at one place, return if it's null. Signed-off-by: Zhang Shengju --- drivers/net/macvlan.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index d2aea96..1ffe77e 100644 --- a/drivers/net/m

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Hi Will try bisecting tonight W dniu 2017-09-20 o 05:24, Eric Dumazet pisze: On Wed, 2017-09-20 at 02:06 +0200, Paweł Staszewski wrote: Just checked kernel 4.13.2 and same problem Just after start all 6 bgp sessions - and kernel starts to learn routes it panic. https://bugzilla.kernel.org

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

2017-09-20 Thread Oliver Neukum
Am Dienstag, den 19.09.2017, 13:51 -0700 schrieb Guenter Roeck: > On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > > > > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: > > > [..] > > > NOTES: > > > - No known bugs are fixed by this; it's just found by code inspection.

Re: [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

2017-09-20 Thread Oliver Neukum
Am Dienstag, den 19.09.2017, 13:53 -0700 schrieb Doug Anderson: > Hi, > > On Tue, Sep 19, 2017 at 1:37 PM, Oliver Neukum wrote: > > > > Am Dienstag, den 19.09.2017, 09:15 -0700 schrieb Douglas Anderson: > > > > > > In general when you've got a flag communicating that "something needs > > > to b

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Trying to make video from ipmi :) with that results: https://bugzilla.kernel.org/attachment.cgi?id=258521 catched two more lines where it starts - panic from 4.13.2. Now will try tro do some bisection W dniu 2017-09-20 o 09:58, Paweł Staszewski pisze: Hi Will try bisecting tonight W

Re: [lkp-robot] [test_rhashtable] c1bd3689a7: WARNING:at_lib/debugobjects.c:#__debug_object_init

2017-09-20 Thread Florian Westphal
kernel test robot wrote: > FYI, we noticed the following commit: > > commit: c1bd3689a70d1ba1a2f7c6781770920087166018 ("test_rhashtable: add test > case for rhl_table interface") > url: > https://github.com/0day-ci/linux/commits/Florian-Westphal/test_rhashtable-add-test-case-for-rhl-table/20170

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Ok looks like ending bisection Latest bisected kernel when there is no kernel panic 4.12.0+ (from next)  - but only this warning: [  309.030019] NETDEV WATCHDOG: enp4s0f0 (ixgbe): transmit queue 0 timed out [  309.030034] [ cut here ] [  309.030040] WARNING: CPU: 35 PI

[PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Ville Syrjala
From: Ville Syrjälä I got the following lockdep warning about the rcu_dereference()s in ieee80211_tx_h_select_key(). After tracing all callers of ieee80211_tx_h_select_key() I discovered that ieee80211_get_buffered_bc() and ieee80211_build_data_template() had the rcu_read_lock/unlock() but three

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Ok kernel crashed with different panic that i didnt catch when i was doing bisect and now my bisection is broken :) git bisect good Bisecting: 1787 revisions left to test after this (roughly 11 steps) error: Your local changes to the following files would be overwritten by checkout:     Do

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Soo far bisected and marked: git bisect start # bad: [07dd6cc1fff160143e82cf5df78c1db0b6e03355] Linux 4.13.2 git bisect bad 07dd6cc1fff160143e82cf5df78c1db0b6e03355 # good: [5d7d2e03e0f01a992e3521b180c3d3e67905f269] Linux 4.12.13 git bisect good 5d7d2e03e0f01a992e3521b180c3d3e67905f269 # good: [6

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-20 Thread Sergei Shtylyov
Hello! On 9/20/2017 1:43 AM, Vito Caputo wrote: NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate. --- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/Kconfig b/dri

Re: [PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Johannes Berg
On Wed, 2017-09-20 at 13:11 +0300, Ville Syrjala wrote: > --- a/net/mac80211/tx.c > +++ b/net/mac80211/tx.c > @@ -1770,15 +1770,21 @@ bool ieee80211_tx_prepare_skb(struct ieee80211_hw *hw, >   struct ieee80211_tx_data tx; >   struct sk_buff *skb2; >   > - if (ieee80211_tx_prepare(sdata

[PATCH 2/2] netfilter: ipset: ipset list may return wrong member count for set with timeout

2017-09-20 Thread Pablo Neira Ayuso
From: Vishwanath Pai Simple testcase: $ ipset create test hash:ip timeout 5 $ ipset add test 1.2.3.4 $ ipset add test 1.2.2.2 $ sleep 5 $ ipset l Name: test Type: hash:ip Revision: 5 Header: family inet hashsize 1024 maxelem 65536 timeout 5 Size in memory: 296 References: 0 Number of entries: 2

[PATCH 0/2] Netfilter fixes for net

2017-09-20 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two Netfilter fixes for your net tree, they are: 1) Fix NAt compilation with UP, from Geert Uytterhoeven. 2) Fix incorrect number of entries when dumping a set, from Vishwanath Pai. You can pull these changes from: git://git.kernel.org/pub/scm/lin

[PATCH 1/2] netfilter: nat: Do not use ARRAY_SIZE() on spinlocks to fix zero div

2017-09-20 Thread Pablo Neira Ayuso
From: Geert Uytterhoeven If no spinlock debugging options (CONFIG_GENERIC_LOCKBREAK, CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_LOCK_ALLOC) are enabled on a UP platform (e.g. m68k defconfig), arch_spinlock_t is an empty struct, hence using ARRAY_SIZE(nf_nat_locks) causes a division by zero: net/net

[PATCH net 4/9] net: hns3: Fix for not setting rx private buffer size to zero

2017-09-20 Thread Yunsheng Lin
When rx private buffer is disabled, there may be some case that the rx private buffer is not set to zero, which may cause buffer allocation process to fail. This patch fixes this problem by setting priv->enable to 0 and priv->buf_size to zero when rx private buffer is disabled. Fixes: 46a3df9f9718

[PATCH net 9/9] net: hns3: Fix for pri to tc mapping in TM

2017-09-20 Thread Yunsheng Lin
Current mapping between pri and tc is one to one, so user can't map multi priorities to the same tc. This patch changes the mapping to many to one. Fixes: 848440544b41f ("net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver") Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisili

[PATCH net 6/9] net: hns3: Fix for rx priv buf allocation when DCB is not supported

2017-09-20 Thread Yunsheng Lin
When hdev doesn't support DCB, rx private buffer is not allocated, otherwise there is not enough buffer for rx shared buffer, causing buffer allocation process to fail. This patch fixes by checking the dcb capability in hclge_rx_buffer_calc. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration E

[PATCH net 5/9] net: hns3: Fix for rx_priv_buf_alloc not setting rx shared buffer

2017-09-20 Thread Yunsheng Lin
rx_priv_buf_alloc is used to tell hardware how much buffer is used for rx direction, right now only the private buffer is assigned. For ae_dev that doesn't support DCB, private rx buffer is assigned to zero, only shared rx buffer is used. So not setting the shared rx buffer cause dropping of packet

[PATCH net 8/9] net: hns3: Fix for setting rss_size incorrectly

2017-09-20 Thread Yunsheng Lin
rss_size is 1, 2, 4, 8, 16, 32, 64, 128, but acutal tc queue size can be any u16 less than 128. If tc queue size is 5, we set the rss_size to 8, indirection table will be used to limit the size of actual queue size. It may cause dropping of receiving packet in hardware if rss_size is not set correc

[PATCH net 3/9] net: hns3: Fix for DEFAULT_DV when dev doesn't support DCB

2017-09-20 Thread Yunsheng Lin
When ae_dev doesn't support DCB, DEFAULT_DV must be set to a lower value, otherwise the buffer allocation process will fail. This patch fix it by setting it to 30K bytes. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Yunsheng Lin ---

[PATCH net 7/9] net: hns3: Fix typo error for feild in hclge_tm

2017-09-20 Thread Yunsheng Lin
This patch fixes a typo error for feild, which should be field. Fixes: 848440544b41f ("net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver") Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c| 20 ++-- .../net/ethernet/hisilicon/hns3

[PATCH net 0/9] TM related bugfixes for the HNS3 Ethernet Driver

2017-09-20 Thread Yunsheng Lin
This patch set contains a few bugfixes related to hclge_tm module. Yunsheng Lin (9): net: hns3: Cleanup for ROCE capability flag in ae_dev net: hns3: Fix initialization when cmd is not supported net: hns3: Fix for DEFAULT_DV when dev doesn't support DCB net: hns3: Fix for not setting rx pr

[PATCH net 2/9] net: hns3: Fix initialization when cmd is not supported

2017-09-20 Thread Yunsheng Lin
When ae_dev doesn't support DCB, rx_priv_wl_config, common_thrd_config and tm_qs_bp_cfg can't be called, otherwise cmd return fail, which causes the hclge module initialization process to fail. This patch fix it by adding a DCB capability flag to check if the ae_dev support DCB. Fixes: 46a3df9f971

[PATCH net 1/9] net: hns3: Cleanup for ROCE capability flag in ae_dev

2017-09-20 Thread Yunsheng Lin
This patch add the ROCE supported flag in the driver_data field of pci_device_id, delete roce_pci_tbl and change HNAE_DEV_SUPPORT_ROCE_B to HNAE3_DEV_SUPPORT_ROCE_B. This cleanup is done in order to support adding capability in pci_device_id and to fix initialization failure when cmd is not support

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Ok resumed and soo far: Panic: # bad: [9cc9a5cb176ccb4f2cda5ac34da5a659926f125f] datapath: Avoid using stack larger than 1024. git bisect bad 9cc9a5cb176ccb4f2cda5ac34da5a659926f125f No panic: # good: [073cf9e20c333ab29744717a23f9e43ec7512a20] Merge branch 'udp-reduce-cache-pressure' git b

[PATCH net-next 08/10] net/smc: introduce a delay

2017-09-20 Thread Ursula Braun
The number of outstanding work requests is limited. If all work requests are in use, tx processing is postponed to another scheduling of the tx worker. Switch to a delayed worker to have a gap for tx completion queue events before the next retry. Signed-off-by: Ursula Braun --- net/smc/smc.h

[PATCH net-next 10/10] net/smc: no close wait in case of process shut down

2017-09-20 Thread Ursula Braun
Usually socket closing is delayed if there is still data available in the send buffer to be transmitted. If a process is killed, the delay should be avoided. Signed-off-by: Ursula Braun --- net/smc/smc_close.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ne

[PATCH net-next 07/10] net/smc: terminate link group if out-of-sync is received

2017-09-20 Thread Ursula Braun
An out-of-sync condition can just be detected by the client. If the server receives a CLC DECLINE message indicating an out-of-sync condition for the link groups, the server must clean up the out-of-sync link group. There is no need for an extra third parameter in smc_clc_send_decline(). Signed-of

[PATCH net-next 04/10] net/smc: adjust net_device refcount

2017-09-20 Thread Ursula Braun
smc_pnet_fill_entry() uses dev_get_by_name() adding a refcount to ndev. The following smc_pnet_enter() has to reduce the refcount if the entry to be added exists already in the pnet table. Signed-off-by: Ursula Braun --- net/smc/smc_pnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH net-next 09/10] net/smc: parameter cleanup in smc_cdc_get_free_slot()

2017-09-20 Thread Ursula Braun
Use the smc_connection as first parameter with smc_cdc_get_free_slot(). This is just a small code cleanup, no functional change. Signed-off-by: Ursula Braun --- net/smc/smc_cdc.c | 7 --- net/smc/smc_cdc.h | 3 ++- net/smc/smc_tx.c | 6 ++ 3 files changed, 8 insertions(+), 8 deletions(-

[PATCH net-next 01/10] net/smc: add missing dev_put

2017-09-20 Thread Ursula Braun
From: Hans Wippel In the infiniband part, SMC currently uses get_netdev which calls dev_hold on the returned net device. However, the SMC code never calls dev_put on that net device resulting in a wrong reference count. This patch adds a dev_put after the usage of the net device to fix the issue

[PATCH net-next 06/10] net/smc: longer delay for client link group removal

2017-09-20 Thread Ursula Braun
Client link group creation always follows the server linkgroup creation. If peer creates a new server link group, client has to create a new client link group. If peer reuses a server link group for a new connection, client has to reuse its client link group as well. This patch introduces a longer

[PATCH net-next 05/10] net/smc: adapt send request completion notification

2017-09-20 Thread Ursula Braun
The solicited flag is meaningful for the receive completion queue. Ask for next work completion of any type on the send queue. Signed-off-by: Ursula Braun --- net/smc/smc_wr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/smc/smc_wr.c b/net/smc/smc_wr.c index ab56bda667

[PATCH net-next 00/10] net/smc: updates 2017-09-20

2017-09-20 Thread Ursula Braun
Hi Dave, here is a collection of small smc-patches built for net-next improving the smc code in different areas. Thanks, Ursula Hans Wippel (2): net/smc: add missing dev_put net/smc: add receive timeout check Ursula Braun (8): net/smc: take RCU read lock for routing cache lookup net/smc

[PATCH net-next 03/10] net/smc: take RCU read lock for routing cache lookup

2017-09-20 Thread Ursula Braun
smc_netinfo_by_tcpsk() looks up the routing cache. Such a lookup requires protection by an RCU read lock. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 8c6d24b2995d..2e8d2d

[PATCH net-next 02/10] net/smc: add receive timeout check

2017-09-20 Thread Ursula Braun
From: Hans Wippel The SMC receive function currently lacks a timeout check under the condition that no data were received and no data are available. This patch adds such a check. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc_rx.c | 2 ++ 1 file changed, 2 insertions(+

Re: [PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Ville Syrjälä
On Wed, Sep 20, 2017 at 12:39:24PM +0200, Johannes Berg wrote: > On Wed, 2017-09-20 at 13:11 +0300, Ville Syrjala wrote: > > > --- a/net/mac80211/tx.c > > +++ b/net/mac80211/tx.c > > @@ -1770,15 +1770,21 @@ bool ieee80211_tx_prepare_skb(struct ieee80211_hw > > *hw, > >   struct ieee80211_tx_dat

Re: [PATCH v2 1/2] mac80211: Add rcu read side critical sections

2017-09-20 Thread Johannes Berg
On Wed, 2017-09-20 at 15:11 +0300, Ville Syrjälä wrote: > > > I guess since the outer pointer isn't protected, only the inner ... > > I think just the fact that even the pointers in ieee80211_tx_data > don't have the __rcu annotation makes it rather hard to see what is > really rcu protected and

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Almost there Bisecting: 6 revisions left to test after this (roughly 3 steps) [ad65a2f05695aced349e308193c6e2a6b1d87112] ipv6: call dst_hold_safe() properly W dniu 2017-09-20 o 13:02, Paweł Staszewski pisze: Ok resumed and soo far: Panic: # bad: [9cc9a5cb176ccb4f2cda5ac34da5a659926f125f]

Re: rsi: fix a dereference on adapter before it has been null checked

2017-09-20 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The assignment of dev is dereferencing adapter before adapter has > been null checked, potentially leading to a null pointer dereference. > Fix this by simply moving the assignment of dev to a later point > after the sanity null check of adapter.

Re: [1/2] b43: fix unitialized reads of ret by initializing the array to zero

2017-09-20 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later scan of the array to read potentially > uninitialized values. Fix this by initiali

[PATCH] net_sched: always reset qdisc backlog in qdisc_reset()

2017-09-20 Thread Konstantin Khlebnikov
SKB stored in qdisc->gso_skb also counted into backlog. Some qdiscs don't reset backlog to zero in ->reset(), for example sfq just dequeue and free all queued skb. Signed-off-by: Konstantin Khlebnikov Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") --- net/sched/sch_generic.c

[PATCH] net_sched/hfsc: fix curve activation in hfsc_change_class()

2017-09-20 Thread Konstantin Khlebnikov
If real-time or fair-share curves are enabled in hfsc_change_class() class isn't inserted into rb-trees yet. Thus init_ed() and init_vf() must be called in place of update_ed() and update_vf(). Remove isn't required because for now curves cannot be disabled. Signed-off-by: Konstantin Khlebnikov

Re: mwifiex: remove unnecessary call to memset

2017-09-20 Thread Kalle Valo
Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Semantic patch used to resolve this issue: > > @@ > expression e,e2; constant c; > statement S; > @@ > > e = kza

Re: mwifiex: make const arrays static to shink object code size

2017-09-20 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static > Makes the object code smaller by nearly 300 bytes: > > Before: >text data bss dec hex filename > 69260 16149 576 85985 14fe1 cfg80211

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
And the last one git bisect good Bisecting: 1 revision left to test after this (roughly 1 step) [1cfb71eeb12047bcdbd3e6730ffed66e810a0855] ipv6: take dst->__refcnt for insertion into fib6 tree With this have kernel panic same as always git bisect bad Bisecting: 0 revisions left to test after

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
hmm But after b838d5e1c5b6e57b10ec8af2268824041e3ea911 is the first bad commit commit b838d5e1c5b6e57b10ec8af2268824041e3ea911 Author: Wei Wang Date:   Sat Jun 17 10:42:32 2017 -0700     ipv4: mark DST_NOGC and remove the operation of dst_free()     With the previous preparation patches, we a

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
Sorry for top-posting, but this is to give context to Wei, since Pawel used a top posting way to report his bisection. Wei, can you take a look at Pawel report ? Crash happens in dst_destroy() at following : if (dst->dev) dev_put(dst->dev); <> dst->dev is not NULL, but netdev->pcpu_refcnt

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
So far path for bisect was: git bisect start # bad: [ac7b75966c9c86426b55fe1c50ae148aa4571075] Merge tag 'pinctrl-v4.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl git bisect bad ac7b75966c9c86426b55fe1c50ae148aa4571075 # good: [e24dd9ee5399747b71c1d982a484fc760179

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Yes sorry for top-posting also. Configuration: Ethernet devices: lspci | grep Etherne 02:00.0 Ethernet controller: Intel Corporation I350 Gigabit Network Connection (rev 01) 02:00.1 Ethernet controller: Intel Corporation I350 Gigabit Network Connection (rev 01) 04:00.0 Ethernet controller: In

Re: [PATCH iproute2 json v2 05/27] ip: ipaddress.c: add support for json output

2017-09-20 Thread Sabrina Dubroca
Hi Julien, 2017-08-17, 10:35:52 -0700, Julien Fortin wrote: > From: Julien Fortin > > This patch converts all output (mostly fprintfs) to the new ip_print api > which handle both regular and json output. > Initialize a json_writer and open an array object if -json was specified. > Note that the

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
Could you try this debug patch ? diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index f535779d9dc1dfe36934c2abba4e43d053ac5d6f..1eaa3553a724dc8c048f67b556337072d5addc82 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3331,7 +3331,14 @@ void netdev_r

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 06:34 -0700, Eric Dumazet wrote: > Could you try this debug patch ? > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index > f535779d9dc1dfe36934c2abba4e43d053ac5d6f..1eaa3553a724dc8c048f67b556337072d5addc82 > 100644 > --- a/include/linux/netdevice.h

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 15:34, Eric Dumazet pisze: Could you try this debug patch ? diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index f535779d9dc1dfe36934c2abba4e43d053ac5d6f..1eaa3553a724dc8c048f67b556337072d5addc82 100644 --- a/include/linux/netdevice.h +++ b/include/lin

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 15:39 +0200, Paweł Staszewski wrote: > > W dniu 2017-09-20 o 15:34, Eric Dumazet pisze: > > Could you try this debug patch ? > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index > > f535779d9dc1dfe36934c2abba4e43d053ac5d6f..1eaa3553a724dc8c048

Re: [PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP

2017-09-20 Thread Leon Romanovsky
On Wed, Sep 20, 2017 at 05:46:35AM +, Kalderon, Michal wrote: > From: Leon Romanovsky > Sent: Tuesday, September 19, 2017 8:46 PM > On Tue, Sep 19, 2017 at 08:26:18PM +0300, Michal Kalderon wrote: > >> The maximum number of CQs supported is bound to the number > >> of connections supported, wh

Re: [PATCH net-next 08/10] net/smc: introduce a delay

2017-09-20 Thread Leon Romanovsky
On Wed, Sep 20, 2017 at 01:58:11PM +0200, Ursula Braun wrote: > The number of outstanding work requests is limited. If all work > requests are in use, tx processing is postponed to another scheduling > of the tx worker. Switch to a delayed worker to have a gap for tx > completion queue events befor

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
Nit much more after adding this patch https://bugzilla.kernel.org/attachment.cgi?id=258529 W dniu 2017-09-20 o 15:44, Eric Dumazet pisze: On Wed, 2017-09-20 at 15:39 +0200, Paweł Staszewski wrote: W dniu 2017-09-20 o 15:34, Eric Dumazet pisze: Could you try this debug patch ? diff --git a/

[patch net-next 00/16] mlxsw: Multicast flood update

2017-09-20 Thread Jiri Pirko
From: Jiri Pirko Nogah says: Currently, there are four erroneous flows in MC flood: 1. When MC is disabled it affects only the flood table for unregistered MC packets, but packets that match an entry in the MDB are unaffected. 2. When MC is disabled, MC packets are being sent to all the ports

[patch net-next 14/16] mlxsw: spectrum_switchdev: Update the mdb of mrouter port change

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Whenever a port starts / stops being mrouter, update all the mdb entries in the HW to flood / stop flooding mc packets there. The change should happen only if the port is not in the mid. (If it is, the mid should flood mc packets to this port anyway) Signed-off-by: Nogah Fran

[patch net-next 15/16] mlxsw: spectrum_switchdev: Remove mrouter flood in mdb flush

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel In mdb flush the port is being removed from all the mids it is registered to. But if the port is mrouter, all the mids floods to it. This patch remove mrouter ports from mids it is not registered to in the mdb flush. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --

[patch net-next 04/16] mlxsw: spectrum_switchdev: Save mids list per bridge device

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Instead of saving all the mids in the same list, save them per vlan device. This change allows a more efficient mid find. Also, in the next patches, there will be added a lot of loops over all the mids in bridge device for multicast disable, mrouter change and ndb flush. Sign

[patch net-next 09/16] mlxsw: spectrum_switchdev: Disable mdb when mc is disabled

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Remove all the mdb entries from the HW when mc is being disabled and re-write them when it is being enabled. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 41 +++--- 1 file changed, 37 insert

[patch net-next 11/16] mlxsw: spectrum_switchdev: Flood mc when mc is disabled by user flag

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When multicast is disabled, flood mc packets only to port that are marked BR_MCAST_FLOOD (instead to all). Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c| 21 + 1 file changed, 17 insertio

[patch net-next 13/16] mlxsw: spectrum_switchdev: Flood all mc packets to mrouter ports

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When mc is enabled, whenever a mc packet doesn't hit any mdb entry it is being flood to the ports marked as mrouters. However, all mc packets should be flooded to them even if they match an entry in the mdb. This patch adds the mrouter ports to every mdb entry that is being wr

[patch net-next 16/16] mlxsw: spectrum_switchdev: Consider mrouter status for mdb changes

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When a mrouter is registered or leaves a mid, don't update the HW. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/

[patch net-next 12/16] mlxsw: spectrum_switchdev: Flush the mdb when a port is being removed

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel When a port is being removed from a bridge, flush the bridge mdb to remove the mids of that port. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 39 -- 1 file changed, 29 insertions(+), 10

[patch net-next 08/16] mlxsw: spectrum_switchdev: Don't write mids to the HW when mc is disabled

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Don't write multicast related data to the HW when mc is disabled. Also, don't allocate mid id to new mids (so the remove function could know that they weren't wrote to the HW) Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_s

[patch net-next 10/16] mlxsw: spectrum_switchdev: Use generic mc flood function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Use the generic mc flood function to decide whether to flood mc to a port when mc is being enabled / disabled. Move this function in the file to avoid forward declaration. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_s

[patch net-next 01/16] mlxsw: spectrum_switchdev: Change mc_router to mrouter

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Change the naming of mc_router to mrouter to keep consistency. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/n

[patch net-next 07/16] mlxsw: spectrum_switchdev: Break mid deletion into two function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Break mid deletion into two function, so it will be possible in the future to delete a mid entry for other reasons then switchdev command (like port deletion). Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 3

[patch net-next 02/16] mlxsw: spectrum_switchdev: Add a ports bitmap to the mid db

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Add a bitmap of ports to the mid struct to hold the ports that are registered to this mid. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 + .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 20

[patch net-next 05/16] mlxsw: spectrum_switchdev: Break smid write function

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Break the smid write function into two, one that cleans the ports that might be still written there and one that changes an exiting mid entry. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 42 +++

[patch net-next 06/16] mlxsw: spectrum_switchdev: Attach mid id allocation to HW write

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Attach mid getting and releasing mid id to the HW write / remove, and add a flag to indicate whether the mid is in the HW. It is done because mid id is also HW index to this mid. This change allows adding in the following patches the ability to have a mid in the mdb cache but

[patch net-next 03/16] mlxsw: spectrum_switchdev: Remove reference count from mid

2017-09-20 Thread Jiri Pirko
From: Nogah Frankel Since there is a bitmap for the ports registered to each mid, there is no need for a ref count, since it will always be the number of set bits in this bitmap. Any check of the ref count was replaced with checking if the bitmap is empty. Signed-off-by: Nogah Frankel Signed-of

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-20 Thread Tom Herbert
On Tue, Sep 19, 2017 at 10:13 PM, Eric Dumazet wrote: > On Tue, 2017-09-19 at 21:59 -0700, Samudrala, Sridhar wrote: >> On 9/19/2017 5:48 PM, Tom Herbert wrote: >> > On Tue, Sep 19, 2017 at 5:34 PM, Samudrala, Sridhar >> > wrote: >> > > On 9/12/2017 3:53 PM, Tom Herbert wrote: >> > > > On Tue, Se

Re: [PATCH net-next] net: dsa: Utilize dsa_slave_dev_check()

2017-09-20 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Instead of open coding the check. > > Signed-off-by: Florian Fainelli If we do need to use it outside one day, we may think about renaming netdev_uses_dsa() to netdev_is_dsa_master() and renaming dsa_slave_dev_check() to netdev_is_dsa_slave(). In the mea

Re: [PATCH net-next 08/10] net/smc: introduce a delay

2017-09-20 Thread Ursula Braun
On 09/20/2017 04:03 PM, Leon Romanovsky wrote: > On Wed, Sep 20, 2017 at 01:58:11PM +0200, Ursula Braun wrote: >> The number of outstanding work requests is limited. If all work >> requests are in use, tx processing is postponed to another scheduling >> of the tx worker. Switch to a delayed worke

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 16:03 +0200, Paweł Staszewski wrote: > Nit much more after adding this patch > > https://bugzilla.kernel.org/attachment.cgi?id=258529 > This is why I suggested to replace the BUG() in another mail So : diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h ind

vhost_net: VM looses network when using vhost over time

2017-09-20 Thread Bernd Naumann
Hi @all, We have encountered/experience a bug which is more or less reproducible, but we do not know how to do it exactly or how to debug the issue in the first place. # Background In our setup we have a Ganti Cluser (kvm) with atm ~60 nodes running ~500 VMs, we are using tap interfaces on L2

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 16:40, Eric Dumazet pisze: On Wed, 2017-09-20 at 16:03 +0200, Paweł Staszewski wrote: Nit much more after adding this patch https://bugzilla.kernel.org/attachment.cgi?id=258529 This is why I suggested to replace the BUG() in another mail So : diff --git a/include/linux/n

RFC iproute2 doc files

2017-09-20 Thread Stephen Hemminger
I noticed that the iproute man pages are up to date but the LaTex documentation is very out of date. Rarely updated since the Linux 2.2 days. Either someone needs to do a massive editing job on them, or they should just be dropped. My preference would be to just drop everything in the doc/ direct

Re: [PATCH net-next 5/5] tls: Add generic NIC offload infrastructure.

2017-09-20 Thread Hannes Frederic Sowa
Hello, Boris Pismenny writes: > Hello, > > Hannes Frederic Sowa writes: >> Hello, >> >> Ilya Lesokhin writes: >> >> > Hannes Frederic Sowa writes: >> > >> >> The user should be aware of that they can't migrate the socket to >> >> another interface if they got hw offloaded. This is not the c

IP Expo show Europe 2017 Attendees List

2017-09-20 Thread Aspen Ella
Hi, Would you be interested in the "IP Expo show Europe 2017 Attendees List ?" Please Let me know your interest to send you the number of attendees and cost. Just let me know if you have any questions. Awaiting your reply Regards, Aspen Marketing Executive To remove from this mailing: reply w

Re: [PATCH net-next 00/10] net/smc: updates 2017-09-20

2017-09-20 Thread Bart Van Assche
On Wed, 2017-09-20 at 13:58 +0200, Ursula Braun wrote: > here is a collection of small smc-patches built for net-next improving > the smc code in different areas. Hello Ursula, Can you provide us an update for the timeline of the plan to transition from PF_SMC to PF_INET/PF_INET6 + SOCK_STREAM? S

Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

2017-09-20 Thread Stefan Hajnoczi
On Tue, Sep 19, 2017 at 10:38:40AM -0700, David Miller wrote: > From: Stefan Hajnoczi > Date: Mon, 18 Sep 2017 16:21:00 +0100 > > > On Fri, Sep 15, 2017 at 02:14:32PM -0700, David Miller wrote: > >> > diff --git a/include/uapi/linux/vm_sockets.h > >> > b/include/uapi/linux/vm_sockets.h > >> > in

RE: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-20 Thread Nisar.Sayed
Thanks Sergei, I will update it and submit next version. - Nisar > Hello! > > On 09/19/2017 01:02 AM, Nisar Sayed wrote: > > > Allow EEPROM write for less than MAX_EEPROM_SIZE > > > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to > > 10/100/1000 Ethernet device driver") > > Signe

Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

2017-09-20 Thread Hannes Frederic Sowa
Sridhar Samudrala writes: > This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used > to enable symmetric tx and rx queues on a socket. > > This option is specifically useful for epoll based multi threaded workloads > where each thread handles packets received on a single R

Re: [PATCH net-next 00/14] gtp: Additional feature support

2017-09-20 Thread Andreas Schultz
Hi Harald, On 20/09/17 01:19, Harald Welte wrote: Hi Tom, On Tue, Sep 19, 2017 at 08:59:28AM -0700, Tom Herbert wrote: On Tue, Sep 19, 2017 at 5:43 AM, Harald Welte wrote: On Mon, Sep 18, 2017 at 05:38:50PM -0700, Tom Herbert wrote: - IPv6 support see my detailed comments in other mail

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Andreas Schultz
On 19/09/17 02:38, Tom Herbert wrote: Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon. Th

Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

2017-09-20 Thread Andreas Schultz
On 19/09/17 14:09, Harald Welte wrote: Hi Dave, On Mon, Sep 18, 2017 at 09:17:51PM -0700, David Miller wrote: This and the new dst caching code ignores any source address selection done by ip_route_output_key() or the new tunnel route lookup helpers. Either source address selection should be

Re: [PATCH,net-next,0/2] Improve code coverage of syzkaller

2017-09-20 Thread Willem de Bruijn
On Wed, Sep 20, 2017 at 2:08 AM, David Miller wrote: > From: Petar Penkov > Date: Tue, 19 Sep 2017 21:26:14 -0700 > >> Furthermore, in a way testing already requires specific kernel >> configuration. In this particular example, syzkaller prefers >> synchronous operation and therefore needs 4KSTA

[PATCH v5 net 1/3] lan78xx: Fix for eeprom read/write when device auto suspend

2017-09-20 Thread Nisar Sayed
Fix for eeprom read/write when device auto suspend Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --gi

[PATCH v5 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

2017-09-20 Thread Nisar Sayed
Allow EEPROM write for less than MAX_EEPROM_SIZE Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Nisar Sayed --- drivers/net/usb/lan78xx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb

[PATCH v5 net 0/3] lan78xx: This series of patches are for lan78xx driver.

2017-09-20 Thread Nisar Sayed
This series of patches are for lan78xx driver. These patches fixes potential issues associated with lan78xx driver. v5 - Updated changes as per comments v4 - Updated changes to handle return values as per comments - Updated EEPROM write handling as per comments v3 - Updated chagnes as per comme

[PATCH v5 net 3/3] lan78xx: Use default values loaded from EEPROM/OTP after reset

2017-09-20 Thread Nisar Sayed
Use default value of auto duplex and auto speed values loaded from EEPROM/OTP after reset. The LAN78xx allows platform configurations to be loaded from EEPROM/OTP. Ex: When external phy is connected, the MAC can be configured to have correct auto speed, auto duplex, auto polarity configured from th

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 8:27 AM, Andreas Schultz wrote: > On 19/09/17 02:38, Tom Herbert wrote: >> >> Add new configuration of GTP interfaces that allow specifying a port to >> listen on (as opposed to having to get sockets from a userspace control >> plane). This allows GTP interfaces to be confi

[PATCH v4 0/4] Add cross-compilation support to eBPF samples

2017-09-20 Thread Joel Fernandes
These patches fix issues seen when cross-compiling eBPF samples on arm64. Compared to [1], I dropped the controversial inline-asm patch and exploring other options to fix it. However these patches are a step in the right direction and I look forward to getting them into -next and the merge window.

  1   2   3   4   >