Re: [PATCH] ipv6: Annotate change of locking mechanism for np->opt

2016-02-18 Thread Eric Dumazet
On mer., 2016-02-17 at 16:20 -0800, Benjamin Poirier wrote: > follows up commit 45f6fad84cc3 ("ipv6: add complete rcu protection around > np->opt") which added mixed rcu/refcount protection to np->opt. > > Given the current implementation of rcu_pointer_handoff(), this has no > effect at runtime.

[net-next 10/15] i40e: expand comment

2016-02-18 Thread Jeff Kirsher
From: Mitch Williams Explain why we cannot remove this code, even though it works differently than any of our other interrupt cause handling code. Change-ID: Ie66203bd037a466066036611c31d44f759ec5176 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drive

[net-next 01/15] i40e: get rid of magic number

2016-02-18 Thread Jeff Kirsher
From: Mitch Williams We have a define for this, use it. No functional change. Change-ID: Ic0e3ea4f562e46de63b2a8de07f291ccc10205fd Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed,

[net-next 06/15] i40e: Fix PROMISC mode for Multi-function per port (MFP) devices

2016-02-18 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch falls back to enabling unicast, multicast and broadcast promiscuous mode when the driver must disable it's use of "default port" aka defport mode (which is normally used to provide a promiscuous mode), due to internal incompatibility with Multiple Function per

[net-next 07/15] i40e: Removal of code which relies on BASE VEB SEID

2016-02-18 Thread Jeff Kirsher
From: Kiran Patil Fixed mapping of SEID is removed from specification. Hence this patch removes code which was using hard coded base VEB SEID. Changed FCoE code to use "hw->pf_id" to obtain correct "idx" and verified. Removed defines for BASE VSI/VEB SEID and BASE_PF_SEID since it is not used a

[net-next 14/15] i40e: When in promisc mode apply promisc mode to Tx Traffic as well

2016-02-18 Thread Jeff Kirsher
From: Anjali Singhai Jain In MFP mode particularly when we were setting the PF VSI in limited promiscuous, the HW switch was still mirroring the outgoing packets from other VSIs (VF/VMdq) onto the PF VSI. With this new bit set, the mirroring doesn't happen any more and so we are in limited promi

[net-next 11/15] i40e: better error reporting for nvmupdate

2016-02-18 Thread Jeff Kirsher
From: Shannon Nelson Make sure we return EBUSY while finishing up a reset, and add a few bits for better debug messages. Change-ID: I23f6c28a8d96d7aa171abcc265737cec7826c292 Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e

[net-next 09/15] i40e: Do not disable queues in the Legacy/MSI Interrupt handler

2016-02-18 Thread Jeff Kirsher
From: Anjali Singhai Jain The queues should never be enabled/disabled in the interrupt handler, ICR0 interrupt enable should be the only thing that needs to be dynamically changed in the handler. This patch fixes that. Without this patch X722 platforms were seeing weird ping timings when in Lega

[net-next 08/15] i40e/i40evf: avoid atomics

2016-02-18 Thread Jeff Kirsher
From: Mitch Williams In the case where we have a page fully used by receive data, we need to release the page fully to the stack. Instead of calling get_page (which increments the page count) followed by free_page (which decrements the page count), just donate our reference to the stack. Although

[net-next 15/15] i40e/i40evf: Bump i40e to 1.4.15 and i40evf to 1.4.11.

2016-02-18 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: Ie280dc67e37a1cf667c3469499a4fb90f4177b75 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 fil

[net-next 04/15] i40e: trivial: cleanup use of pf->hw

2016-02-18 Thread Jeff Kirsher
From: Jesse Brandeburg This patch makes use of a pointer called hw consistent in the i40e_remove function. Change-ID: Idacc7ff0a09a68289c57457a78618bf5497de077 Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c

[net-next 12/15] i40evf: set adapter state on reset failure

2016-02-18 Thread Jeff Kirsher
From: Mitch Williams If a reset fails to complete, the driver gets its affairs in order and awaits the cold solace of rmmod. Unfortunately, it was not properly setting the adapter state, which would cause a panic on rmmod, instead of the desired surcease. Set the adapter state to DOWN in this ca

[net-next 02/15] i40e: drop unused debugfs file "dump"

2016-02-18 Thread Jeff Kirsher
From: Jesse Brandeburg There was a completely unused file "dump" in debugfs that never panned out to be useful. Change-ID: I12bb9e37b5a83299725dda815a8746157baf6562 Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_d

[net-next 13/15] i40e: clean event descriptor before use

2016-02-18 Thread Jeff Kirsher
From: Shannon Nelson In one obscure corner case, it was possible to clear the NVM update wait flag when no update_done message was actually received. This patch cleans the event descriptor before use, and moves the opcode check to where it won't get done if there was no event to clean. Also upd

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-17

2016-02-18 Thread Jeff Kirsher
This series contains updates to i40e/i40evf once again. Mitch updates the use of a define instead of a magic number. Adds support for packet split receive on VFs, which is disabled by default. Expands on a code comment which was not verbose or really helpful. Fixes an issue where if a reset fai

[net-next 05/15] i40e: Add a SW workaround for lost interrupts

2016-02-18 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch adds a workaround for cases where we might have interrupts that got lost but WB happened. If that happens without this patch we will see a tx_timeout. To work around it, this patch goes ahead and reschedules NAPI in that situation, if NAPI is not already sched

[net-next 03/15] i40evf: support packet split receive

2016-02-18 Thread Jeff Kirsher
From: Mitch Williams Support packet split receive on VFs. This is off by default but can be enabled using ethtool private flags. Because we need to trigger a reset from outside of i40evf_main.c, create a new function to do so, and export it. Also update copyright year in file headers. Change-ID

Re: [PATCH net] vxlan: do not use fdb in metadata mode

2016-02-18 Thread Jiri Benc
On Thu, 18 Feb 2016 15:32:40 +0900, Simon Horman wrote: > The logic here looks correct to me but I am curious to know > what circumstances would lead to the kfree_skb() case. Setting up the interface in "external" (VXLAN_F_COLLECT_METADATA) mode, assigning an IP address and not setting a route wit

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-18 Thread Jeff Kirsher
On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote: > > > On Feb 18, 2016, at 03:29, David Miller > wrote: > >  > > From: John Holland > > Date: Thu, 18 Feb 2016 00:49:17 +0100 > >  > >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an > OTP > >> and has no externel EEPROM in

Re: [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs

2016-02-18 Thread Amir Vadai"
On Wed, Feb 17, 2016 at 03:07:23PM -0800, John Fastabend wrote: > [...] > > >> > >>> +static void u32_replace_hw_hnode(struct tcf_proto *tp, struct > >>> tc_u_hnode *h) > >>> +{ > >>> +struct net_device *dev = tp->q->dev_queue->dev; > >>> +struct tc_cls_u32_offload u32_offload = {0}; > >>>

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-18 Thread Paolo Abeni
On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote: > On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni wrote: > > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be > > correctly controlled.") changed the default xmit checksum setting > > for lwt vxlan/geneve ipv6 tunnels, so that no

Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-18 Thread Jiri Benc
On Wed, 17 Feb 2016 19:30:01 +0100, Paolo Abeni wrote: > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be > correctly controlled.") changed the default xmit checksum setting > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not > set into external UDP header. > This

[PATCH] net: phy: Add SGMII support for Marvell 88E1510/1512/1514/1518

2016-02-18 Thread Stefan Roese
Add code to select SGMII-to-copper mode upon SGMII interface selection. Signed-off-by: Stefan Roese Cc: Andrew Lunn Cc: Florian Fainelli Cc: David S. Miller --- drivers/net/phy/marvell.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/net

Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread Saeed Mahameed
On Wed, Feb 17, 2016 at 5:48 PM, Or Gerlitz wrote: > On Wed, Feb 17, 2016 at 2:00 PM, Saeed Mahameed > wrote: struct mlx5e_priv { /* priv data path fields - start */ - intdefault_vlan_prio; struct mlx5e_sq**txq_to_sq_m

Re: [PATCH net-next 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread Saeed Mahameed
On Wed, Feb 17, 2016 at 5:49 PM, Or Gerlitz wrote: > On Wed, Feb 17, 2016 at 2:07 PM, Saeed Mahameed > wrote: >> On Tue, Feb 16, 2016 at 11:38 PM, Or Gerlitz wrote: > - for (tc = 0; tc < priv->params.num_tc; tc++) { + for (tc = 0; tc < MLX5E_MAX_NUM_TC; tc++) {

[net-next] vlan: turn on unicast filtering on vlan device

2016-02-18 Thread Zhang Shengju
Currently vlan device inherits unicast filtering flag from underlying device. If underlying device doesn't support unicast filter, this will put vlan device into promiscuous mode when it's stacked. Tun on IFF_UNICAST_FLT on the vlan device in any case so that it does not go into promiscuous mode n

[PATCH net-next 2/4] geneve: move geneve device lookup before iptunnel_pull_header

2016-02-18 Thread Jiri Benc
This is in preparation for iptunnel_pull_header calling skb_scrub_packet. Signed-off-by: Jiri Benc --- drivers/net/geneve.c | 76 ++-- 1 file changed, 44 insertions(+), 32 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index

[PATCH net-next 1/4] geneve: implement geneve_get_sk_family helper

2016-02-18 Thread Jiri Benc
Similarly to the existing vxlan_get_sk_family. Signed-off-by: Jiri Benc --- drivers/net/geneve.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 6f208132a574..f09de1e30955 100644 --- a/drivers/net/geneve.

[PATCH net-next 3/4] vxlan: move vxlan device lookup before iptunnel_pull_header

2016-02-18 Thread Jiri Benc
This is in preparation for iptunnel_pull_header calling skb_scrub_packet. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 3a84680b5117..b43981416fb9 1006

[PATCH net-next 4/4] iptunnel: scrub packet in iptunnel_pull_header

2016-02-18 Thread Jiri Benc
Part of skb_scrub_packet was open coded in iptunnel_pull_header. Let it call skb_scrub_packet directly instead. Signed-off-by: Jiri Benc --- drivers/net/geneve.c | 4 ++-- drivers/net/vxlan.c | 4 ++-- include/net/ip_tunnels.h | 3 ++- net/ipv4/ip_gre.c | 2 +- net/ipv4/ip_tu

[PATCH net-next 0/4] iptunnel: scrub packet in iptunnel_pull_header

2016-02-18 Thread Jiri Benc
As every IP tunnel has to scrub skb on decapsulation, iptunnel_pull_header tried to do that and open coded part of skb_scrub_packet. Various tunneling protocols (VXLAN, Geneve) then called full skb_scrub_packet on their own, duplicating part of the scrubbing already done. Consolidate the code, cal

[patch net 0/2] mlxsw fixes

2016-02-18 Thread Jiri Pirko
From: Jiri Pirko Another bulk of fixes from Ido. Ido Schimmel (2): mlxsw: reg: Add the Switch Port Acceptable Frame Types register mlxsw: spectrum: Allow for PVID deletion drivers/net/ethernet/mellanox/mlxsw/reg.h | 58 ++ drivers/net/ethernet/mellanox/mlxsw/spectr

[patch net 2/2] mlxsw: spectrum: Allow for PVID deletion

2016-02-18 Thread Jiri Pirko
From: Ido Schimmel When PVID is toggled off on a port member in a VLAN filtering bridge or the PVID VLAN is deleted, make the port drop untagged packets. Reverse the operation when PVID is toggled back on. Set the PVID back to the default (1), when leaving the bridge so that untagged traffic wil

[patch net 1/2] mlxsw: reg: Add the Switch Port Acceptable Frame Types register

2016-02-18 Thread Jiri Pirko
From: Ido Schimmel When VLAN filtering is enabled on a bridge and PVID is deleted from a bridge port, then untagged frames are not allowed to ingress into the bridge from this port. Add the Switch Port Acceptable Frame Types (SPAFT) register, which configures the frame admittance of the port. F

[PATCH net-next V1 02/12] net/mlx5: Introduce physical port PFC access functions

2016-02-18 Thread Saeed Mahameed
From: Achiad Shochat Add access functions to set and query a physical port PFC (Priority Flow Control) parameters. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 41 include/linux/mlx5/port.h

[PATCH net-next V1 01/12] net/mlx5: Introduce a new header file for physical port functions

2016-02-18 Thread Saeed Mahameed
From: Achiad Shochat All the device physical port access functions are implemented in the port.c file. We just extract the exposure of these functions from driver.h into a dedicated header file called port.h. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed --- drivers/infiniband/h

[PATCH net-next V1 00/12] QoS and VxLAN offloads support for Mellanox 100G mlx5 driver

2016-02-18 Thread Saeed Mahameed
Hi Dave, This patch series introduces QoS IEEE dcbnl support for PFC, ETS and max rate. In addition we added VxLAN support and introduced a patch that modifies the driver to report checksum complete in RX path for all IP (tunneled and non-tunneled) traffic which is non HW LRO. This series is ap

[PATCH net-next V1 10/12] net/mlx5e: Add netdev support for VXLAN tunneling

2016-02-18 Thread Saeed Mahameed
From: Matthew Finlay If a VXLAN udp dport is added to device it will: - Configure the hardware to offload the port (up to the max supported). - Advertise NETIF_F_GSO_UDP_TUNNEL and supported hw_enc_features. Signed-off-by: Matt Finlay Signed-off-by: Saeed Mahameed --- drivers/net/

[PATCH net-next V1 06/12] net/mlx5e: Implement DCBNL IEEE max rate

2016-02-18 Thread Saeed Mahameed
From: Tariq Toukan Add support for DCBNL IEEE get/set max rate. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 73 drivers/net/ethernet/mellanox/mlx5/core/port.c | 63 + include/li

[PATCH net-next V1 12/12] net/mlx5e: Add tx inner packet counters

2016-02-18 Thread Saeed Mahameed
From: Matthew Finlay Add TSO and TX checksum counters for tunneled, inner packets Signed-off-by: Matt Finlay Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 16 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |8 +++- drivers/

[PATCH net-next V1 08/12] net/mlx5e: Move to checksum complete

2016-02-18 Thread Saeed Mahameed
From: Matthew Finlay Use checksum complete for all IP packets, unless they are HW LRO, in which case, use checksum unnecessary. Signed-off-by: Matt Finlay Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c |9 + 1 files changed, 5 insertions(+), 4 de

[PATCH net-next V1 05/12] net/mlx5e: Support DCBNL IEEE PFC

2016-02-18 Thread Saeed Mahameed
From: Achiad Shochat Implement the set/get DCBNL IEEE PFC callbacks. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 39 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next V1 03/12] net/mlx5: Introduce physical port TC/prio access functions

2016-02-18 Thread Saeed Mahameed
Add access functions to set and query a physical port TC groups and prio parameters. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 73 include/linux/mlx5/driver.h|2 + include/linux/mlx5/mlx5_ifc.h

[PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread Saeed Mahameed
Support the ndo_setup_tc callback and the needed methods for multi TC/UP support, and removed the default_vlan_prio from mlx5e_priv which is always 0, it was replaced with hardcoded "0" in the new select queue method. For that we now create MAX_NUM_TC num of TISs (one per prio) on netdevice creati

[PATCH net-next V1 07/12] net/mlx5e: Wake On LAN support

2016-02-18 Thread Saeed Mahameed
From: Tariq Toukan Implement set/get WOL by ethtool and added the needed device commands and structures to mlx5_ifc. Signed-off-by: Tariq Toukan Signed-off-by: Rana Shahout Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c |6 + .../net/ethernet/mellano

[PATCH net-next V1 09/12] net/mlx5e: Protect en header file from redefinitions

2016-02-18 Thread Saeed Mahameed
From: Matthew Finlay add ifndef to en.h. needed for upcoming vxlan patchset. Signed-off-by: Matt Finlay Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/mellanox/ml

[PATCH net-next V1 11/12] net/mlx5e: Add TX stateless offloads for tunneling

2016-02-18 Thread Saeed Mahameed
From: Matthew Finlay Add support for TSO and TX checksum when using hw assisted, tunneled offloads. Signed-off-by: Matt Finlay Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) di

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-18 Thread John Holland
Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. [1] http://www.intel.com/content/www/us/en/embedded/products/

Re: [PATCH v2 net-next 6/8] net: mvneta: bm: add support for hardware buffer management

2016-02-18 Thread Marcin Wojtas
Hi David, 2016-02-18 5:43 GMT+01:00 David Miller : > From: Gregory CLEMENT > Date: Tue, 16 Feb 2016 16:33:41 +0100 > >> pp->dev = dev; >> SET_NETDEV_DEV(dev, &pdev->dev); >> >> + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO; >> + dev->hw_features |= dev->feature

Alerta

2016-02-18 Thread Webmaster
Se ha superado el límite de almacenamiento del buzón debido a la alta tasa de spam / basura de todos los mensajes entrantes se rechazan. Para volver a validar su correo electrónico. Haga clic en el enlace de abajo y enviar el formulario a revalidar su correo electrónico. Haga clic aquí: http://

Re: [net-next PATCH v2 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-18 Thread Daniel Borkmann
On 02/17/2016 06:27 PM, Cong Wang wrote: On Wed, Feb 17, 2016 at 3:37 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be recla

Re: [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs

2016-02-18 Thread Jamal Hadi Salim
On 16-02-17 06:07 PM, John Fastabend wrote: [...] Actually thinking about this a bit more I wrote this thinking that there existed some hardware that actually cared if it was a new rule or an existing rule. For me it doesn't matter I do the same thing in the new/replace cases I just write int

Re: [net-next PATCH v2 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-18 Thread Jamal Hadi Salim
On 16-02-18 06:53 AM, Daniel Borkmann wrote: On 02/17/2016 06:27 PM, Cong Wang wrote: const struct tcf_proto *old_tp = tp; int limit = 0; - Why remove this empty line? I think it is still useful. :) Also your patch should be targeted to -net instead of -net-next, since it

[PATCH] b43: fix memory leak

2016-02-18 Thread Sudip Mukherjee
From: Sudip Mukherjee On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/broadcom/b43/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/driv

[net PATCH v3 0/1] tc reclassification needs to consider ether protocol changes

2016-02-18 Thread Jamal Hadi Salim
From: Jamal Hadi Salim v3: Cong says this needs to go to -net. And to put back the removed new line v2: Use Daniel's suggestion on when to set the skb proto v1: fix compile error found by build bot when CONFIG_NET_CLS_ACT was off Jamal Hadi Salim (1): net_sched fix: reclassification needs to

[net PATCH v3 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-18 Thread Jamal Hadi Salim
From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart the classification with the new proto header. Example setup used to

[PATCH net] af_unix: Don't use continue to re-execute unix_stream_read_generic loop

2016-02-18 Thread Rainer Weikusat
The unix_stream_read_generic function tries to use a continue statement to restart the receive loop after waiting for a message. This may not work as intended as the caller might use a recvmsg call to peek at control messages without specifying a message buffer. If this was the case, the continue w

Re: [net PATCH v3 1/1] net_sched fix: reclassification needs to consider ether protocol changes

2016-02-18 Thread Daniel Borkmann
On 02/18/2016 01:38 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim actions could change the etherproto in particular with ethernet tunnelled data. Typically such actions, after peeling the outer header, will ask for the packet to be reclassified. We then need to restart the classification

Re: [PATCH net V1 4/6] net/mlx4_core: Do not BUG_ON during reset when PCI is offline

2016-02-18 Thread Sergei Shtylyov
Hello. On 2/17/2016 6:24 PM, Or Gerlitz wrote: From: Daniel Jurgens The PCI channel could go offline during reset due to EEH. Don't bug on in this case, the error is recoverable. Fixes: f6bc11e42646 ('net/mlx4_core: Enhance the catas flow to support device reset') Signed-off-by: Daniel Jur

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Steinar H. Gunderson
On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > Steinar, can you check whether this fixes the bridge issues you reported on > bugzilla #99081? Not quite sure whether it is the same as yours as you > do not seem to have any such call traces. It doesn't immediately sound like the sa

[patch net-next] bridge: switchdev: Offload VLAN flags to hardware bridge

2016-02-18 Thread Jiri Pirko
From: Ido Schimmel When VLANs are created / destroyed on a VLAN filtering bridge (MASTER flag set), the configuration is passed down to the hardware. However, when only the flags (e.g. PVID) are toggled, the configuration is done in the software bridge alone. While it is possible to pass these f

[net-next PATCH 1/1] net_sched: Improve readability of filter processing

2016-02-18 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- net/sched/sch_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index af1acf0..de1e176 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1841,7 +1841,7 @@ re

Re: [PATCH 1/1] cxgb3: fix up vpd strings for kstrto*()

2016-02-18 Thread Sergei Shtylyov
Hello. On 2/17/2016 11:36 PM, Steve Wise wrote: The vpd strings are left justified, in a fixed length array, with possible trailing white space and no NUL. So fix them up before calling kstrto*(). This is a recent regression which causes cxgb3 to fail to load. Fixes:e72c932('cxgb3: Convert s

Re: [PATCH nf-next v7 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

2016-02-18 Thread Pablo Neira Ayuso
On Wed, Feb 17, 2016 at 02:06:54PM -0800, Joe Stringer wrote: > On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > > Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This > > avoids dropping a SYN packet re-opening an existing TCP connection. > > > > Signed-off-by: Jarno Rajahalme

[PATCH 1/2] net: thunderx: Fix const type in nicvf_set_rxfh()

2016-02-18 Thread Robert Richter
From: Robert Richter >From struct ethtool_ops: int (*set_rxfh)(struct net_device *, const u32 *indir, const u8 *key, const u8 hfunc); Change function arg of hfunc to const type. Signed-off-by: Robert Richter --- drivers/net/ethernet/cavium/thunder/nicv

[PATCH 0/2] net: thunderx: Small cleanups

2016-02-18 Thread Robert Richter
From: Robert Richter Sending two small cleanups of the driver fixing issues found during code review. Robert Richter (2): net: thunderx: Fix const type in nicvf_set_rxfh() net, thunderx: Use bool in structs where possible drivers/net/ethernet/cavium/thunder/nic.h | 12 ++-

[PATCH 2/2] net, thunderx: Use bool in structs where possible

2016-02-18 Thread Robert Richter
From: Robert Richter Looks like the :1 notation was accidentally introduced (this still uses 1 byte per flag). Using bool instead, which is the common use. Signed-off-by: Robert Richter --- drivers/net/ethernet/cavium/thunder/nic.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

RE: [PATCH] tipc: unlock in error path

2016-02-18 Thread Xue, Ying
Acked-by: Ying Xue -Original Message- From: Insu Yun [mailto:wuni...@gmail.com] Sent: 2016年2月18日 0:48 To: jon.ma...@ericsson.com; Xue, Ying; da...@davemloft.net; netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux-ker...@vger.kernel.org Cc: tae...@gatech.edu; yeongjin

[PATCH net v3.16]r8169: Start on full duplex 8101

2016-02-18 Thread Corcodel Marian
For more info send email. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 69 ++-- 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 61623e

Re: [PATCH nf 2/3] netfilter: ipvs: allow rescheduling after RST

2016-02-18 Thread Sergei Shtylyov
Hello. On 2/18/2016 3:41 AM, Simon Horman wrote: From: Julian Anastasov "RFC 5961, 4.2. Mitigation" describes a mechanism to request client to confirm with RST the restart of TCP connection before resending its SYN. As result, IPVS can see SYNs for existing connection in CLOSE state. Add chec

[PATCH net] route: check and remove route cache when we get route

2016-02-18 Thread Xin Long
Since the gc of ipv4 route was removed, the route cached would has no chance to be removed, and even it has been timeout, it still could be used, cause no code to check it's expires. Fix this issue by checking and removing route cache when we get route. Signed-off-by: Xin Long Acked-by: Hannes

Re: [PATCH] net: fix bridge multicast packet checksum validation

2016-02-18 Thread Linus Lüssing
On Thu, Feb 18, 2016 at 01:51:34PM +0100, Steinar H. Gunderson wrote: > On Mon, Feb 15, 2016 at 03:07:06AM +0100, Linus Lüssing wrote: > > Steinar, can you check whether this fixes the bridge issues you reported on > > bugzilla #99081? Not quite sure whether it is the same as yours as you > > do no

[PATCH net] tcp/dccp: fix another race at listener dismantle

2016-02-18 Thread Eric Dumazet
Ilya reported following lockdep splat: kernel: = kernel: [ BUG: held lock freed! ] kernel: 4.5.0-rc1-ceph-00026-g5e0a311 #1 Not tainted kernel: - kernel: swapper/5/0 is freeing memory 880035c9d200-880035c9dbff, with a lock still held there! k

Re: [PATCH] b43: fix memory leak

2016-02-18 Thread Rafał Miłecki
On 18 February 2016 at 13:34, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and mayb

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-18 Thread John Holland
On 02/18/2016 12:10 PM, John Holland wrote: Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled. + if (eth

Re: [net-next PATCH 1/1] net_sched: Improve readability of filter processing

2016-02-18 Thread Daniel Borkmann
On 02/18/2016 02:04 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim Acked-by: Daniel Borkmann

Re: [PATCH net 1/3] sctp: move rcu_read_lock from __sctp_lookup_association to sctp_lookup_association

2016-02-18 Thread Xin Long
On Thu, Feb 18, 2016 at 12:11 AM, Neil Horman wrote: > On Mon, Feb 15, 2016 at 02:28:03PM +0800, Xin Long wrote: >> __sctp_lookup_association() is only invoked by sctp_v4_err() and >> sctp_rcv(), both which run on the rx BH, and it has been protected >> by rcu_read_lock [see ip_local_deliver_finis

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-02-18 Thread Jiri Slaby
Cc Tejun (workqueues), Takashi (debug patch) On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote: > Hello, > > I've hit the following warning while running syzkaller fuzzer: Hi, I am hitting it over and over again using syzkaller. > WARNING: CPU: 2 PID: 17409 at kernel/workqueue.c:3968 > destroy_work

[PATCH -next 0/5] netlink: remove mmapped netlink support

2016-02-18 Thread Florian Westphal
As discussed during netconf 2016 in Seville, this series removes CONFIG_NETLINK_MMAP. Close to three years after it was merged it has retained several problems that do not appear to be fixable. No official netfilter libmnl release contains support for mmap backed netlink sockets. No openvswitch r

[PATCH net-next 5/5] nfnetlink: Revert "nfnetlink: add support for memory mapped netlink"

2016-02-18 Thread Florian Westphal
reverts commit 3ab1f683bf8b ("nfnetlink: add support for memory mapped netlink")' Like previous commits in the series, remove wrappers that are not needed after mmapped netlink removal. Signed-off-by: Florian Westphal --- include/linux/netlink.h | 10 -- net/netfilter/nfnetlink_

[PATCH net-next 4/5] nfnetlink: remove nfnetlink_alloc_skb

2016-02-18 Thread Florian Westphal
Following mmapped netlink removal this code can be simplified by removing the alloc wrapper. Signed-off-by: Florian Westphal --- include/linux/netfilter/nfnetlink.h | 2 -- net/netfilter/nfnetlink.c | 7 --- net/netfilter/nfnetlink_log.c | 5 ++--- 3 files changed, 2 insertio

[PATCH net-next 3/5] Revert "genl: Add genlmsg_new_unicast() for unicast message allocation"

2016-02-18 Thread Florian Westphal
This reverts commit bb9b18fb55b0 ("genl: Add genlmsg_new_unicast() for unicast message allocation")'. Nothing wrong with it; its no longer needed since this was only for mmapped netlink support. Signed-off-by: Florian Westphal --- include/net/genetlink.h| 4 net/netlink/genetlink.c

[PATCH net-next 1/5] netlink: remove mmapped netlink support

2016-02-18 Thread Florian Westphal
mmapped netlink has a number of unresolved issues: - TX zerocopy support had to be disabled more than a year ago via commit 4682a0358639b29cf ("netlink: Always copy on mmap TX.") because the content of the mmapped area can change after netlink attribute validation but before message processi

[PATCH net-next 2/5] openvswitch: Revert: "Enable memory mapped Netlink i/o"

2016-02-18 Thread Florian Westphal
revert commit 795449d8b846 ("openvswitch: Enable memory mapped Netlink i/o"). Following the mmaped netlink removal this code can be removed. Signed-off-by: Florian Westphal --- net/openvswitch/datapath.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/openvswit

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-02-18 Thread Dmitry Vyukov
On Thu, Feb 18, 2016 at 3:00 PM, Jiri Slaby wrote: > Cc Tejun (workqueues), Takashi (debug patch) > > On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote: >> Hello, >> >> I've hit the following warning while running syzkaller fuzzer: > > Hi, > > I am hitting it over and over again using syzkaller. > >> W

[PATCH v2 1/1] cxgb3: fix up vpd strings for kstrto*()

2016-02-18 Thread Steve Wise
The vpd strings are left justified, in a fixed length array, with possible trailing white space and no NUL. So fix them up before calling kstrto*(). This is a recent regression which causes cxgb3 to fail to load. Fixes:e72c932('cxgb3: Convert simple_strtoul to kstrtox') Signed-off-by: Steve Wis

Re: [PATCH net-next,V2] net: macb: make magic-packet property generic

2016-02-18 Thread Rob Herring
On Tue, Feb 16, 2016 at 09:10:45PM -0200, Sergio Prado wrote: > As requested by Rob Herring on patch > https://patchwork.ozlabs.org/patch/580862/. > > This is a new property that it's still in net-next and has never been > used in production, so we are not breaking anything with the > incompatible

Re: [PATCH net-next 1/4] geneve: implement geneve_get_sk_family helper

2016-02-18 Thread John W. Linville
On Thu, Feb 18, 2016 at 11:22:49AM +0100, Jiri Benc wrote: > Similarly to the existing vxlan_get_sk_family. > > Signed-off-by: Jiri Benc > --- > drivers/net/geneve.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/geneve.c b/drivers/net

[PATCH net] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-18 Thread Chunhao Lin
There will be a log spam when there is no cable plugged. Please refer to following links. https://bugzilla.kernel.org/show_bug.cgi?id=104351 https://bugzilla.kernel.org/show_bug.cgi?id=107421 This issue is caused by runtime power management. When there is no cable plugged, the driver will be suspe

[PATCH net-next 0/2] qed{,e}: Add vlan filtering offload

2016-02-18 Thread Yuval Mintz
This series adds vlan filtering offload to qede. First patch introduces small additional infrastructure needed in qed to support it, while second contains the main bulk of driver changes. Dave, Please consider applying this series to `net-next'. Thanks, Yuval -- 1.8.3.1

[PATCH net-next 2/2] qede: Add vlan filtering offload support

2016-02-18 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru Device would start receiving only vlan-tagged traffic with tags matching that of one of the configured vlan IDs, unless: - Device is expliicly placed in PROMISC mode. - Device exhausts its vlan filter credits. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-b

[PATCH] sctp: Fix port hash table size computation

2016-02-18 Thread Neil Horman
Dmitry Vyukov noted recently that the sctp_port_hashtable had an error in its size computation, observing that the current method never guaranteed that the hashsize (measured in number of entries) would be a power of two, which the input hash function for that table requires. The root cause of the

Re: [PATCH 0/4] Namespacify inet_peer_* sysctl knobs

2016-02-18 Thread Nikolay Borisov
On 02/17/2016 09:15 PM, Eric W. Biederman wrote: > Nikolay Borisov writes: > >> This series make the inet_peer ttl sysctls to be namespace aware. >> >> Patch 1 adds a namespace association to the inet_peer_base struct, >> which in turn is used to make the sysctls namespace aware. The >> rest

[PATCH net-next 1/2] qed: Lay infrastructure for vlan filtering offload

2016-02-18 Thread Yuval Mintz
Today, interfaces are working in vlan-promisc mode; But once vlan filtering offloaded would be supported, we'll need a method to control it directly [e.g., when setting device to PROMISC, or when running out of vlan credits]. This adds the necessary API for L2 client to manually choose whether to

Re: [PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-18 Thread Eric Dumazet
On mar., 2016-02-16 at 14:51 +0100, Bendik Rønning Opstad wrote: > RDB is a mechanism that enables a TCP sender to bundle redundant > (already sent) data with TCP packets containing new data. By bundling > (retransmitting) already sent data with each TCP packet containing new > data, the connection

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-18 Thread David Miller
From: John Holland Date: Thu, 18 Feb 2016 08:53:07 +0100 > The PCI path in eth_platform_get_mac_address() didn't return a devicetree > node... Then fix your platform such that pci_device_to_OF_node() works properly instead of adding localized hacks to device drivers. Jeff, do not apply this pa

Re: [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs

2016-02-18 Thread John Fastabend
On 16-02-18 04:14 AM, Jamal Hadi Salim wrote: > On 16-02-17 06:07 PM, John Fastabend wrote: >> [...] >> > >> Actually thinking about this a bit more I wrote this thinking >> that there existed some hardware that actually cared if it was >> a new rule or an existing rule. For me it doesn't matter I

Re: [PATCH net-next 1/4] geneve: implement geneve_get_sk_family helper

2016-02-18 Thread Jiri Benc
On Thu, 18 Feb 2016 09:44:10 -0500, John W. Linville wrote: > On Thu, Feb 18, 2016 at 11:22:49AM +0100, Jiri Benc wrote: > > +static sa_family_t geneve_get_sk_family(struct geneve_sock *gs) > > +{ > > + return gs->sock->sk->sk_family; > > +} > > + > > Should this be inline? AFAIK the kernel pol

pull-request: wireless-drivers 2016-02-18

2016-02-18 Thread Kalle Valo
Hi Dave, I have some important fixes I would like to get 4.5 still, more info in the signed tag. Please let me know if you have problems. Kalle The following changes since commit f9ead9beef3f44be0db4b542a8c2ce698fb1530e: Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of https://git.kernel.org/pu

Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

2016-02-18 Thread John Fastabend
On 16-02-18 02:32 AM, Saeed Mahameed wrote: > Support the ndo_setup_tc callback and the needed methods > for multi TC/UP support, and removed the default_vlan_prio > from mlx5e_priv which is always 0, it was replaced with > hardcoded "0" in the new select queue method. > > For that we now create M

  1   2   3   >