Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 14:02:52 -0700, Stephen Hemminger wrote: > > I am not keen on patches that make via-rhine more of a special case even if > > it was safe now; next thing you know generic_mii_ioctl is changed in a way > > that breaks the only driver that foolishly made assumptions about the > > s

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > The other drivers should be fixed as well. Phy access with irq's disabled > is not good. The hardware I checked takes 100's of usecs to do one read > transaction. Yep, 802.3 allows it. :o| It's surprizing that the low latency squadron has not compl

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 22:47:31 +0200 Roger Luethi <[EMAIL PROTECTED]> wrote: > On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote: > > The right thing to do is get rid of the locking in via_rhine:netdev_ioctl > > and push the locking down into mdio_read, mdio_write. > > As I said before, a

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote: > The right thing to do is get rid of the locking in via_rhine:netdev_ioctl > and push the locking down into mdio_read, mdio_write. As I said before, a dozen other network drivers do the exact same thing -- they call generic_mii_ioctl ri

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 14:26:43 -0400, John W. Linville wrote: > > I wonder if low latency for ancient Rhine-I chips is worth the trouble. > > IIRC, the point was that mdelay was getting called in interrupt > context and causing ugly messages to show-up in dmesg. I suppose the patch back then was to

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 14:26:43 -0400 "John W. Linville" <[EMAIL PROTECTED]> wrote: > On Mon, Mar 27, 2006 at 10:39:46PM +0200, Roger Luethi wrote: > > On Fri, 24 Mar 2006 16:49:10 +0100, Marco Berizzi wrote: > > > Hello evebody. > > > I get this error on linux vanilla 2.6.16 > > > with via_rhine mod

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread John W. Linville
On Mon, Mar 27, 2006 at 10:39:46PM +0200, Roger Luethi wrote: > On Fri, 24 Mar 2006 16:49:10 +0100, Marco Berizzi wrote: > > Hello evebody. > > I get this error on linux vanilla 2.6.16 > > with via_rhine module loaded when > > I run mii-tool: > > That was caused by a recent change that replaced a

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-03-27 Thread Roger Luethi
On Fri, 24 Mar 2006 16:49:10 +0100, Marco Berizzi wrote: > Hello evebody. > I get this error on linux vanilla 2.6.16 > with via_rhine module loaded when > I run mii-tool: That was caused by a recent change that replaced an mdelay with msleep. netdev_ioctl and friends (ethtool calls, too) are kno

via_rhine modules error on 2.6.16 with mii-tool

2006-03-24 Thread Marco Berizzi
Hello evebody. I get this error on linux vanilla 2.6.16 with via_rhine module loaded when I run mii-tool: cheduling while atomic: mii-tool/0x0001/923 [] schedule+0x632/0x640 [] schedule_timeout+0x57/0xb0 [] process_timeout+0x0/0x10 [] msleep+0x28/0x30 [] rhine_disable_linkmon+0xab/0x130 [via