Re: via-velocity skb_over_panic

2015-11-13 Thread Francois Romieu
Timo Teras : [...] > So it's possible that some bad packets make the NIC return unexpected > packet sizes, and the current code can panic on it. > > Any suggestions for better fix? if (vptr->flags & VELOCITY_FLAGS_VAL_PKT_LEN) { if (rd->rdesc0.RSR & RSR_RL) { Huh ? [...

Re: via-velocity skb_over_panic

2015-11-13 Thread David Miller
From: Timo Teras Date: Fri, 13 Nov 2015 18:49:47 +0200 > + if (pkt_len < 4 || pkt_len > vptr->rx.buf_sz) { > + VELOCITY_PRT(MSG_LEVEL_VERBOSE, KERN_ERR " %s : the received > frame size %d is inconsistent.\n", vptr->netdev->name, pkt_len); ... > This seems to have fixed the panic

via-velocity skb_over_panic

2015-11-13 Thread Timo Teras
Hi, I recently saw via-velocity skb_over_panic() on one of my locations. The panic happened with two separate hardware devices, so it appears to be network related, not broken hardware. I did not get the actual over_panic printk, as I got only screen shot of them monitor. But the visible part of