Re: tw32_f() in tg3_write_mem()

2006-05-01 Thread Michael Chan
On Sun, 2006-04-30 at 23:07 -0700, David S. Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Sun, 30 Apr 2006 22:05:40 -0700 > > > Reading back the data register is a safe thing to do. This > > guarantees that the data is written before we change the address > > register to the zer

Re: tw32_f() in tg3_write_mem()

2006-04-30 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Sun, 30 Apr 2006 22:05:40 -0700 > Reading back the data register is a safe thing to do. This > guarantees that the data is written before we change the address > register to the zero value. Without the read, there is a danger of > the value being writ

Re: tw32_f() in tg3_write_mem()

2006-04-30 Thread Michael Chan
David S. Miller wrote: > At least for the TG3PCI_MEM_WIN_DATA register, I don't know how safe > it is to use tw32_f() there. Reads from a location can have side > effects, so doing a forced readback after a write could be dangerous. > > And it isn't needed, as the tw32_f() done as we set the > T

tw32_f() in tg3_write_mem()

2006-04-29 Thread David S. Miller
At least for the TG3PCI_MEM_WIN_DATA register, I don't know how safe it is to use tw32_f() there. Reads from a location can have side effects, so doing a forced readback after a write could be dangerous. And it isn't needed, as the tw32_f() done as we set the TG3PCI_MEM_WIN_BASE_ADDR back to zer