Re: [PATCH net-next v2 0/2] tcp: add NV congestion control

2016-06-10 Thread David Miller
net-next v2 2/2] tcp: add NV congestion control > > Signed-off-by: Lawrence Brakmo Series applied, thanks.

[PATCH net-next v2 0/2] tcp: add NV congestion control

2016-06-08 Thread Lawrence Brakmo
Removed most of the module parameters Tested in a rack using between 1 and 380 active TCP-NV flows. Consists of the following patches: [PATCH net-next v2 1/2] tcp: add in_flight to tcp_skb_cb [PATCH net-next v2 2/2] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net

[PATCH net-next v2 2/2] tcp: add NV congestion control

2016-06-08 Thread Lawrence Brakmo
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us and with 1 to 400 flows. A description of TCP-NV, in

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread David Miller
From: Lawrence Brakmo Date: Tue, 7 Jun 2016 01:04:06 + > The reason why this may be necessary, is that under some conditions > NV flows competing with more aggressive flows will perform > poorly. People may be more willing to test NV if there is a quick > and simple way to revert if necessary

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread Lawrence Brakmo
On 6/6/16, 4:01 PM, "David Miller" wrote: >From: Lawrence Brakmo >Date: Fri, 3 Jun 2016 13:37:58 -0700 > >> +module_param(nv_enable, int, 0644); >> +MODULE_PARM_DESC(nv_enable, "enable NV (congestion avoidance) >>behavior"); >> +module_param(nv_pad, int, 0644); >> +MODULE_PARM_DESC(nv_pad, "extr

Re: [PATCH net-next 2/2] tcp: add NV congestion control

2016-06-06 Thread David Miller
From: Lawrence Brakmo Date: Fri, 3 Jun 2016 13:37:58 -0700 > +module_param(nv_enable, int, 0644); > +MODULE_PARM_DESC(nv_enable, "enable NV (congestion avoidance) behavior"); > +module_param(nv_pad, int, 0644); > +MODULE_PARM_DESC(nv_pad, "extra packets above congestion level"); > +module_param(n

[PATCH net-next 0/2] tcp: add NV congestion control

2016-06-03 Thread Lawrence Brakmo
net-next 2/2] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net/tcp.h | 2 + net/ipv4/Kconfig | 16 ++ net/ipv4/Makefile | 1 + net/ipv4/tcp_input.c | 5 +- net/ipv4/tcp_nv.c | 597 net/ipv4

[PATCH net-next 2/2] tcp: add NV congestion control

2016-06-03 Thread Lawrence Brakmo
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of TCP-NV, including implementation d

Re: [PATCH net-next 0/2] tcp: add NV congestion control

2016-05-19 Thread David Miller
ows. > > Consists of the following patches: > [PATCH net-next 1/2] tcp: add in_flight to tcp_skb_cb > [PATCH net-next 2/2] tcp: add NV congestion control > > Signed-off-by: Lawrence Brakmo Sorry this is too late for the current merge window, please resubmit when the net-next tree opens back up.

[PATCH net-next 0/2] tcp: add NV congestion control

2016-05-17 Thread Lawrence Brakmo
tcp_skb_cb [PATCH net-next 2/2] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net/tcp.h | 2 + net/ipv4/Kconfig | 16 ++ net/ipv4/Makefile | 1 + net/ipv4/tcp_input.c | 6 +- net/ipv4/tcp_nv.c | 592 net

[PATCH net-next 2/2] tcp: add NV congestion control

2016-05-17 Thread Lawrence Brakmo
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of TCP-NV, including implementation d

Re: tcp: add NV congestion control

2015-08-26 Thread Lawrence Brakmo
r link utilization. > >Consists of the following patches: > >[RFC PATCH v6 net-next 1/4] tcp: replace cnt & rtt with struct in >[RFC PATCH v6 net-next 2/4] tcp: refactor struct tcp_skb_cb >[RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb >[RFC PATCH v6 net-

Re: tcp: add NV congestion control

2015-08-25 Thread David Miller
From: Lawrence Brakmo Date: Tue, 25 Aug 2015 16:33:50 -0700 > Changes from v5: cleaning of NV code, changing some default parameters I have no fundamental objections to this patch series. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@v

Re: [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
On 8/5/15, 5:51 PM, "knn...@gmail.com on behalf of Kenneth Klette Jonassen" wrote: >On Wed, Aug 5, 2015 at 3:39 AM, Lawrence Brakmo wrote: >> This is a request for comments. > >Nice to see more development on delay-based congestion control. > >It would be good to see how NV stacks up against C

tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
sts of the following patches: [RFC PATCH v6 net-next 1/4] tcp: replace cnt & rtt with struct in [RFC PATCH v6 net-next 2/4] tcp: refactor struct tcp_skb_cb [RFC PATCH v6 net-next 3/4] tcp: add in_flight to tcp_skb_cb [RFC PATCH v6 net-next 4/4] tcp: add NV congestion control Signed-off-by: L

[RFC PATCH v6 net-next 4/4] tcp: add NV congestion control

2015-08-25 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of T

Re: [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-21 Thread Lawrence Brakmo
Kenneth, thank you for your comments, I¹ve implemented most of the improvements you've mentioned. I¹m finishing the new patch and the updated results, they should be done by Monday (including cdg). On 8/5/15, 5:51 PM, "knn...@gmail.com on behalf of Kenneth Klette Jonassen" wrote: >On Wed, Aug 5

Re: [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-05 Thread Kenneth Klette Jonassen
On Wed, Aug 5, 2015 at 3:39 AM, Lawrence Brakmo wrote: > This is a request for comments. Nice to see more development on delay-based congestion control. It would be good to see how NV stacks up against CDG. Any chance of adding cdg as a congestion control parameter to your experiments? Experimen

[RFC PATCH v5 net-next 0/4] tcp: add NV congestion control

2015-08-04 Thread Lawrence Brakmo
H v5 net-next 3/4] tcp: add in_flight to tcp_skb_cb [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net/tcp.h | 20 ++- net/ipv4/Kconfig| 16 ++ net/ipv4/Makefile | 1 + net/ipv4/tcp_bic.c | 6 +- net/ipv4/tcp_cdg.c |

[RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-04 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of T

[RFC PATCH v4 net-next 0/4] tcp: add NV congestion control

2015-07-24 Thread Lawrence Brakmo
4 net-next 1/4] tcp: replace cnt & rtt with struct in pkts_acked() [RFC PATCH v4 net-next 2/4] tcp: refactor struct tcp_skb_cb [RFC PATCH v4 net-next 3/4] tcp: add in_flight to tcp_skb_cb [RFC PATCH v4 net-next 4/4] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/

[RFC PATCH v4 net-next 4/4] tcp: add NV congestion control

2015-07-24 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of T

[RFC PATCH v3 net-next 3/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A descrip

[RFC PATCH v3 net-next 0/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
[RFC PATCH v3 net-next 3/3] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net/tcp.h | 20 ++- net/ipv4/Kconfig| 16 ++ net/ipv4/Makefile | 1 + net/ipv4/tcp_bic.c | 6 +- net/ipv4/tcp_cdg.c | 14 +- net/ipv4/tcp_cubic.c| 6 +- net/

Re: [RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
Thank you all for your comments, I¹m currently testing the changes. Other comments inline. On 7/21/15, 11:50 PM, "Yuchung Cheng" wrote: >On Tue, Jul 21, 2015 at 9:21 PM, Lawrence Brakmo wrote: >> This is a request for comments. >> >> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier

Re: [RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-22 Thread Neal Cardwell
On Wed, Jul 22, 2015 at 2:50 AM, Yuchung Cheng wrote: > On Tue, Jul 21, 2015 at 9:21 PM, Lawrence Brakmo wrote: >> This is a request for comments. >> >> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of >> NV was presented at 2010's LPC (slides). It is a delayed based >> co

Re: [RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-21 Thread Yuchung Cheng
On Tue, Jul 21, 2015 at 9:21 PM, Lawrence Brakmo wrote: > This is a request for comments. > > TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of > NV was presented at 2010's LPC (slides). It is a delayed based > congestion avoidance for the data center. This version has been

[RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-21 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A descrip

[RFC PATCH v2 net-next 0/3] tcp: add NV congestion control

2015-07-21 Thread Lawrence Brakmo
[RFC PATCH v2 net-next 3/3] tcp: add NV congestion control Signed-off-by: Lawrence Brakmo include/net/tcp.h | 21 ++- net/ipv4/Kconfig | 16 ++ net/ipv4/Makefile | 1 + net/ipv4/sysctl_net_ipv4.c | 9 + net/ipv4/tcp_bic.c | 6 +- net/ipv4/tcp_c

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 1:30 PM, "Neal Cardwell" wrote: >> diff --git a/include/linux/tcp.h b/include/linux/tcp.h >> index 48c3696..05e0da5 100644 >> --- a/include/linux/tcp.h >> +++ b/include/linux/tcp.h >> @@ -254,6 +254,10 @@ struct tcp_sock { >> u32 lost_out; /* Lost packets

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 10:10 AM, "Tom Herbert" wrote: >On Thu, Jul 2, 2015 at 6:21 PM, Lawrence Brakmo wrote: >> This is a request for comments. >> >> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of >> NV was presented at 2010's LPC (slides). It is a delayed based >> congestion av

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 9:47 AM, "David Miller" wrote: >From: Lawrence Brakmo >Date: Thu, 2 Jul 2015 18:21:24 -0700 > >> This is a request for comments. >> >> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of >> NV was presented at 2010's LPC (slides). It is a delayed based >> conge

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Neal Cardwell
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index 48c3696..05e0da5 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -254,6 +254,10 @@ struct tcp_sock { > u32 lost_out; /* Lost packets */ > u32 sacked_out; /* SACK'd

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Tom Herbert
On Thu, Jul 2, 2015 at 6:21 PM, Lawrence Brakmo wrote: > This is a request for comments. > > TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of > NV was presented at 2010's LPC (slides). It is a delayed based > congestion avoidance for the data center. This version has been t

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Eric Dumazet
On Fri, 2015-07-03 at 09:37 -0700, David Miller wrote: > From: Eric Dumazet > Date: Fri, 03 Jul 2015 07:00:23 +0200 > > > tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should > > not exceed cb[] > > Please see sock_skb_cb, which consumes space in skb->cb[] in parallel > with t

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread David Miller
From: Lawrence Brakmo Date: Thu, 2 Jul 2015 18:21:24 -0700 > This is a request for comments. > > TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of > NV was presented at 2010's LPC (slides). It is a delayed based > congestion avoidance for the data center. This version has

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread David Miller
From: Eric Dumazet Date: Fri, 03 Jul 2015 07:00:23 +0200 > tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should > not exceed cb[] Please see sock_skb_cb, which consumes space in skb->cb[] in parallel with things like tcp_skb_cb. The usage of skb->cb[] therefore really is 48 b

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 18:21 -0700, Lawrence Brakmo wrote: > This is a request for comments. > > TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of > NV was presented at 2010's LPC (slides). It is a delayed based > congestion avoidance for the data center. This version has bee

[RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A descrip