Re: tbench regression in 2.6.25-rc1

2008-02-20 Thread Zhang, Yanmin
Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit b4ce92775c2e7ff9cf79cca4e0a19c

Re: tbench regression in 2.6.25-rc1

2008-02-20 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 20 Feb 2008 08:38:17 +0100 > Thanks very much Yanmin, I think we can apply your patch as is, if no > regression was found for 32bits. Great. Can I get a resubmission of the patch with a cleaned up changelog entry that describes in the regression

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Tue, 2008-02-19 at 08:40 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: I also think __refcnt is the key. I did a new testing by adding 2 unsig

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:40 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: > >> On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > >> > >>> I also think __refcnt is the key. I did a new testing by adding 2 > >>> unsign

Re: tbench regression in 2.6.25-rc1

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 08:35 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: > >> On Mon, 18 Feb 2008 16:12:38 +0800 > >> "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > >> > >>> On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: > >>>

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: I also think __refcnt is the key. I did a new testing by adding 2 unsigned long pading before lastuse, so the 3 members are moved to next cache line. Th

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: On Mon, 18 Feb 2008 16:12:38 +0800 "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 15 Feb 2008 15:21:48 +0100 On

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 12:33 -0500, [EMAIL PROTECTED] wrote: > On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > > > I also think __refcnt is the key. I did a new testing by adding 2 unsigned > > long > > pading before lastuse, so the 3 members are moved to next cache line. The > > per

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Mon, 2008-02-18 at 11:11 +0100, Eric Dumazet wrote: > On Mon, 18 Feb 2008 16:12:38 +0800 > "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > > > On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: > > > From: Eric Dumazet <[EMAIL PROTECTED]> > > > Date: Fri, 15 Feb 2008 15:21:48 +0100 > > > > >

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Valdis . Kletnieks
On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > I also think __refcnt is the key. I did a new testing by adding 2 unsigned > long > pading before lastuse, so the 3 members are moved to next cache line. The > performance is > recovered. > > How about below patch? Almost all performan

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Eric Dumazet
On Mon, 18 Feb 2008 16:12:38 +0800 "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: > > From: Eric Dumazet <[EMAIL PROTECTED]> > > Date: Fri, 15 Feb 2008 15:21:48 +0100 > > > > > On linux-2.6.25-rc1 x86_64 : > > > > > > offsetof(struct dst_entry

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 15:22 -0800, David Miller wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Fri, 15 Feb 2008 15:21:48 +0100 > > > On linux-2.6.25-rc1 x86_64 : > > > > offsetof(struct dst_entry, lastuse)=0xb0 > > offsetof(struct dst_entry, __refcnt)=0xb8 > > offsetof(struct dst_entry,

Re: tbench regression in 2.6.25-rc1

2008-02-17 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 15:21 +0100, Eric Dumazet wrote: > Zhang, Yanmin a écrit : > > On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: > > > >> Zhang, Yanmin a �crit : > >> > >>> Comparing with kernel 2.6.24, tbench result has regression with > >>> 2.6.25-rc1. > >>> > >>> 1) On 2 quad-

Re: tbench regression in 2.6.25-rc1

2008-02-15 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 15 Feb 2008 15:21:48 +0100 > On linux-2.6.25-rc1 x86_64 : > > offsetof(struct dst_entry, lastuse)=0xb0 > offsetof(struct dst_entry, __refcnt)=0xb8 > offsetof(struct dst_entry, __use)=0xbc > offsetof(struct dst_entry, next)=0xc0 > > So it should b

Re: tbench regression in 2.6.25-rc1

2008-02-15 Thread Eric Dumazet
Zhang, Yanmin a écrit : On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect loca

Re: tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: > Zhang, Yanmin a �crit : > > Comparing with kernel 2.6.24, tbench result has regression with > > 2.6.25-rc1. > > > > 1) On 2 quad-core processor stoakley: 4%. > > 2) On 4 quad-core processor tigerton: more than 30%. > > > > bisect located be

Re: tbench regression in 2.6.25-rc1

2008-02-14 Thread Eric Dumazet
Zhang, Yanmin a écrit : Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit b4c

tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit b4ce92775c2e7ff9cf79cca4e0a19