Re: take 3 [RFC] make qdisc_restart more readable

2007-05-12 Thread jamal
On Sat, 2007-12-05 at 19:02 +0200, Patrick McHardy wrote: > jamal wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > #define NETDEV_TX_LOCKED -1/* driver tx lock was already taken */ > > +#define NETDEV_TX_DROP -2 /* request caller to drop packet */ > > Th

Re: take 3 [RFC] make qdisc_restart more readable

2007-05-12 Thread Patrick McHardy
jamal wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index f671cd2..718d6fd 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -83,6 +83,9 @@ struct wireless_dev; > #define NETDEV_TX_OK 0 /* driver took care of packet */ >

take 3 [RFC] make qdisc_restart more readable

2007-05-12 Thread jamal
Ok, heres the next iteration based on feedback from Thomas and Peter. It seems this is good form in matching what the original code does. I have a few doubts in labelled as XXX in there. Thomas, if you have time, do you mind looking at those? The usual testing happened i.e "if you can see this em