Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:50:20PM -0500, David Miller wrote: > > > > Simple fix is below. Though, I don't understand the history of the > > > > multiple locks in this structure to be sure it's correct. I'll send > > > > it as a formal patch. Please reject if it's not the right approach.

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 16:47:34 -0500 > On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > > From: Craig Gallek > > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller > wrote: > > >> From: Craig Gallek > > >> Date

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
On Tue, Dec 22, 2015 at 04:42:25PM -0500, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > > > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > >> From: Craig Gallek > >> Date: Tue, 22 Dec 2015 15:51:19 -0500 > >> > >>> I was actually just looking

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:42 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 16:38:32 -0500 > >> On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >>> From: Craig Gallek >>> Date: Tue, 22 Dec 2015 15:51:19 -0500 >>> I was actually just looking at this as well (thou

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 16:38:32 -0500 > On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: >> From: Craig Gallek >> Date: Tue, 22 Dec 2015 15:51:19 -0500 >> >>> I was actually just looking at this as well (though a slightly >>> different stack). The issue is with: c6ff5268

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 4:28 PM, David Miller wrote: > From: Craig Gallek > Date: Tue, 22 Dec 2015 15:51:19 -0500 > >> I was actually just looking at this as well (though a slightly >> different stack). The issue is with: c6ff5268293e rhashtable: Fix >> walker list corruption >> >> It changed th

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Craig Gallek Date: Tue, 22 Dec 2015 15:51:19 -0500 > I was actually just looking at this as well (though a slightly > different stack). The issue is with: c6ff5268293e rhashtable: Fix > walker list corruption > > It changed the lock acquired in rhashtable_walk_init to use the new > spinlo

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Craig Gallek
On Tue, Dec 22, 2015 at 3:45 PM, Dave Jones wrote: > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other info that might help us debug th

Re: suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread David Miller
From: Dave Jones Date: Tue, 22 Dec 2015 15:45:39 -0500 > === > [ INFO: suspicious RCU usage. ] > 4.4.0-rc6-think+ #1 Not tainted > --- > lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! > > other info that might help us de

suspicious RCU usage (netlink/rhashtable)

2015-12-22 Thread Dave Jones
=== [ INFO: suspicious RCU usage. ] 4.4.0-rc6-think+ #1 Not tainted --- lib/rhashtable.c:522 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 0 2 locks held by t