Re: sungem triggers NAPI warning

2008-02-23 Thread Benjamin Herrenschmidt
On Sat, 2008-02-23 at 19:58 -0800, David Miller wrote: > From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > Date: Fri, 22 Feb 2008 09:50:27 +1100 > > > I still think the change is obviously correct, so I'll give a second > > close look at the code and produce a patch. > > Patch coming soon? :)

Re: sungem triggers NAPI warning

2008-02-23 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Fri, 22 Feb 2008 09:50:27 +1100 > I still think the change is obviously correct, so I'll give a second > close look at the code and produce a patch. Patch coming soon? :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: sungem triggers NAPI warning

2008-02-21 Thread Benjamin Herrenschmidt
On Thu, 2008-02-21 at 14:05 +0100, Johannes Berg wrote: > On Thu, 2008-02-21 at 13:54 +1100, Benjamin Herrenschmidt wrote: > > On Tue, 2008-02-19 at 22:38 +0100, Johannes Berg wrote: > > > I started getting this warning with recent kernels: > > > > Do that help ? > > > > In gem_poll(), do: > >

Re: sungem triggers NAPI warning

2008-02-21 Thread Johannes Berg
On Thu, 2008-02-21 at 13:54 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2008-02-19 at 22:38 +0100, Johannes Berg wrote: > > I started getting this warning with recent kernels: > > Do that help ? > > In gem_poll(), do: > > - work_done += gem_rx(gp, budget); > + work_done += gem_rx(gp, budge

Re: sungem triggers NAPI warning

2008-02-20 Thread Benjamin Herrenschmidt
On Tue, 2008-02-19 at 22:38 +0100, Johannes Berg wrote: > I started getting this warning with recent kernels: Do that help ? In gem_poll(), do: - work_done += gem_rx(gp, budget); + work_done += gem_rx(gp, budget - work_done); Cheers, Ben. > [ 773.908927] [ cut here ]---

sungem triggers NAPI warning

2008-02-20 Thread Johannes Berg
I started getting this warning with recent kernels: [ 773.908927] [ cut here ] [ 773.908954] Badness at net/core/dev.c:2204 [ 773.908958] NIP: c0277960 LR: c0277948 CTR: c02b9948 [ 773.908963] REGS: ee8f1800 TRAP: 0700 Not tainted (2.6.25-rc2-00261-g54a6132-dirty) [