> Agreed. Actually the checksum value is same hi/lo because there are
> two checksum units and we ask for the same offset on both.
Ok, that explains the (HLEN << 16) | HLEN thing when configuring it...
At this point, best is I dig into the actual values and see what's up.
I'll let you know (I don
On Wed, 06 Sep 2006 07:12:43 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > > Which means that if it worked on x86 with le16_to_cpu, it should work on
> > > powerpc... The main difference here however is that you called
> > > le16_to_cpu (which is basically a nop) on a 32 bits fiel
> > Which means that if it worked on x86 with le16_to_cpu, it should work on
> > powerpc... The main difference here however is that you called
> > le16_to_cpu (which is basically a nop) on a 32 bits field, while I
> > called le32_to_cpu() on it. But both should lead to the same ... (x86
> > will
Benjamin Herrenschmidt wrote:
On Mon, 2006-09-04 at 20:56 -0700, Stephen Hemminger wrote:
On Tue, 05 Sep 2006 13:42:38 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
Unneeded byte swap was occurring.
--- linu
On Mon, 2006-09-04 at 20:56 -0700, Stephen Hemminger wrote:
> On Tue, 05 Sep 2006 13:42:38 +1000
> Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
> > > Unneeded byte swap was occurring.
> > >
> > > --- linux-2.6.orig/drivers/net
On Tue, 05 Sep 2006 13:42:38 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
> > Unneeded byte swap was occurring.
> >
> > --- linux-2.6.orig/drivers/net/sky2.c
> > +++ linux-2.6/drivers/net/sky2.c
> > @@ -2001,7 +2001,7 @@ sta
On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote:
> Unneeded byte swap was occurring.
>
> --- linux-2.6.orig/drivers/net/sky2.c
> +++ linux-2.6/drivers/net/sky2.c
> @@ -2001,7 +2001,7 @@ static int sky2_status_intr(struct sky2_
> case OP_RXCHKS:
> skb
Unneeded byte swap was occurring.
--- linux-2.6.orig/drivers/net/sky2.c
+++ linux-2.6/drivers/net/sky2.c
@@ -2001,7 +2001,7 @@ static int sky2_status_intr(struct sky2_
case OP_RXCHKS:
skb = sky2->rx_ring[sky2->rx_next].skb;
skb->ip_su
Hi Stephen !
So I now have the driver working with the patches I gave you. However,
when I set it up with a 100bT link and transfer a huge file from another
machine (about 10MB/sec throughput), I get a few of these in dmesg
eth2: hw csum failure.
Call Trace:
[CFFEF8D0] [C000F460]
