Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-20 Thread Wolfgang Walter
Am Montag, 20. Juli 2015, 14:14:59 schrieb Herbert Xu: > On Fri, Jul 17, 2015 at 05:38:30PM +0200, Wolfgang Walter wrote: > > eth1 stops sending with the patch after some time > > disabling gro on eth0 helps > > disabling tso or gso on eth0 and/or eth1 or both does not help > > > > eth0 and eth1 a

Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-19 Thread Herbert Xu
On Fri, Jul 17, 2015 at 05:38:30PM +0200, Wolfgang Walter wrote: > > eth1 stops sending with the patch after some time > disabling gro on eth0 helps > disabling tso or gso on eth0 and/or eth1 or both does not help > > eth0 and eth1 are both intel I350. What does ethtool -k eth1 say? Can you conf

Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-17 Thread Wolfgang Walter
Am Freitag, 17. Juli 2015, 09:56:51 schrieb Herbert Xu: > On Thu, Jul 16, 2015 at 12:58:45PM +0200, Wolfgang Walter wrote: > > Am Donnerstag, 16. Juli 2015, 08:23:50 schrieb Herbert Xu: > > > On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > > > Yes. Switching TSO off and leaving

Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-16 Thread Herbert Xu
On Thu, Jul 16, 2015 at 12:58:45PM +0200, Wolfgang Walter wrote: > Am Donnerstag, 16. Juli 2015, 08:23:50 schrieb Herbert Xu: > > On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > > Yes. Switching TSO off and leaving GRO on works, too. > > > > OK, could you please try this patch

Re: sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-16 Thread Wolfgang Walter
Am Donnerstag, 16. Juli 2015, 08:23:50 schrieb Herbert Xu: > On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > Yes. Switching TSO off and leaving GRO on works, too. > > OK, could you please try this patch? Patch works here. Thanks, Wolfgang > > ---8<--- > We need to set the

sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-15 Thread Herbert Xu
On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > Yes. Switching TSO off and leaving GRO on works, too. OK, could you please try this patch? ---8<--- We need to set the SKB_GSO_SIT bit if we detect a 6-in-4 tunnel when doing GRO. Otherwise we may throw a packet at TSO hardware