Il giorno 29/gen/06, alle ore 20:36, Lennert Buytenhek ha scritto:
On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote:
+ if (wol->wolopts == 0) {
+ pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR,
&cfgpmcsr);
+ cfgpmcsr |= ~PME_EN;
"cfgpmcsr &
On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote:
> >>+/* Power management capabilities bits */
> >>+enum sis900_cfgpmc_register_bits {
> >>+ PMVER = 0x0007,
> >>+ DSI = 0x0010,
> >>+ PMESP = 0xf800
> >>+};
> >>+
> >>+enum sis900_pmesp_bits {
> >>+ PME_D0 = 0x1,
On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote:
> >>+ if (wol->wolopts == 0) {
> >>+ pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR,
> >>&cfgpmcsr);
> >>+ cfgpmcsr |= ~PME_EN;
> >
> >"cfgpmcsr &= ~PME_EN;" ?
>
> Since cfgpmcsr is initialized as 0 I don'
Il giorno 29/gen/06, alle ore 14:16, Lennert Buytenhek ha scritto:
I found some fishy-looking things while backporting sis900 wake-on-lan
support.
+ /* Detect Wake on Lan support */
+ ret = inl(CFGPMC & PMESP);
"ret = (inl(net_dev->base_addr + CFGPMC) & PMESP) >> 27;" ?
You're r
Il giorno 29/gen/06, alle ore 14:23, Lennert Buytenhek ha scritto:
One more thing:
I'm still checking the other mail, but this is easier, so I'll just
reply first...
@@ -33,6 +33,7 @@ enum sis900_registers {
rxcfg=0x34, //Receive Configuration Register
flctrl=0x38, //Flow Con
On Sun, Jan 29, 2006 at 02:16:00PM +0100, Lennert Buytenhek wrote:
> I found some fishy-looking things while backporting sis900 wake-on-lan
> support.
One more thing:
@@ -33,6 +33,7 @@ enum sis900_registers {
rxcfg=0x34, //Receive Configuration Register
flctrl=0x38, //Flow Contro
Hello!
I found some fishy-looking things while backporting sis900 wake-on-lan
support.
> + /* Detect Wake on Lan support */
> + ret = inl(CFGPMC & PMESP);
"ret = (inl(net_dev->base_addr + CFGPMC) & PMESP) >> 27;" ?
> + if (wol->wolopts == 0) {
> + pci_read_config_dwor
