Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-23 Thread Sergei Shtylyov
On 10/23/2015 12:17 AM, Sergei Shtylyov wrote: [...] If memory is not yet available when the controller is trying to use the invalid descriptor, the controller will see it and DMA will stop. That means leaving RACT=0 and that's what the driver is even doing... Hm, then I don't underst

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-22 Thread Sergei Shtylyov
Hello. On 10/21/2015 10:26 AM, Yasushi SHOJI wrote: Thank your for your reply. Not at all, I'm virtually a maintainer for that driver now, so trying to filter out the related mails even if I don't have time to read thru all the netdev mail. On 10/19/2015 06:01 PM, Yasushi SHOJI wrote:

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-21 Thread Yasushi SHOJI
Hi Sergei, Thank your for your reply. On Wed, 21 Oct 2015 05:48:01 +0900, Sergei Shtylyov wrote: > > On 10/19/2015 06:01 PM, Yasushi SHOJI wrote: > > > I'm not that familiar with this code base so I'm note including any > > patch yet. I appreciate if someone with insight in this code give a >

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-20 Thread Sergei Shtylyov
Hello. On 10/19/2015 06:01 PM, Yasushi SHOJI wrote: In a low memory situation with netdev_alloc_skb() failure, mdp->rx_skbuff[entry] can be left NULL, however, sh_eth_rx() seems to access it without checking NULL or not in the following code: skb = mdp->rx_skbuff[entry]

sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-19 Thread Yasushi SHOJI
Hi, In a low memory situation with netdev_alloc_skb() failure, mdp->rx_skbuff[entry] can be left NULL, however, sh_eth_rx() seems to access it without checking NULL or not in the following code: skb = mdp->rx_skbuff[entry]; mdp->rx_skbuff[entry] = N