Re: selftests/bpf doesn't compile

2019-01-04 Thread shuah
Hi Geert, On 1/4/19 10:16 AM, Geert Uytterhoeven wrote: Hi Shuah, CC kbuild, gpio On Thu, Sep 14, 2017 at 5:34 PM Shuah Khan wrote: bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make

Re: selftests/bpf doesn't compile

2019-01-04 Thread Geert Uytterhoeven
Hi Shuah, CC kbuild, gpio On Thu, Sep 14, 2017 at 5:34 PM Shuah Khan wrote: > bpf test depends on clang and fails to compile when > > -- > make -C tools/testing/selftests/bpf run_tests > > > make: clang: Command not found > Makefile:39: recipe

Re: selftests/bpf doesn't compile

2017-09-18 Thread Daniel Borkmann
On 09/16/2017 12:41 AM, Shuah Khan wrote: On 09/15/2017 12:48 PM, Daniel Borkmann wrote: On 09/15/2017 08:23 PM, Daniel Borkmann wrote: On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote:

Re: selftests/bpf doesn't compile

2017-09-15 Thread Shuah Khan
On 09/15/2017 12:48 PM, Daniel Borkmann wrote: > On 09/15/2017 08:23 PM, Daniel Borkmann wrote: >> On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: >>> On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote: > On Thu, Sep 14, 2017 at 09:33

Re: selftests/bpf doesn't compile

2017-09-15 Thread Shuah Khan
On 09/15/2017 12:14 PM, Alexei Starovoitov wrote: > On Fri, Sep 15, 2017 at 11:00:31AM -0600, Shuah Khan wrote: I could add a special target for bpf TARGET_BPF perhaps and exclude it from the run_test> >>> I'm not sure what was the motivation to exclude hotplug from default >>> testing,

Re: selftests/bpf doesn't compile

2017-09-15 Thread Daniel Borkmann
On 09/15/2017 08:23 PM, Daniel Borkmann wrote: On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote: On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: Is bpf test intended to be run

Re: selftests/bpf doesn't compile

2017-09-15 Thread Daniel Borkmann
On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote: On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: Is bpf test intended to be run in kselftest run? The clang dependency might no

Re: selftests/bpf doesn't compile

2017-09-15 Thread Alexei Starovoitov
On Fri, Sep 15, 2017 at 11:00:31AM -0600, Shuah Khan wrote: > >> I could add a special target for bpf TARGET_BPF perhaps and exclude it from > >> the run_test> > > I'm not sure what was the motivation to exclude hotplug from default > > testing, > > These are considered a bit more disruptive and

Re: selftests/bpf doesn't compile

2017-09-15 Thread Alexei Starovoitov
On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: > On 15/09/17 17:02, Alexei Starovoitov wrote: > > On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: > >> Is bpf test intended to be run in kselftest run? The clang dependency might > >> not be met on majority of the systems. Is

Re: selftests/bpf doesn't compile

2017-09-15 Thread Shuah Khan
On 09/15/2017 11:00 AM, Shuah Khan wrote: > On 09/15/2017 10:02 AM, Alexei Starovoitov wrote: >> On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >>> Hi Alexei and Daniel, >>> >>> bpf test depends on clang and fails to compile when >>> >>>

Re: selftests/bpf doesn't compile

2017-09-15 Thread Shuah Khan
On 09/15/2017 10:02 AM, Alexei Starovoitov wrote: > On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >> Hi Alexei and Daniel, >> >> bpf test depends on clang and fails to compile when >> >> -- >> make -C tools/testing/selftests/bpf run_

Re: selftests/bpf doesn't compile

2017-09-15 Thread Edward Cree
On 15/09/17 17:02, Alexei Starovoitov wrote: > On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >> Is bpf test intended to be run in kselftest run? The clang dependency might >> not be met on majority of the systems. Is this a hard dependency?? > It is a hard dependency and clang should

Re: selftests/bpf doesn't compile

2017-09-15 Thread Alexei Starovoitov
On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: > Hi Alexei and Daniel, > > bpf test depends on clang and fails to compile when > > -- > make -C tools/testing/selftests/bpf run_tests > > > make: clang: Command not found > Makefile:

selftests/bpf doesn't compile

2017-09-14 Thread Shuah Khan
Hi Alexei and Daniel, bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make: clang: Command not found Makefile:39: recipe for target '.linux-kselftest/tools/testing/selftests/bpf/test_pkt_ac