On 02.02.2018 14:34, Neil Horman wrote:
Patch looks good, but if you could please submit it with the proper title in a
separate thread so it gets davem's attention properly, I'd appreciate it.
Additional points if you update it to include the ipv6 fixes :)
Thanks, I'll send this patch properly.
On Thu, Feb 01, 2018 at 10:41:27PM +0200, Tommi Rantala wrote:
> 2018-02-01 21:23 GMT+02:00 Neil Horman :
> > No, I can't say I saw the patch on the list. Can you resend it?
>
> Here's the patch again, sending from gmail this time.
>
> The previous mail is now also at spinics, dunno what happene
On 02.02.2018 11:27, Tommi Rantala wrote:
> 2018-02-02 1:57 GMT+02:00 Alexey Kodanev :
>> For ipv6 part, shouldn't we release 'bdst' there if the previous address
>> match is better and we continue to the next iteration?
>
> Good catch!
>
On the second thought, I think, we should also check 'bds
2018-02-02 1:57 GMT+02:00 Alexey Kodanev :
> For ipv6 part, shouldn't we release 'bdst' there if the previous address
> match is better and we continue to the next iteration?
Good catch!
Didn't see that one.
Tommi
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 5d4c15b..a044096 100644
On 01.02.2018 21:02, Tommi Rantala wrote:
> 2018-01-31 19:51 GMT+02:00 Tommi Rantala :
>> On 31.01.2018 14:31, Neil Horman wrote:
>>>
>>> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
I think there's a problem in the dst refcounting in sctp_v4_get_dst()
There's
2018-02-01 21:23 GMT+02:00 Neil Horman :
> No, I can't say I saw the patch on the list. Can you resend it?
Here's the patch again, sending from gmail this time.
The previous mail is now also at spinics, dunno what happened.
https://www.spinics.net/lists/linux-sctp/msg07005.html
>From b94c037d2
On Thu, Feb 01, 2018 at 08:02:07PM +0200, Tommi Rantala wrote:
> 2018-01-31 19:51 GMT+02:00 Tommi Rantala :
> > On 31.01.2018 14:31, Neil Horman wrote:
> >>
> >> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
> >>>
> >>> I think there's a problem in the dst refcounting in sctp_v4_ge
2018-01-31 19:51 GMT+02:00 Tommi Rantala :
> On 31.01.2018 14:31, Neil Horman wrote:
>>
>> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
>>>
>>> I think there's a problem in the dst refcounting in sctp_v4_get_dst()
>>>
>>> There's a dst_entry struct that has >0 refcnt after running
On 31.01.2018 14:31, Neil Horman wrote:
On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
I think there's a problem in the dst refcounting in sctp_v4_get_dst()
There's a dst_entry struct that has >0 refcnt after running the testcase,
which makes it impossible to delete the loopback
On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote:
> On 30.01.2018 23:03, Neil Horman wrote:
> > On Tue, Jan 30, 2018 at 09:24:17PM +0200, Tommi Rantala wrote:
> > > On 30.01.2018 17:59, Neil Horman wrote:
> > > > On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
> > > > >
On 31.01.2018 11:42, Tommi Rantala wrote:
I think there's a problem in the dst refcounting in sctp_v4_get_dst()
There's a dst_entry struct that has >0 refcnt after running the
testcase, which makes it impossible to delete the loopback device, as
that dst is never freed.
I'll try to make a pa
On 30.01.2018 23:03, Neil Horman wrote:
On Tue, Jan 30, 2018 at 09:24:17PM +0200, Tommi Rantala wrote:
On 30.01.2018 17:59, Neil Horman wrote:
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
ip netns add TEST
ip netns exec TEST ip link set lo up
ip link add dummy0 type dummy
ip
On 31.01.2018 00:52, Marcelo Ricardo Leitner wrote:
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
Hi,
When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with
suitable arguments, the local loopback device in the netns is not getting
destroyed after deleting the net
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
> Hi,
>
> When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with
> suitable arguments, the local loopback device in the netns is not getting
> destroyed after deleting the netns.
>
...
>
> Based on a quick test, 4.14 a
On Tue, Jan 30, 2018 at 09:24:17PM +0200, Tommi Rantala wrote:
> On 30.01.2018 17:59, Neil Horman wrote:
> > On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
> > >
> > > ip netns add TEST
> > > ip netns exec TEST ip link set lo up
> > > ip link add dummy0 type dummy
> > > ip link add
On 30.01.2018 17:59, Neil Horman wrote:
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
ip netns add TEST
ip netns exec TEST ip link set lo up
ip link add dummy0 type dummy
ip link add dummy1 type dummy
ip link add dummy2 type dummy
ip link set dev dummy0 netns TEST
ip link set d
On Mon, Jan 29, 2018 at 05:55:45PM +0200, Tommi Rantala wrote:
> Hi,
>
> When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with
> suitable arguments, the local loopback device in the netns is not getting
> destroyed after deleting the netns.
>
> For example:
>
> ip netns add TEST
Hi,
When running sctp_test from lksctp-tools in netns in 4.4 and 4.9 with
suitable arguments, the local loopback device in the netns is not
getting destroyed after deleting the netns.
For example:
ip netns add TEST
ip netns exec TEST ip link set lo up
ip link add dummy0 type dummy
ip link ad
18 matches
Mail list logo
