Re: rtnl_lock() question

2019-09-05 Thread Rustad, Mark D
On Sep 4, 2019, at 4:23 PM, Saeed Mahameed wrote: some allocations require parameters that should remain valid and constant across the whole reconfiguration procedure such params.num_channels, so they must be done inside the lock. You could always check if those parameters have changed once u

Re: rtnl_lock() question

2019-09-04 Thread Saeed Mahameed
On Wed, 2019-09-04 at 09:38 -0700, Jonathan Lemon wrote: > On 4 Sep 2019, at 0:39, Eric Dumazet wrote: > > > On 9/3/19 11:55 PM, Jonathan Lemon wrote: > > > How appropriate is it to hold the rtnl_lock() across a sleepable > > > memory allocation? On one hand it's just a mutex, but it would > > >

Re: rtnl_lock() question

2019-09-04 Thread Jonathan Lemon
On 4 Sep 2019, at 0:39, Eric Dumazet wrote: On 9/3/19 11:55 PM, Jonathan Lemon wrote: How appropriate is it to hold the rtnl_lock() across a sleepable memory allocation? On one hand it's just a mutex, but it would seem like it could block quite a few things. Sure, all GFP_KERNEL allocations

Re: rtnl_lock() question

2019-09-04 Thread Eric Dumazet
On 9/3/19 11:55 PM, Jonathan Lemon wrote: > How appropriate is it to hold the rtnl_lock() across a sleepable > memory allocation? On one hand it's just a mutex, but it would > seem like it could block quite a few things. > Sure, all GFP_KERNEL allocations can sleep for quite a while. On the

rtnl_lock() question

2019-09-03 Thread Jonathan Lemon
How appropriate is it to hold the rtnl_lock() across a sleepable memory allocation? On one hand it's just a mutex, but it would seem like it could block quite a few things. -- Jonathan