From: Heiner Kallweit
Date: Sat, 15 Dec 2018 16:25:05 +0100
> Improve detection of spurious interrupts by checking against the
> interrupt mask as currently set in the chip.
>
> Signed-off-by: Heiner Kallweit
Applied, thanks Heiner.
On 15.12.2018 20:15, David Miller wrote:
> From: Heiner Kallweit
> Date: Sat, 15 Dec 2018 19:44:35 +0100
>
>> tp->irq_mask holds the chip-specific interrupt mask. It doesn't say
>> whether interrupts are enabled or not. rtl_get_events() reads via
>> PCI(e) anyway, so I was under the impression th
From: Heiner Kallweit
Date: Sat, 15 Dec 2018 19:44:35 +0100
> tp->irq_mask holds the chip-specific interrupt mask. It doesn't say
> whether interrupts are enabled or not. rtl_get_events() reads via
> PCI(e) anyway, so I was under the impression that one more PCI(e) read
> doesn't really matter.
>
On 15.12.2018 19:35, David Miller wrote:
> From: Heiner Kallweit
> Date: Sat, 15 Dec 2018 16:24:02 +0100
>
>> @@ -6405,8 +6405,9 @@ static irqreturn_t rtl8169_interrupt(int irq, void
>> *dev_instance)
>> {
>> struct rtl8169_private *tp = dev_instance;
>> u16 status = rtl_get_events(tp
From: Heiner Kallweit
Date: Sat, 15 Dec 2018 16:24:02 +0100
> @@ -6405,8 +6405,9 @@ static irqreturn_t rtl8169_interrupt(int irq, void
> *dev_instance)
> {
> struct rtl8169_private *tp = dev_instance;
> u16 status = rtl_get_events(tp);
> + u16 irq_mask = RTL_R16(tp, IntrMask);
>
Improve detection of spurious interrupts by checking against the
interrupt mask as currently set in the chip.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/driv
Improve detection of spurious interrupts by checking against the
interrupt mask as currently set in the chip.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/driv
