Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Code Soldier1
On Tue, Apr 18, 2017 at 5:47 PM, Eric Dumazet wrote: > > For the last time, do not top post on netdev. Sorry about that. > > On Tue, 2017-04-18 at 17:15 -0700, Code Soldier1 wrote: >> I am not suggesting that we do not do cache alignment. That is >> required for performance. I have gone through t

Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Eric Dumazet
For the last time, do not top post on netdev. On Tue, 2017-04-18 at 17:15 -0700, Code Soldier1 wrote: > I am not suggesting that we do not do cache alignment. That is > required for performance. I have gone through this exercise because I > need to add a field to sk_buff and I want to do that wit

Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Code Soldier1
I am not suggesting that we do not do cache alignment. That is required for performance. I have gone through this exercise because I need to add a field to sk_buff and I want to do that without causing any adverse effects. Now that we have discovered that there are 40 bytes that can be used withou

Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Eric Dumazet
Please do not top post on netdev On Tue, 2017-04-18 at 16:26 -0700, Code Soldier1 wrote: > Eric, > > This alignment flag is passed to the cache constructor and the > allocation is indeed cache aligned. However, since the allocated size > is not a multiple of the alignment, wont memory be wasted ?

Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Code Soldier1
Eric, This alignment flag is passed to the cache constructor and the allocation is indeed cache aligned. However, since the allocated size is not a multiple of the alignment, wont memory be wasted ?. We can get 40 extra bytes without any side effects since they are on the same cache line ? kmem_c

Re: question about size of sk_buff and skb_shared_info

2017-04-18 Thread Eric Dumazet
On Tue, 2017-04-18 at 10:34 -0700, Code Soldier1 wrote: > Hi Folks, > > I am sure there is a reason for the current sizes of these structures, > However the reason is not obvious to me. So please help me understand. > > Currently the size of sk_buff on an x86_64 system is 232 bytes -- Why > is th

question about size of sk_buff and skb_shared_info

2017-04-18 Thread Code Soldier1
Hi Folks, I am sure there is a reason for the current sizes of these structures, However the reason is not obvious to me. So please help me understand. Currently the size of sk_buff on an x86_64 system is 232 bytes -- Why is that. I expected it to be a multiple of 32/64 as they are the most commo