Re: pull-request: mac80211 2017-10-16

2017-10-17 Thread Jason A. Donenfeld
On Tue, Oct 17, 2017 at 7:46 AM, Johannes Berg wrote: > If it's not equal, you execute so much code > beneath, going to the driver etc., that I'd think this particular time > is in the noise. Usually presumptions like this get you in trouble when some crafty academic has a smart idea about that n

Re: pull-request: mac80211 2017-10-16

2017-10-16 Thread Johannes Berg
On Tue, 2017-10-17 at 01:30 +0200, Jason A. Donenfeld wrote: > Mobile phone right now, so not able to write patch, but you probably > should be using crypto_memneq for comparing those two keys, not > memcmp. I know that's a gut instinct, but I really don't see the point. If you actually get this

Re: pull-request: mac80211 2017-10-16

2017-10-16 Thread Jason A. Donenfeld
Mobile phone right now, so not able to write patch, but you probably should be using crypto_memneq for comparing those two keys, not memcmp. Jason

Re: pull-request: mac80211 2017-10-16

2017-10-16 Thread David Miller
From: Johannes Berg Date: Mon, 16 Oct 2017 15:46:17 +0200 > Here's a fix, for a small part of the "KRACK" announced today > (krackattacks.com). > > Please pull and let me know if there's any problem. Pulled.

pull-request: mac80211 2017-10-16

2017-10-16 Thread Johannes Berg
Hi Dave, Here's a fix, for a small part of the "KRACK" announced today (krackattacks.com). Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit c0576e3975084d4699b7bfef578613fb8e1144f6: net: call cgroup_sk_alloc() earlier in sk_clone_lock(