Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-03-05 Thread Guillaume Nault
On Sat, Mar 03, 2018 at 11:33:53AM +0200, Denys Fedoryshchenko wrote: > On 2018-03-02 19:43, Guillaume Nault wrote: > > Out of curiosity, did unit-cache really bring performance improvements > > on your workload? > On old kernels it definitely did, due local specifics (electricity outages) > i migh

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-03-03 Thread Denys Fedoryshchenko
On 2018-03-02 19:43, Guillaume Nault wrote: On Thu, Mar 01, 2018 at 10:07:05PM +0200, Denys Fedoryshchenko wrote: On 2018-03-01 22:01, Guillaume Nault wrote: > diff --git a/drivers/net/ppp/ppp_generic.c > b/drivers/net/ppp/ppp_generic.c > index 255a5def56e9..2acf4b0eabd1 100644 > --- a/drivers/n

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-03-02 Thread Guillaume Nault
On Thu, Mar 01, 2018 at 10:07:05PM +0200, Denys Fedoryshchenko wrote: > On 2018-03-01 22:01, Guillaume Nault wrote: > > diff --git a/drivers/net/ppp/ppp_generic.c > > b/drivers/net/ppp/ppp_generic.c > > index 255a5def56e9..2acf4b0eabd1 100644 > > --- a/drivers/net/ppp/ppp_generic.c > > +++ b/driver

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-03-01 Thread Denys Fedoryshchenko
On 2018-03-01 22:01, Guillaume Nault wrote: On Tue, Feb 27, 2018 at 07:56:27PM +0100, Guillaume Nault wrote: On Tue, Feb 27, 2018 at 12:58:55PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-23 12:07, Guillaume Nault wrote: > > On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wr

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-03-01 Thread Guillaume Nault
On Tue, Feb 27, 2018 at 07:56:27PM +0100, Guillaume Nault wrote: > On Tue, Feb 27, 2018 at 12:58:55PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-23 12:07, Guillaume Nault wrote: > > > On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: > > > > On 2018-02-23 11:38, Guillaume

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-27 Thread Guillaume Nault
On Tue, Feb 27, 2018 at 12:58:55PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-23 12:07, Guillaume Nault wrote: > > On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-23 11:38, Guillaume Nault wrote: > > > > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fed

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-27 Thread Guillaume Nault
On Thu, Feb 22, 2018 at 07:30:38PM +0100, Guillaume Nault wrote: > On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: > > For me it looks like pch->clist is not removed from the list ppp->channels > > when destroyed via ppp_release(). But I don't want to pretend I understand > > ppp logic.

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-27 Thread Denys Fedoryshchenko
On 2018-02-23 12:07, Guillaume Nault wrote: On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: On 2018-02-23 11:38, Guillaume Nault wrote: > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: > > I'm using accel-ppp that has unit-cache option, i guess for >

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-24 Thread Denys Fedoryshchenko
On 2018-02-23 12:07, Guillaume Nault wrote: On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: On 2018-02-23 11:38, Guillaume Nault wrote: > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: > > I'm using accel-ppp that has unit-cache option, i guess for >

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-23 Thread Denys Fedoryshchenko
On 2018-02-23 12:07, Guillaume Nault wrote: On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: On 2018-02-23 11:38, Guillaume Nault wrote: > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: > > I'm using accel-ppp that has unit-cache option, i guess for >

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-23 Thread Guillaume Nault
On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: > On 2018-02-23 11:38, Guillaume Nault wrote: > > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: > > > I'm using accel-ppp that has unit-cache option, i guess for > > > "reusing" ppp > > > interfaces (becau

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-23 Thread Denys Fedoryshchenko
On 2018-02-23 11:38, Guillaume Nault wrote: On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: I'm using accel-ppp that has unit-cache option, i guess for "reusing" ppp interfaces (because creating a lot of interfaces on BRAS with 8k users quite expensive). Maybe it is someh

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-23 Thread Guillaume Nault
On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys Fedoryshchenko wrote: > I'm using accel-ppp that has unit-cache option, i guess for "reusing" ppp > interfaces (because creating a lot of interfaces on BRAS with 8k users quite > expensive). > Maybe it is somehow related and can be that scenario causi

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Denys Fedoryshchenko
On 2018-02-22 20:30, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: >> On 2018-02-15 17:55, Guillaume Nault wrote: >> > On Thu, Fe

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: > On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault > wrote: > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > >> On 2018-02-15 17:55, Guillaume Nault wrote: > >> > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Sun, Feb 18, 2018 at 12:01:02PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-16 20:48, Guillaume Nault wrote: > > On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > > > As far as i can see there is only KASAN triggered again(and server > > > rebooted > > > shortly after t

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: > It seems even rebuilding seemingly stable version triggering crashes too > (but different ones) Different ones? The trace following your message looks very similar to your first KASAN report. Or are you refering to the lockup y

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Denys Fedoryshchenko
On 2018-02-21 20:55, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: It seems even rebuilding seemingly stable version triggering crashes too (but different ones) Different ones? The trace following your message looks very similar to your first KASA

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Cong Wang
On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: >> On 2018-02-15 17:55, Guillaume Nault wrote: >> > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: >> > > Here we go: >> > > >> > > [24558.92154

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Denys Fedoryshchenko
It seems even rebuilding seemingly stable version triggering crashes too (but different ones) Maybe it is coincidence, and bug reproducer appeared in network same time i decided to upgrade kernel, as it happened with xt_MSS(and that bug existed for years). Deleted quoting, i added more debug op

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-20 Thread Denys Fedoryshchenko
On 2018-02-16 20:48, Guillaume Nault wrote: On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:42, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > On Thu, Feb

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-18 Thread Denys Fedoryshchenko
On 2018-02-16 20:48, Guillaume Nault wrote: On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:42, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > On Thu, Feb

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-16 Thread Guillaume Nault
On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-15 21:42, Guillaume Nault wrote: > > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fed

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-16 Thread Denys Fedoryshchenko
On 2018-02-15 21:42, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:31, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 17:55, Guillaume Nault wrote: > > > On Thu, Feb

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Guillaume Nault
On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-15 21:31, Guillaume Nault wrote: > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-15 17:55, Guillaume Nault wrote: > > > > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fed

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Denys Fedoryshchenko
On 2018-02-15 21:31, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 17:55, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: > > Here we go: > > > > [24558.921549] > > =

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Guillaume Nault
On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-15 17:55, Guillaume Nault wrote: > > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: > > > Here we go: > > > > > > [24558.921549] > > > ===

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Guillaume Nault
On Wed, Feb 14, 2018 at 06:49:19PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-14 18:47, Guillaume Nault wrote: > > On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-14 18:07, Guillaume Nault wrote: > > > > On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fed

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Denys Fedoryshchenko
On 2018-02-15 17:55, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: Here we go: [24558.921549] == [24558.922167] BUG: KASAN: use-after-free in ppp_ioctl+0xa6a/0x1522 [ppp_generic]

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Guillaume Nault
On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: > Here we go: > > [24558.921549] > == > [24558.922167] BUG: KASAN: use-after-free in ppp_ioctl+0xa6a/0x1522 > [ppp_generic] > [24558.922776] Write of size 8 a

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-15 Thread Denys Fedoryshchenko
On 2018-02-14 19:25, Guillaume Nault wrote: On Wed, Feb 14, 2018 at 06:49:19PM +0200, Denys Fedoryshchenko wrote: On 2018-02-14 18:47, Guillaume Nault wrote: > On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-14 18:07, Guillaume Nault wrote: > > > On Wed, Feb

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Guillaume Nault
On Wed, Feb 14, 2018 at 06:49:19PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-14 18:47, Guillaume Nault wrote: > > On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-14 18:07, Guillaume Nault wrote: > > > > On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fed

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Denys Fedoryshchenko
On 2018-02-14 18:47, Guillaume Nault wrote: On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: On 2018-02-14 18:07, Guillaume Nault wrote: > On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote: > > Hi, > > > > Upgraded kernel to 4.15.3, still it crashes after

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Guillaume Nault
On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-14 18:07, Guillaume Nault wrote: > > On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote: > > > Hi, > > > > > > Upgraded kernel to 4.15.3, still it crashes after while (several > > > hours, > > > ca

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Denys Fedoryshchenko
On 2018-02-14 18:07, Guillaume Nault wrote: On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote: Hi, Upgraded kernel to 4.15.3, still it crashes after while (several hours, cannot do bisect, as it is production server). dev ppp # gdb ppp_generic.o GNU gdb (Gentoo 7.12.1 vani

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Guillaume Nault
On Wed, Feb 14, 2018 at 03:17:23PM +0200, Denys Fedoryshchenko wrote: > Hi, > > Upgraded kernel to 4.15.3, still it crashes after while (several hours, > cannot do bisect, as it is production server). > > dev ppp # gdb ppp_generic.o > GNU gdb (Gentoo 7.12.1 vanilla) 7.12.1 > <> > Reading symbols

ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-14 Thread Denys Fedoryshchenko
Hi, Upgraded kernel to 4.15.3, still it crashes after while (several hours, cannot do bisect, as it is production server). dev ppp # gdb ppp_generic.o GNU gdb (Gentoo 7.12.1 vanilla) 7.12.1 <> Reading symbols from ppp_generic.o...done. (gdb) list *ppp_push+0x73 0x681 is in ppp_push (drivers/ne