>> v3: change us to ns in docs
>> v2: Review comments from Jesper
>>
>> CC: Jesper Dangaard Brouer
>
> Did a quick review and everything looks okay.
> The patches are already applied, but you will still get my ACK,
> even-though it will not make it to the commit log.
>
> Acked-by: Jesper Danga
On Thu, 11 Mar 2021 11:32:51 +0100
Igor Russkikh wrote:
> Hello netdev community,
>
> Please consider small improvements to pktgen scripts we use in our
> environment.
>
> Adding delay parameter through command line,
> Adding new -a (append) parameter to make flex runs
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 11 Mar 2021 11:32:51 +0100 you wrote:
> Hello netdev community,
>
> Please consider small improvements to pktgen scripts we use in our
> environment.
>
> Adding delay parameter through comm
To configure various complex flows we for sure can create custom
pktgen init scripts, but sometimes thats not that easy.
New "-a" (append) option in all the existing sample scripts allows
to append more "devices" into pktgen threads.
The most straightforward usecases f
Hello netdev community,
Please consider small improvements to pktgen scripts we use in our environment.
Adding delay parameter through command line,
Adding new -a (append) parameter to make flex runs
v3: change us to ns in docs
v2: Review comments from Jesper
CC: Jesper Dangaard Brouer
Igor
DELAY may now be explicitly specified via common parameter -w
Signed-off-by: Igor Russkikh
---
samples/pktgen/README.rst | 1 +
samples/pktgen/parameters.sh | 10 +-
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
From: Di Zhu
[ Upstream commit 275b1e88cabb34dbcbe99756b67e9939d34a99b6 ]
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and
fix.
Also remember that you made similar mistake in next patch.
When adding documentation in samples/pktgen/README.rst.
Strictly speaking, the doc update for DELAY belongs in patch-1.
> One extra thing I wanted to raise is "set -o errexit" in functions.sh.
> It basically contradicts
>> +echo " -w : (\$DELAY) Tx Delay value (us)"
>This is not in "us" it is in "ns" (nanosec). (Like I pointed out last time...)
Ah, sorry lost that. Will fix.
One extra thing I wanted to raise is "set -o errexit" in functions.sh.
It basically contradicts with the usecase I'm using (doing
On Thu, 11 Feb 2021 16:56:25 +0100
Igor Russkikh wrote:
> diff --git a/samples/pktgen/parameters.sh b/samples/pktgen/parameters.sh
> index ff0ed474fee9..70cc2878d479 100644
> --- a/samples/pktgen/parameters.sh
> +++ b/samples/pktgen/parameters.sh
> @@ -19,12 +19,13 @@
DELAY may now be explicitly specified via common parameter -w
Signed-off-by: Igor Russkikh
---
samples/pktgen/parameters.sh | 10 +-
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3 ---
samples/pktgen/pktgen_bench_xmit_mode_queue_xmit.sh| 3
To configure various complex flows we for sure can create custom
pktgen init scripts, but sometimes thats not that easy.
New "-a" (append) option in all the existing sample scripts allows
to append more "devices" into pktgen threads.
The most straightforward usecases f
Hello netdev community,
Please consider small improvements to pktgen scripts we use in our environment.
Adding delay parameter through command line,
Adding new -a (append) parameter to make flex runs
v2: Review comments from Jesper
CC: Jesper Dangaard Brouer
Igor Russkikh (2):
samples
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 25 Jan 2021 20:42:29 +0800 you wrote:
> From: Di Zhu
>
> pktgen create threads for all online cpus and bond these threads to
> relevant cpu repecivtily. when this thread firstly be woken up, it
> w
Hi Jesper,
Thanks for reviewing this.
>> DELAY may now be explicitly specified via common parameter -w
>
> What are you actually using this for?
Basically, for the second patch.
When running multidev pktgen (using that -a option) with large amount of clones
and
bursts (-c and -b
On Fri, 22 Jan 2021 16:05:17 +0100
Igor Russkikh wrote:
> To configure various complex flows we for sure can create custom
> pktgen init scripts, but sometimes thats not that easy.
>
> New "-a" (append) option in all the existing sample scripts allows
> to append m
, it will use the
"delay" variable.
> Signed-off-by: Igor Russkikh
> ---
> samples/pktgen/parameters.sh | 10 +-
> samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3 ---
> samples/pktgen/pktgen_bench_xmit_mode_queue
From: Di Zhu
pktgen create threads for all online cpus and bond these threads to
relevant cpu repecivtily. when this thread firstly be woken up, it
will compare cpu currently running with the cpu specified at the time
of creation and if the two cpus are not equal, BUG_ON() will take effect
Hello netdev community,
Please consider small improvements to pktgen scripts we use in our environment.
Adding delay parameter through command line,
Adding new -a (append) parameter to make flex runs
Igor Russkikh (2):
samples: pktgen: allow to specify delay parameter via new opt
samples
To configure various complex flows we for sure can create custom
pktgen init scripts, but sometimes thats not that easy.
New "-a" (append) option in all the existing sample scripts allows
to append more "devices" into pktgen threads.
The most straightforward usecases f
DELAY may now be explicitly specified via common parameter -w
Signed-off-by: Igor Russkikh
---
samples/pktgen/parameters.sh | 10 +-
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3 ---
samples/pktgen/pktgen_bench_xmit_mode_queue_xmit.sh| 3
From: Ye Bin
Date: Wed, 30 Sep 2020 09:08:37 +0800
> Fix follow warnings:
> [net/core/pktgen.c:925]: (warning) %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> [net/core/pktgen.c:942]: (warning) %u in format string (no. 1)
> requires 'unsi
Fix follow warnings:
[net/core/pktgen.c:925]: (warning) %u in format string (no. 1)
requires 'unsigned int' but the argument type is 'signed int'.
[net/core/pktgen.c:942]: (warning) %u in format string (no. 1)
requires 'unsigned int' but the argument type is 'signed int'.
[net/core/
From: Leesoo Ahn
Date: Tue, 1 Sep 2020 22:04:47 +0900
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
>
> Signed-off-by: Leesoo Ahn
Applied with Fixes: tag added.
On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
>
> Signed-off-by: Leesoo Ahn
You might need to add the following tag:
Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")
Acked-by: Gust
Error on calling kthread_create_on_node prints wrong function name,
kernel_thread.
Signed-off-by: Leesoo Ahn
---
net/core/pktgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 95f4c6b8f51a..44fdbb9c6e53 100644
--- a/net/core/pktg
From: "Daniel T. Lee"
Date: Sat, 5 Oct 2019 17:25:05 +0900
> Currently, pktgen script supports specify destination port range.
>
> To further extend the capabilities, this commit allows to specify destination
> IP range with CIDR when running pktgen script.
>
> Spe
and 'pg_set'.
> > >
> > > This commit fixes this logic by grep-ing the "Result:" string only when
> > > the command is not for 'pg_ctrl'.
> > >
> > > For clarity of an execution flow, 'errexit' flag has been set.
> > &
md is designed to check command result with grep the
> > "Result:", but this might fail since this string is only shown in
> > 'pg_thread' and 'pg_set'.
> >
> > This commit fixes this logic by grep-ing the "Result:" string only when
> >
On Sat, 5 Oct 2019 17:25:09 +0900
"Daniel T. Lee" wrote:
> Currently, kernel pktgen has the feature to specify destination
> address range for sending packet. (e.g. pgset "dst_min/dst_max")
>
> But on samples, each pktgen script doesn't have any option t
will be used in prior to set target address in samples/pktgen.
>
> Signed-off-by: Daniel T. Lee
Acked-by: Jesper Dangaard Brouer
> ---
> Changes since v3:
> * Set errexit option to stop script execution on error
>
> Changes since v4:
> * Set errexit option mov
t fail since this string is only shown in
> 'pg_thread' and 'pg_set'.
>
> This commit fixes this logic by grep-ing the "Result:" string only when
> the command is not for 'pg_ctrl'.
>
> For clarity of an execution flow, 'errexit&
On Sat, 5 Oct 2019 17:25:06 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
From: "Daniel T. Lee"
Date: Sat, 5 Oct 2019 17:25:05 +0900
> Currently, pktgen script supports specify destination port range.
>
> To further extend the capabilities, this commit allows to specify destination
> IP range with CIDR when running pktgen script.
>
> Spe
#x27;.
This commit fixes this logic by grep-ing the "Result:" string only when
the command is not for 'pg_ctrl'.
For clarity of an execution flow, 'errexit' flag has been set.
To cleanup pktgen on exit, trap has been added for EXIT signal.
Signed-off-by: Daniel T. Le
existing variable name DST_MIN should be changed.
Variable names are matched to the exact keyword used with pg_ctrl.
Signed-off-by: Daniel T. Lee
---
.../pktgen_bench_xmit_mode_netif_receive.sh | 8
.../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh | 8
samples/pk
This commit adds CIDR parsing and IP validate helper function to parse
single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
Validating the address should be preceded prior to the parsing.
Helpers will be used in prior to set target address in samples/pktgen.
Signed-off-by: Daniel T. Lee
Currently, kernel pktgen has the feature to specify destination
address range for sending packet. (e.g. pgset "dst_min/dst_max")
But on samples, each pktgen script doesn't have any option to achieve this.
This commit adds the feature to specify the destination address range wit
Currently, pktgen script supports specify destination port range.
To further extend the capabilities, this commit allows to specify destination
IP range with CIDR when running pktgen script.
Specifying destination IP range will be useful on various situation such as
testing RSS/RPS with
> @@ -105,6 +109,8 @@ function pgset() {
> > fi
> > }
> >
> > +trap 'pg_ctrl "reset"' EXIT
> > +
>
> This line is activated when I ctrl-C the scripts, but something weird
> happens, it reports:
>
> ERROR: proc file:/proc/net
"Daniel T. Lee" writes:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> wrote:
>
>>
>> On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
>> wrote:
>>
>> > [...]
>>
>>
> Thanks for the review!
>
>
>> A general comment, you forgot a cover letter for your patchset.
>>
>>
> At first, I t
On Fri, Oct 4, 2019 at 10:41 PM Jesper Dangaard Brouer
wrote:
>
> On Fri, 4 Oct 2019 22:28:26 +0900
> "Daniel T. Lee" wrote:
>
> > On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> > wrote:
> > >
> > >
> > > On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> > > wrote:
> > >
> > > > [
On Fri, 4 Oct 2019 22:28:26 +0900
"Daniel T. Lee" wrote:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer
> wrote:
> >
> >
> > On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> > wrote:
> >
> > > [...]
> >
>
> Thanks for the review!
>
> > A general comment, you forgot a cove
On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer wrote:
>
>
> On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
> wrote:
>
> > [...]
>
Thanks for the review!
> A general comment, you forgot a cover letter for your patchset.
>
At first, I thought the size of the patchset (the feature to
t fail since this string is only shown in
> 'pg_thread' and 'pg_set'.
>
> This commit fixes this logic by grep-ing the "Result:" string only when
> the command is not for 'pg_ctrl'.
>
> For clarity of an execution flow, 'errexit&
On Fri, 4 Oct 2019 10:32:58 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee"
wrote:
> [...]
A general comment, you forgot a cover letter for your patchset.
And also forgot the "PATCH" part of subj. but patchwork still found it:
https://patchwork.ozlabs.org/project/netdev/list/?series=134102&state=2a
--
Best regard
his commit fixes this logic by grep-ing the "Result:" string only when
the command is not for 'pg_ctrl'.
For clarity of an execution flow, 'errexit' flag has been set.
To cleanup pktgen on exit, trap has been added for EXIT signal.
Signed-off-by: Daniel T. Lee
---
existing variable name DST_MIN should be changed.
Variable names are matched to the exact keyword used with pg_ctrl.
Signed-off-by: Daniel T. Lee
---
.../pktgen_bench_xmit_mode_netif_receive.sh | 8
.../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh | 8
samples/pk
This commit adds CIDR parsing and IP validate helper function to parse
single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
Validating the address should be preceded prior to the parsing.
Helpers will be used in prior to set target address in samples/pktgen.
Signed-off-by: Daniel T. Lee
Currently, kernel pktgen has the feature to specify destination
address range for sending packet. (e.g. pgset "dst_min/dst_max")
But on samples, each pktgen script doesn't have any option to achieve this.
This commit adds the feature to specify the destination address range wit
x27; and 'pktgen_thread'. So I thought just changing to below diff
will solve the problem.
diff --git a/samples/pktgen/functions.sh b/samples/pktgen/functions.sh
index 87ae61701904..38cf9f62502f 100644
--- a/samples/pktgen/functions.sh
+++ b/samples/pktgen/functions.sh
@@ -60,6 +60,7 @
l be used in prior to set target address in samples/pktgen.
>>
>> Signed-off-by: Daniel T. Lee
>> ---
>> Changes since v3:
>> * Set errexit option to stop script execution on error
>>
>> samples/pktgen/functions.sh | 124 ++++
On Sun, 15 Sep 2019 00:13:52 +0900
"Daniel T. Lee" wrote:
> This commit adds CIDR parsing and IP validate helper function to parse
> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
>
> Helpers will be used in prior to set target address in samples/pktgen.
>
Currently, kernel pktgen has the feature to specify destination
address range for sending packet. (e.g. pgset "dst_min/dst_max")
But on samples, each of the scripts doesn't have any option to achieve this.
This commit adds the feature to specify the destination address range wit
This commit adds CIDR parsing and IP validate helper function to parse
single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
Helpers will be used in prior to set target address in samples/pktgen.
Signed-off-by: Daniel T. Lee
---
Changes since v3:
* Set errexit option to stop script
existing variable name DST_MIN should be changed.
Variable names are matched to the exact keyword used with pg_ctrl.
Signed-off-by: Daniel T. Lee
---
.../pktgen_bench_xmit_mode_netif_receive.sh | 8
.../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh | 8
samples/pk
5)
> >
> > Helpers will be used in prior to set target address in samples/pktgen.
> >
> > Signed-off-by: Daniel T. Lee
> > ---
> > samples/pktgen/functions.sh | 122 ++++
> > 1 file changed, 122 insertions(+)
> >
&g
On Fri, Sep 13, 2019 at 9:37 PM Toke Høiland-Jørgensen wrote:
>
> Jesper Dangaard Brouer writes:
>
> > On Thu, 12 Sep 2019 03:48:07 +0900
> > "Daniel T. Lee" wrote:
> >
> >> diff --git a/samples/pktgen/pktgen_sample01_simple.sh
> >>
On Thu, 12 Sep 2019 03:48:06 +0900
"Daniel T. Lee" wrote:
> This commit adds CIDR parsing and IP validate helper function to parse
> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
>
> Helpers will be used in prior to set target address in samples/pktgen.
>
Jesper Dangaard Brouer writes:
> On Thu, 12 Sep 2019 03:48:07 +0900
> "Daniel T. Lee" wrote:
>
>> diff --git a/samples/pktgen/pktgen_sample01_simple.sh
>> b/samples/pktgen/pktgen_sample01_simple.sh
>> index 063ec0998906..08995fa70025 100755
>> ---
On Fri, 13 Sep 2019 02:53:26 +0900
"Daniel T. Lee" wrote:
> On Fri, Sep 13, 2019 at 12:59 AM Jesper Dangaard Brouer
> wrote:
> >
> > On Thu, 12 Sep 2019 03:48:06 +0900
> > "Daniel T. Lee" wrote:
> >
> > > This commit adds CIDR parsing and IP validate helper function to parse
> > > single IP
On Thu, 12 Sep 2019 03:48:07 +0900
"Daniel T. Lee" wrote:
> diff --git a/samples/pktgen/pktgen_sample01_simple.sh
> b/samples/pktgen/pktgen_sample01_simple.sh
> index 063ec0998906..08995fa70025 100755
> --- a/samples/pktgen/pktgen_sample01_simple.sh
On Thu, 12 Sep 2019 03:48:05 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
On Fri, Sep 13, 2019 at 12:59 AM Jesper Dangaard Brouer
wrote:
>
> On Thu, 12 Sep 2019 03:48:06 +0900
> "Daniel T. Lee" wrote:
>
> > This commit adds CIDR parsing and IP validate helper function to parse
> > single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
>
> One question: You do know th
On Thu, 12 Sep 2019 03:48:06 +0900
"Daniel T. Lee" wrote:
> This commit adds CIDR parsing and IP validate helper function to parse
> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
One question: You do know that this expansion of the CIDR will also
include the CIDR network broadcast IP
existing variable name DST_MIN should be changed.
Variable names are matched to the exact keyword used with pg_ctrl.
Signed-off-by: Daniel T. Lee
---
.../pktgen_bench_xmit_mode_netif_receive.sh | 8
.../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh | 8
samples/pk
This commit adds CIDR parsing and IP validate helper function to parse
single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
Helpers will be used in prior to set target address in samples/pktgen.
Signed-off-by: Daniel T. Lee
---
samples/pktgen/functions.sh | 122
Currently, kernel pktgen has the feature to specify destination
address range for sending packet. (e.g. pgset "dst_min/dst_max")
But on samples, each of the scripts doesn't have any option to achieve this.
This commit adds the feature to specify the destination address range wit
5)
> >
> > Helpers will be used in prior to set target address in samples/pktgen.
> >
> > Signed-off-by: Daniel T. Lee
> > ---
> > samples/pktgen/functions.sh | 134 ++++
> > 1 file changed, 134 insertions(+)
> >
&g
On Thu, 29 Aug 2019 05:42:42 +0900
"Daniel T. Lee" wrote:
> This commit adds CIDR parsing and IP validate helper function to parse
> single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
>
> Helpers will be used in prior to set target address in samples/pktgen.
>
On Thu, 29 Aug 2019 05:42:41 +0900
"Daniel T. Lee" wrote:
> This commit changes variable names that can cause confusion.
>
> For example, variable DST_MIN is quite confusing since the
> keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl.
>
> On the following commit, 'dst_min' will
Currently, kernel pktgen has the feature to specify destination
address range for sending packet. (e.g. pgset "dst_min/dst_max")
But on samples, each of them doesn't have any option to achieve this.
The commit adds feature to specify destination address range with CIDR.
existing variable name DST_MIN should be changed.
Variable names are matched to the exact keyword used with pg_ctrl.
Signed-off-by: Daniel T. Lee
---
.../pktgen_bench_xmit_mode_netif_receive.sh | 8
.../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh | 8
samples/pk
This commit adds CIDR parsing and IP validate helper function to parse
single IP or range of IP with CIDR. (e.g. 198.18.0.0/15)
Helpers will be used in prior to set target address in samples/pktgen.
Signed-off-by: Daniel T. Lee
---
samples/pktgen/functions.sh | 134
9 22:33:58 +0900
> "Daniel T. Lee" wrote:
>
> > Currently, kernel pktgen has the feature to specify udp destination port
> > for sending packet. (e.g. pgset "udp_dst_min 9")
> >
> > But on samples, each of the scripts doesn't have any option to ac
From: "Daniel T. Lee"
Date: Sat, 29 Jun 2019 22:33:57 +0900
> This commit adds port parsing and port validate helper function to parse
> single or range of port(s) from a given string. (e.g. 1234, 443-444)
>
> Helpers will be used in prior to set target port(s) in sampl
From: "Daniel T. Lee"
Date: Sat, 29 Jun 2019 22:33:58 +0900
> Currently, kernel pktgen has the feature to specify udp destination port
> for sending packet. (e.g. pgset "udp_dst_min 9")
>
> But on samples, each of the scripts doesn't have any option to ac
On Sat, 29 Jun 2019 22:33:58 +0900
"Daniel T. Lee" wrote:
> Currently, kernel pktgen has the feature to specify udp destination port
> for sending packet. (e.g. pgset "udp_dst_min 9")
>
> But on samples, each of the scripts doesn't have any option to ac
On Sat, 29 Jun 2019 22:33:57 +0900
"Daniel T. Lee" wrote:
> This commit adds port parsing and port validate helper function to parse
> single or range of port(s) from a given string. (e.g. 1234, 443-444)
>
> Helpers will be used in prior to set target port(s) in samples/p
This commit adds port parsing and port validate helper function to parse
single or range of port(s) from a given string. (e.g. 1234, 443-444)
Helpers will be used in prior to set target port(s) in samples/pktgen.
Signed-off-by: Daniel T. Lee
---
samples/pktgen/functions.sh | 34
Currently, kernel pktgen has the feature to specify udp destination port
for sending packet. (e.g. pgset "udp_dst_min 9")
But on samples, each of the scripts doesn't have any option to achieve this.
This commit adds the DST_PORT option to specify the target port(s) in the
From: Paolo Abeni
Date: Thu, 6 Jun 2019 15:45:03 +0200
> Currently, the process issuing a "start" command on the pktgen procfs
> interface, acquires the pktgen thread lock and never release it, until
> all pktgen threads are completed. The above can blocks indefinitely
Currently, the process issuing a "start" command on the pktgen procfs
interface, acquires the pktgen thread lock and never release it, until
all pktgen threads are completed. The above can blocks indefinitely any
other pktgen command and any (even unrelated) netdevice removal - as
_for_each_entry(tmp, &pn->pktgen_threads, th_list)
> > + if (tmp == t)
> > + return true;
> > + return false;
> > +}
>
> Pointer equality is not object equality.
Indeed. The trick is that pktgen threads are allocated only at net
creation time.
struct pktgen_net *pn, struct pktgen_thread
> *t)
> +{
> + struct pktgen_thread *tmp;
> +
> + list_for_each_entry(tmp, &pn->pktgen_threads, th_list)
> + if (tmp == t)
> + return true;
> + return false;
> +}
Pointer equali
Currently, the process issuing a "start" command on the pktgen procfs
interface, acquires the pktgen thread lock and never release it, until
all pktgen threads are completed. The above can blocks indefinitely any
other pktgen command and any (even unrelated) netdevice removal - as
From: "Gustavo A. R. Silva"
Date: Thu, 13 Sep 2018 14:03:20 -0500
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva
Applied.
From: Jakub Kicinski
Date: Tue, 17 Jul 2018 14:32:24 -0700
> GCC 8 complains:
>
> net/core/pktgen.c: In function ‘pktgen_if_write’:
> net/core/pktgen.c:1419:4: warning: ‘strncpy’ output may be truncated copying
> between 0 and 31 bytes from a string of length 127 [-Wstringop-truncation]
> s
GCC 8 complains:
net/core/pktgen.c: In function ‘pktgen_if_write’:
net/core/pktgen.c:1419:4: warning: ‘strncpy’ output may be truncated copying
between 0 and 31 bytes from a string of length 127 [-Wstringop-truncation]
strncpy(pkt_dev->src_max, buf, len);
^
From: "Gustavo A. R. Silva"
Date: Wed, 14 Mar 2018 03:07:27 -0500
> _buf_ is an array and the one that must be freed is _tp_ instead.
>
> Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer")
> Reported-by: Wang Jian
> Signed-of
On Wed, Mar 14, 2018 at 9:07 AM, Gustavo A. R. Silva
wrote:
> _buf_ is an array and the one that must be freed is _tp_ instead.
>
> Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer")
> Reported-by: Wang Jian
> Signed-off-by: Gustavo A.
ed.
Fixes: 35951393bbff ("pktgen: Remove VLA usage")
Signed-off-by: Arnd Bergmann
Applied, thanks.
_buf_ is an array and the one that must be freed is _tp_ instead.
Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer")
Reported-by: Wang Jian
Signed-off-by: Gustavo A. R. Silva
---
net/core/pktgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
1 - 100 of 492 matches
Mail list logo
