Re: phy: micrel.c: Support ksz9031 energy-detect power-down mode

2018-02-27 Thread Andrew Lunn
On Tue, Feb 27, 2018 at 05:09:45PM +0300, Maxim Uvarov wrote: > CC netdev > > 2018-02-27 13:12 GMT+03:00 Maxim Uvarov : > > It migth be reason to reconsider of unconditionally enable power-down mode. > > v1 of patch and code here: > > https://lkml.org/lkml/2016/10/3/199 > > > > I see that 9031 jus

Re: phy: micrel.c: Support ksz9031 energy-detect power-down mode

2018-02-27 Thread Maxim Uvarov
CC netdev 2018-02-27 13:12 GMT+03:00 Maxim Uvarov : > It migth be reason to reconsider of unconditionally enable power-down mode. > v1 of patch and code here: > https://lkml.org/lkml/2016/10/3/199 > > I see that 9031 just lock ups with start from -40C just after > swtiching to power save mode. And

Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Mike Looijmans
On 03-10-16 16:35, Andrew Lunn wrote: +Boolean: + + - enable-edpd : Not related to timing. Specify this property to enable + energy-detect power-down mode in the PHY. The Broadcom PHYs unconditionally enable this feature. The SMSC driver has an option: smsc,disabl

Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Andrew Lunn
> +Boolean: > + > + - enable-edpd : Not related to timing. Specify this property to enable > + energy-detect power-down mode in the PHY. The Broadcom PHYs unconditionally enable this feature. The SMSC driver has an option: smsc,disable-energy-detect because it seems

[PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Mike Looijmans
Set bit 0 in register 1C.23 to enable the EDPD feature of the KSZ9031 PHY. This reduces power consumption when the link is down. To use this, set "enable-edpd" in the devicetree. Signed-off-by: Mike Looijmans --- .../devicetree/bindings/net/micrel-ksz90x1.txt| 6 ++ drivers/net/phy/