Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Jon Mason
On Thu, Jan 12, 2006 at 02:23:20PM -0800, Don Fry wrote: > There are just a few differences between the 2.4 (1.30h) version of > pcnet32.c and the 2.6 (1.30j) version, as I have tried to keep them > as similar as possible. > > The driver was changed in February 2004 to recognize the incorrect > ve

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Don Fry
There are just a few differences between the 2.4 (1.30h) version of pcnet32.c and the 2.6 (1.30j) version, as I have tried to keep them as similar as possible. The driver was changed in February 2004 to recognize the incorrect vendor ID so that the ppc workaround was no longer required, and so tha

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Bill Nottingham
Bill Nottingham ([EMAIL PROTECTED]) said: > I remember looking at this a while back. I think the corrected information > is only being propagated to the 'vendor' file, and the write_config_word > isn't actually updating the 'config' entry in sysfs. Ah, here's an example from the box I remember wo

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Bill Nottingham
Matthew Wilcox ([EMAIL PROTECTED]) said: > On Thu, Jan 12, 2006 at 01:57:14PM -0700, Matthew Wilcox wrote: > > On Thu, Jan 12, 2006 at 08:49:42PM +, Daniel Drake wrote: > > > interesting: > > > > > > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html > > > > > > The user saw

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Lennart Sorensen
On Thu, Jan 12, 2006 at 08:49:42PM +, Daniel Drake wrote: > On the subject of pcnet32 and the invalid vendor ID, you may find this > interesting: > > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html > > The user saw the correct vendor ID (AMD) in 2.4, but when upgrading to

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Matthew Wilcox
On Thu, Jan 12, 2006 at 01:57:14PM -0700, Matthew Wilcox wrote: > On Thu, Jan 12, 2006 at 08:49:42PM +, Daniel Drake wrote: > > interesting: > > > > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html > > > > The user saw the correct vendor ID (AMD) in 2.4, but when upgrading t

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Daniel Drake
Matthew Wilcox wrote: It looks to me like there used to be a quirk that knew about this bug and fixed it. The reason I say this is that the lspci -x dumps are the same -- both featuring the wrong vendor ID. Good catch. I didn't notice this. > Want to dig through 2.4 and look for this quirk?

Re: pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Matthew Wilcox
On Thu, Jan 12, 2006 at 08:49:42PM +, Daniel Drake wrote: > interesting: > > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html > > The user saw the correct vendor ID (AMD) in 2.4, but when upgrading to > 2.6, it changed to Trident. It looks to me like there used to be a qui

pcnet32 devices with incorrect trident vendor ID

2006-01-12 Thread Daniel Drake
Jon Mason wrote: Some pcnet32 hardware erroneously has the Vendor ID for Trident. The pcnet32 driver looks for the PCI ethernet class before grabbing the hardware, but the current trident driver does not check against the PCI audio class. This allows the trident driver to claim the pcnet32 har