Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-08 Thread Geoff Lansberry
On Tue, Jan 3, 2017 at 4:21 PM, Mark Greer wrote: > On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: >> On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: >> > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> >> In the meantime - here is some more info about h

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: > On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> In the meantime - here is some more info about how we use it. > >> > >> We do use NFC structures.I di

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Geoff Lansberry
On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > [Please stop top-posting. Bottom-post only to these lists.] Sorry; gmail keeps baiting me to do it... > > Hi Geoff & happy new year. > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: >> Mark - I will split this off soon. >

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
[Please stop top-posting. Bottom-post only to these lists.] Hi Geoff & happy new year. On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > Mark - I will split this off soon. OK > In the meantime - here is some more info about how we use it. > > We do use NFC structures.I di

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-27 Thread Geoff Lansberry
Mark - I will split this off soon. In the meantime - here is some more info about how we use it. We do use NFC structures.I did find an interesting clue in that there are certain bottles that cause neard to segfault, I'm not sure what is different about them. We write a string, like "coppol

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-24 Thread Mark Greer
On Sat, Dec 24, 2016 at 11:17:18AM -0500, Geoff Lansberry wrote: > Mark - I'm sorry, but I did not write this code, and therefore was not > able to accurately describe it. It is fixing a different issue, not > the neard segfault that we are still chasing. Last week Jaret Cantu > sent a separate e

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-24 Thread Geoff Lansberry
Mark - I'm sorry, but I did not write this code, and therefore was not able to accurately describe it. It is fixing a different issue, not the neard segfault that we are still chasing. Last week Jaret Cantu sent a separate email explaining the purpose of the code, which had you copied, did you se

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-23 Thread Mark Greer
On Wed, Dec 21, 2016 at 11:18:34PM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a command before it has finished

[PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-21 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the state of the trf7970a is currently reading but another request has been made to send a command before it has finished. The solution is to properly kill the waiting reading (workqueue) before

Re: nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 02:13:52PM -0500, Justin Bronder wrote: > On 20/12/16 11:59 -0700, Mark Greer wrote: > > On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > > > From: Jaret Cantu > > > > > > Repeated polling attempts cause a NULL dereference error to occur. > > > This is be

Re: nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Justin Bronder
On 20/12/16 11:59 -0700, Mark Greer wrote: > On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > > From: Jaret Cantu > > > > Repeated polling attempts cause a NULL dereference error to occur. > > This is because the state of the trf7970a is currently reading but > > another request

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a command before it has finished

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the state of the trf7970a is currently reading but another request has been made to send a command before it has finished. The solution is to properly kill the waiting reading (workqueue) before

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the state of the trf7970a is currently reading but another request has been made to send a command before it has finished. The solution is to properly kill the waiting reading (workqueue) before

[PATCH 2/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the state of the trf7970a is currently reading but another request has been made to send a command before it has finished. The solution is to properly kill the waiting reading (workqueue) before

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-15 Thread Mark Greer
On Thu, Dec 15, 2016 at 05:30:44PM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the curent state of the trf7970a is reading but > a request has been made to send a command. > > The solution is to proper

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-15 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the curent state of the trf7970a is reading but a request has been made to send a command. The solution is to properly kill the waiting reading (workqueue) before failing on the send. --- driver