Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Stephen Hemminger wrote: On Wed, 13 Sep 2006 21:04:02 -0500 Larry Finger <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: Simple. Reading the code of synchronize_net() and netif_stop_queue() and thinking about why

Re: netdev tx timeouts

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 21:04:02 -0500 Larry Finger <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Wed, 13 Sep 2006 15:49:23 +0200 > > Michael Buesch <[EMAIL PROTECTED]> wrote: > >> Simple. Reading the code of synchronize_net() and > >> netif_stop_queue() and thinking about why it breaks

Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Stephen Hemminger wrote: On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: Simple. Reading the code of synchronize_net() and netif_stop_queue() and thinking about why it breaks, instead of committing bugfixes that only substitute one bug by another. ;) I'll take a look

Re: netdev tx timeouts

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > On Wednesday 13 September 2006 15:25, Larry Finger wrote: > > Michael Buesch wrote: > > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > > >> Michael, > > >> > > >> I still have not gotten a network guru to

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 15:49, Michael Buesch wrote: > On Wednesday 13 September 2006 15:25, Larry Finger wrote: > > Michael Buesch wrote: > > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > > >> Michael, > > >> > > >> I still have not gotten a network guru to answer any questi

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 15:25, Larry Finger wrote: > Michael Buesch wrote: > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > >> Michael, > >> > >> I still have not gotten a network guru to answer any questions about > >> synchronize_net, but I have been testing the patch below

Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Michael Buesch wrote: On Wednesday 13 September 2006 04:25, Larry Finger wrote: Michael, I still have not gotten a network guru to answer any questions about synchronize_net, but I have been testing the patch below: I'd say this is racy. Did you test this on SMP? No - I don't have the hard

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 04:25, Larry Finger wrote: > Michael, > > I still have not gotten a network guru to answer any questions about > synchronize_net, but I have been testing the patch below: I'd say this is racy. Did you test this on SMP? > Index: wireless-2.6/drivers/net/wireless/bc

netdev tx timeouts

2006-09-12 Thread Larry Finger
Michael, I still have not gotten a network guru to answer any questions about synchronize_net, but I have been testing the patch below: Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c === --- wireless-2.6.orig/driv