Re: net-2.6.24 breaks powerpc mysteriously

2007-10-13 Thread David Miller
From: Denys Vlasenko <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 04:40:46 +0100 > Please find updated patch in attachment. > Compile-tested. We fixed this several days ago already. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-13 Thread Denys Vlasenko
On Friday 12 October 2007 05:09, Paul Mackerras wrote: > > I supposed a hacky fix is to add __KERNEL__ ifdef protection around > > zlib_inflate_blob() and those troublesome includes. A nicer fix is > > That would do, but I don't see why zlib_inflate_blob had to be added > to inflate.c rather than

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-13 Thread Denys Vlasenko
On Friday 12 October 2007 03:45, David Miller wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 19:22:33 -0700 > > > With net-2.6.24 (pulled yesterday) applied: > > > > g5:/usr/src/25> ml arch/powerpc/boot/inflate.o > > Using ARCH=powerpc CROSS_COMPILE= > > CHK inc

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
David Miller writes: > Here is the patch I'm putting through some paces, let me know if > it solves the powerpc problem. Looks fine to me. Acked-by: Paul Mackerras <[EMAIL PROTECTED]> Thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 21:54:29 -0700 (PDT) > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Thu, 11 Oct 2007 21:25:39 -0700 > > > On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > > > So Andrew, what do you think is better

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 21:25:39 -0700 > On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > So Andrew, what do you think is better - arch/powerpc/boot having its > > own copies of the zlib_inflate stuff, or #ifdefs of some kin

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Andrew Morton
On Fri, 12 Oct 2007 13:52:14 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > So Andrew, what do you think is better - arch/powerpc/boot having its > own copies of the zlib_inflate stuff, or #ifdefs of some kind in > lib/zlib_inflate/*.c? The latter - copying code is evil. Keeping the existing

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
Andrew Morton writes: > arch/powerpc/boot/inflate.c:920:19: errno.h: No such file or directory > arch/powerpc/boot/inflate.c:921:18: slab.h: No such file or directory > arch/powerpc/boot/inflate.c:922:21: vmalloc.h: No such file or directory We used to have our own copies of inflate.c etc. for th

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Paul Mackerras
David Miller writes: > The only thing we touched in zlib is in the patch below. > > I suspect the lib/zlib_inflate/inflate.c changes, I had no idea that > some pieces of code try to use this into userspace. Not userspace; the zImage wrapper uses inflate.c to gunzip the compressed kernel image.

Re: net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 11 Oct 2007 19:22:33 -0700 > With net-2.6.24 (pulled yesterday) applied: > > g5:/usr/src/25> ml arch/powerpc/boot/inflate.o > Using ARCH=powerpc CROSS_COMPILE= > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CALL

net-2.6.24 breaks powerpc mysteriously

2007-10-11 Thread Andrew Morton
With net-2.6.24 (pulled yesterday) applied: g5:/usr/src/25> ml arch/powerpc/boot/inflate.o Using ARCH=powerpc CROSS_COMPILE= CHK include/linux/version.h CHK include/linux/utsrelease.h CALLscripts/checksyscalls.sh BOOTCC arch/powerpc/boot/inflate.o arch/powerpc/boot/inflate.c