Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Vicente Bergas
On Monday, May 13, 2019 3:01:33 PM CEST, Serge Semin wrote: On Mon, May 13, 2019 at 02:51:03PM +0200, Andrew Lunn wrote: Ahh, I see. Then using lock-less version of the access methods must fix the problem. You could try something like this: Kunihiko Hayash is way ahead of you. Andre

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Serge Semin
On Mon, May 13, 2019 at 02:51:03PM +0200, Andrew Lunn wrote: > > Ahh, I see. Then using lock-less version of the access methods must fix the > > problem. You could try something like this: > > Kunihiko Hayash is way ahead of you. > >Andrew I wouldn't say that five hours is "way ahead". B

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Andrew Lunn
> Ahh, I see. Then using lock-less version of the access methods must fix the > problem. You could try something like this: Kunihiko Hayash is way ahead of you. Andrew

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Serge Semin
Hello, On Mon, May 13, 2019 at 02:19:17PM +0200, Vicente Bergas wrote: > On Monday, May 13, 2019 12:51:05 PM CEST, Serge Semin wrote: > > On Mon, May 13, 2019 at 01:29:42PM +0300, Serge Semin wrote: > > > Hello Vincente, > > > > > > On Sat, May 11, 2019 at 05:06:04PM +0200, Vicente Bergas wrote:

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Vicente Bergas
On Monday, May 13, 2019 12:51:05 PM CEST, Serge Semin wrote: On Mon, May 13, 2019 at 01:29:42PM +0300, Serge Semin wrote: Hello Vincente, On Sat, May 11, 2019 at 05:06:04PM +0200, Vicente Bergas wrote: ... Hmm, just figured out, that in the datasheet RXDLY/TXDLY pins are actually grounded, s

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Serge Semin
On Mon, May 13, 2019 at 01:29:42PM +0300, Serge Semin wrote: > Hello Vincente, > > On Sat, May 11, 2019 at 05:06:04PM +0200, Vicente Bergas wrote: > > On Saturday, May 11, 2019 4:56:56 PM CEST, Heiner Kallweit wrote: > > > On 11.05.2019 16:46, Vicente Bergas wrote: > > > > On Friday, May 10, 2019

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Serge Semin
Hello Vincente, On Sat, May 11, 2019 at 05:06:04PM +0200, Vicente Bergas wrote: > On Saturday, May 11, 2019 4:56:56 PM CEST, Heiner Kallweit wrote: > > On 11.05.2019 16:46, Vicente Bergas wrote: > > > On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: > > > > On 10.05.2019 17:05, Vic

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-13 Thread Serge Semin
Hello Heiner and net-folks, On Sat, May 11, 2019 at 04:56:56PM +0200, Heiner Kallweit wrote: > On 11.05.2019 16:46, Vicente Bergas wrote: > > On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: > >> On 10.05.2019 17:05, Vicente Bergas wrote: > >>> Hello, > >>> there is a regression on

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Andrew Lunn
> Hi Andrew, > it is configured as in the vanilla kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi#n191 > ,that is, > phy-mode = "rgmii"; > There are also these configuration items: > tx_delay = <0x28>; > rx_delay =

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Vicente Bergas
On Saturday, May 11, 2019 5:08:19 PM CEST, Andrew Lunn wrote: On Sat, May 11, 2019 at 04:46:40PM +0200, Vicente Bergas wrote: On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: On 10.05.2019 17:05, Vicente Bergas wrote: Hello, there is a regression on linux v5.1-9573-gb970afcfcab

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Andrew Lunn
On Sat, May 11, 2019 at 04:46:40PM +0200, Vicente Bergas wrote: > On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: > >On 10.05.2019 17:05, Vicente Bergas wrote: > >>Hello, > >>there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null > >>pointer dereference. > >>The

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Vicente Bergas
On Saturday, May 11, 2019 4:56:56 PM CEST, Heiner Kallweit wrote: On 11.05.2019 16:46, Vicente Bergas wrote: On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: On 10.05.2019 17:05, Vicente Bergas wrote: ... Hello Heiner, just tried your patch and indeed the NPE is gone. But stil

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Heiner Kallweit
On 11.05.2019 16:46, Vicente Bergas wrote: > On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: >> On 10.05.2019 17:05, Vicente Bergas wrote: >>> Hello, >>> there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null >>> pointer dereference. >>> The issue is the commit f

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-11 Thread Vicente Bergas
On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: On 10.05.2019 17:05, Vicente Bergas wrote: Hello, there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null pointer dereference. The issue is the commit f81dadbcf7fd067baf184b63c179fc392bdb226e net: phy: realtek: A

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-10 Thread Vicente Bergas
On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote: On 10.05.2019 17:05, Vicente Bergas wrote: Hello, there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null pointer dereference. The issue is the commit f81dadbcf7fd067baf184b63c179fc392bdb226e net: phy: realtek: A

Re: net: phy: realtek: regression, kernel null pointer dereference

2019-05-10 Thread Russell King - ARM Linux admin
On Fri, May 10, 2019 at 05:05:13PM +0200, Vicente Bergas wrote: > Hello, > there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null > pointer dereference. > The issue is the commit f81dadbcf7fd067baf184b63c179fc392bdb226e > net: phy: realtek: Add rtl8211e rx/tx delays config > whi