Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-11-01 Thread Andrey Konovalov
Hi Cong, Yes, your patches fix the warnings. Tested-by: Andrey Konovalov Thanks! On Mon, Oct 31, 2016 at 7:40 PM, Eric Dumazet wrote: > On Mon, 2016-10-31 at 11:00 -0700, Cong Wang wrote: >> On Sun, Oct 30, 2016 at 6:20 AM, Eric Dumazet wrote: >> > On Sun, 2016-10-30 at 05:41 +0100, Andrey K

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 11:00 -0700, Cong Wang wrote: > On Sun, Oct 30, 2016 at 6:20 AM, Eric Dumazet wrote: > > On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: > >> Sorry, the warning is still there. > >> > >> I'm not sure adding sched_annotate_sleep() does anything, since it's > >> defi

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-31 Thread Cong Wang
On Sun, Oct 30, 2016 at 6:20 AM, Eric Dumazet wrote: > On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: >> Sorry, the warning is still there. >> >> I'm not sure adding sched_annotate_sleep() does anything, since it's >> defined as (in case CONFIG_DEBUG_ATOMIC_SLEEP is not set): >> # defi

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-30 Thread Eric Dumazet
On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: > Sorry, the warning is still there. > > I'm not sure adding sched_annotate_sleep() does anything, since it's > defined as (in case CONFIG_DEBUG_ATOMIC_SLEEP is not set): > # define sched_annotate_sleep() do { } while (0) Thanks again for

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-29 Thread Andrey Konovalov
Sorry, the warning is still there. I'm not sure adding sched_annotate_sleep() does anything, since it's defined as (in case CONFIG_DEBUG_ATOMIC_SLEEP is not set): # define sched_annotate_sleep() do { } while (0) On Sat, Oct 29, 2016 at 8:05 PM, Eric Dumazet wrote: > On Sat, 2016-10-29 at 19:59 +

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-29 Thread Eric Dumazet
On Sat, 2016-10-29 at 19:59 +0200, Andrey Konovalov wrote: > Hi Eric, > > Tested with both patches applied, still seeing the warning. > > Thanks! Arg, sorry, this was at the wrong place. Thanks for testing ! diff --git a/net/dccp/output.c b/net/dccp/output.c index b66c84db0766..2548edff86ff 10

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-29 Thread Andrey Konovalov
Hi Eric, Tested with both patches applied, still seeing the warning. Thanks! On Sat, Oct 29, 2016 at 7:43 PM, Eric Dumazet wrote: > On Sat, 2016-10-29 at 19:06 +0200, Andrey Konovalov wrote: >> Hi Cong, >> >> Tested with your patch, still getting a warning, though it's a little >> different: >

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-29 Thread Eric Dumazet
On Sat, 2016-10-29 at 19:06 +0200, Andrey Konovalov wrote: > Hi Cong, > > Tested with your patch, still getting a warning, though it's a little > different: > > [ cut here ] > WARNING: CPU: 1 PID: 3876 at kernel/sched/core.c:7724 > __might_sleep+0x14c/0x1a0 kernel/sched/c

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-29 Thread Andrey Konovalov
Hi Cong, Tested with your patch, still getting a warning, though it's a little different: [ cut here ] WARNING: CPU: 1 PID: 3876 at kernel/sched/core.c:7724 __might_sleep+0x14c/0x1a0 kernel/sched/core.c:7719 do not call blocking ops when !TASK_RUNNING; state=1 set at [] pr

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-28 Thread Cong Wang
On Fri, Oct 28, 2016 at 5:40 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while running the syzkaller fuzzer: > > [ cut here ] > WARNING: CPU: 0 PID: 4608 at kernel/sched/core.c:7724 > __might_sleep+0x14c/0x1a0 kernel/sched/core.c:7719 > do not

net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-28 Thread Andrey Konovalov
Hi, I've got the following error report while running the syzkaller fuzzer: [ cut here ] WARNING: CPU: 0 PID: 4608 at kernel/sched/core.c:7724 __might_sleep+0x14c/0x1a0 kernel/sched/core.c:7719 do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+