Re: net/atm: warning in alloc_tx/__might_sleep

2017-03-14 Thread Chas Williams
On Mon, 2017-03-13 at 18:43 +0100, Andrey Konovalov wrote: > On Thu, Jan 12, 2017 at 11:40 AM, Chas Williams <3ch...@gmail.com> wrote: > > On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: > >> On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > >> > On Wed 11-01-17 20:45:25, Michal Hocko wr

Re: net/atm: warning in alloc_tx/__might_sleep

2017-03-13 Thread Andrey Konovalov
On Thu, Jan 12, 2017 at 11:40 AM, Chas Williams <3ch...@gmail.com> wrote: > On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: >> On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: >> > On Wed 11-01-17 20:45:25, Michal Hocko wrote: >> >> On Wed 11-01-17 09:37:06, Chas Williams wrote: >> >> > O

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-12 Thread Chas Williams
On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: > On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > > On Wed 11-01-17 20:45:25, Michal Hocko wrote: > >> On Wed 11-01-17 09:37:06, Chas Williams wrote: > >> > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > >> > > Hi! > >> > >

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Cong Wang
On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: > On Wed 11-01-17 20:45:25, Michal Hocko wrote: >> On Wed 11-01-17 09:37:06, Chas Williams wrote: >> > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: >> > > Hi! >> > > >> > > I've got the following error report while running the syz

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Michal Hocko
On Wed 11-01-17 20:45:25, Michal Hocko wrote: > On Wed 11-01-17 09:37:06, Chas Williams wrote: > > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > > > Hi! > > > > > > I've got the following error report while running the syzkaller fuzzer. > > > > > > On commit a121103c922847ba5010819

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Michal Hocko
On Wed 11-01-17 09:37:06, Chas Williams wrote: > On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > > Hi! > > > > I've got the following error report while running the syzkaller fuzzer. > > > > On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). > > > > A reproducer is attac

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Eric Dumazet
On Tue, 2017-01-10 at 23:47 +0100, Francois Romieu wrote: > Eric Dumazet : > > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: > > > On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov > > > wrote: > > > > > > The fix should be straight-forward. Mind to try the attached patch? > > > > > > You

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Chas Williams
On Mon, 2017-01-09 at 18:20 +0100, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). > > A reproducer is attached. > > [ cut here ] > WARNING: CPU:

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-11 Thread Andrey Konovalov
On Tue, Jan 10, 2017 at 6:40 PM, Eric Dumazet wrote: > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: >> On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov >> wrote: >> >> The fix should be straight-forward. Mind to try the attached patch? Hi Cong, Your patch with schedule() removed as sugge

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-10 Thread Francois Romieu
Eric Dumazet : > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: > > On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov > > wrote: > > > > The fix should be straight-forward. Mind to try the attached patch? > > > You forgot to remove schedule() ? It may be clearer to split alloc_tx in two pa

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-10 Thread Cong Wang
On Tue, Jan 10, 2017 at 9:40 AM, Eric Dumazet wrote: > On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: >> On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov >> wrote: >> >> The fix should be straight-forward. Mind to try the attached patch? > > > You forgot to remove schedule() ? > > schedule

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-10 Thread Eric Dumazet
On Tue, Jan 10, 2017 at 9:35 AM, Cong Wang wrote: > On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov > wrote: > > The fix should be straight-forward. Mind to try the attached patch? You forgot to remove schedule() ? schedule(); + wait_woken(&wait, TASK_INTERRUPTIBLE, MAX_SCHEDULE_TIMEOUT);

Re: net/atm: warning in alloc_tx/__might_sleep

2017-01-10 Thread Cong Wang
On Mon, Jan 9, 2017 at 9:20 AM, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). > > A reproducer is attached. > > [ cut here ] > WARNING: CPU: 0 PID:

net/atm: warning in alloc_tx/__might_sleep

2017-01-09 Thread Andrey Konovalov
Hi! I've got the following error report while running the syzkaller fuzzer. On commit a121103c922847ba5010819a3f250f1f7fc84ab8 (4.10-rc3). A reproducer is attached. [ cut here ] WARNING: CPU: 0 PID: 4114 at kernel/sched/core.c:7737 __might_sleep+0x149/0x1a0 do not call b