Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API

2016-03-10 Thread Doug Ledford
On 03/08/2016 09:38 AM, Dominique Martinet wrote: > Christoph Hellwig wrote on Thu, Mar 03, 2016: >> New version with the nits fixed below. Now that checkpath started >> a stupid warning about not using tabs for indentation which I've >> ignored here and will take up in my usual fights against Joe

Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API

2016-03-08 Thread Dominique Martinet
Christoph Hellwig wrote on Thu, Mar 03, 2016: > New version with the nits fixed below. Now that checkpath started > a stupid warning about not using tabs for indentation which I've > ignored here and will take up in my usual fights against Joes > idicotic opinions separately.. Thanks for the nitp

Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API

2016-03-03 Thread Christoph Hellwig
00:00:00 2001 From: Christoph Hellwig Date: Sat, 27 Feb 2016 10:22:40 +0100 Subject: net/9p: convert to new CQ API Trivial conversion to the new RDMA CQ API. Signed-off-by: Christoph Hellwig --- net/9p/trans_rdma.c | 86 +++-- 1 file changed, 31 in

Re: [PATCH] net/9p: convert to new CQ API

2016-02-28 Thread Christoph Hellwig
On Sun, Feb 28, 2016 at 01:03:47PM +0200, Sagi Grimberg wrote: > >> Trivial conversion to the new RDMA CQ API. > > Looks nice and simple :) > > But I think that the fact that CQ processing is now > done in soft-IRQ (which is an improvement!) needs to > be documented. Yeah, I meant to do that, but

Re: [PATCH] net/9p: convert to new CQ API

2016-02-28 Thread Sagi Grimberg
Trivial conversion to the new RDMA CQ API. Looks nice and simple :) But I think that the fact that CQ processing is now done in soft-IRQ (which is an improvement!) needs to be documented. Other than that, looks great Reviewed-by: Sagi Grimberg P.S. I was also confused in the past about 9p

Re: [V9fs-developer] [PATCH] net/9p: convert to new CQ API

2016-02-27 Thread Dominique Martinet
Hi, Couple of checkpatch complains: Christoph Hellwig wrote on Sat, Feb 27, 2016: > -struct p9_rdma_context { > - enum ib_wc_opcode wc_op; > +struct p9_rdma_context { trailing tab > - p9_debug(P9_DEBUG_ERROR, "req %p err %d status %d\n", req, err, status); > + p9_debug(P9_DEBUG

net/9p: convert to new CQ API

2016-02-27 Thread Christoph Hellwig
Hi all, who is maintaining the "RDMA transport" (1) for 9p? Below patch converts it to your new CQ API. It's fairly trivial, but untested as I can't figure out how to actually test this code. [1] RDMA seems a bit of a misowner as it's never doing RDMA data transfers, but that's a separate story

[PATCH] net/9p: convert to new CQ API

2016-02-27 Thread Christoph Hellwig
Trivial conversion to the new RDMA CQ API. Signed-off-by: Christoph Hellwig --- net/9p/trans_rdma.c | 87 +++-- 1 file changed, 31 insertions(+), 56 deletions(-) diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 52b4a2f..668c3be 100644