Re: mlxsw and rtnl lock

2017-08-29 Thread Arkadi Sharshevsky
On 08/29/2017 11:04 PM, David Ahern wrote: > On 8/29/17 12:10 AM, Arkadi Sharshevsky wrote: >> >> >> On 08/28/2017 09:00 PM, David Ahern wrote: >>> On 8/26/17 11:04 AM, Ido Schimmel wrote: Regarding the silent abort, that's intentional. You can look at the same code in v4.9 - when the c

Re: mlxsw and rtnl lock

2017-08-29 Thread David Ahern
On 8/29/17 12:10 AM, Arkadi Sharshevsky wrote: > > > On 08/28/2017 09:00 PM, David Ahern wrote: >> On 8/26/17 11:04 AM, Ido Schimmel wrote: >>> Regarding the silent abort, that's intentional. You can look at the same >>> code in v4.9 - when the chain was still blocking - and you'll see that >>> w

Re: mlxsw and rtnl lock

2017-08-29 Thread Arkadi Sharshevsky
On 08/28/2017 09:00 PM, David Ahern wrote: > On 8/26/17 11:04 AM, Ido Schimmel wrote: >> Regarding the silent abort, that's intentional. You can look at the same >> code in v4.9 - when the chain was still blocking - and you'll see that >> we didn't propagate the error even then. This was discusse

Re: mlxsw and rtnl lock

2017-08-28 Thread Arkadi Sharshevsky
On 08/28/2017 09:00 PM, David Ahern wrote: > On 8/26/17 11:04 AM, Ido Schimmel wrote: >> Regarding the silent abort, that's intentional. You can look at the same >> code in v4.9 - when the chain was still blocking - and you'll see that >> we didn't propagate the error even then. This was discusse

Re: mlxsw and rtnl lock

2017-08-28 Thread David Ahern
On 8/26/17 11:04 AM, Ido Schimmel wrote: > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and you'll see that > we didn't propagate the error even then. This was discussed in the past > and the conclusion was that user d

Re: mlxsw and rtnl lock

2017-08-28 Thread Roopa Prabhu
On Sat, Aug 26, 2017 at 10:04 AM, Ido Schimmel wrote: > On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: >> Jiri / Ido: >> >> [snip] > > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and you'll see that > w

Re: mlxsw and rtnl lock

2017-08-26 Thread Ido Schimmel
On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: > Jiri / Ido: > > I was looking at the mlxsw driver and the places it holds the rtnl lock. > There are a lot of them and from an admittedly short review it seems > like the rtnl is protecting changes to mlxsw data structures as opposed >

mlxsw and rtnl lock

2017-08-25 Thread David Ahern
Jiri / Ido: I was looking at the mlxsw driver and the places it holds the rtnl lock. There are a lot of them and from an admittedly short review it seems like the rtnl is protecting changes to mlxsw data structures as opposed to calling into the core networking stack. This is going to have huge im