Re: loopback device reference count leakage

2017-02-09 Thread Kaiwen Xu
I am using macvlan device inside the container. With following Docker network plugin: https://github.com/gopher-net/macvlan-docker-plugin Each macvlan device, which gets assigned into the container network namespace, is attached to host's vlan device, which is then attached to host's eth0. e

Re: loopback device reference count leakage

2017-02-08 Thread Cong Wang
On Mon, Feb 6, 2017 at 6:32 PM, Kaiwen Xu wrote: > Hi Cong, > > I did some more testing, seems like your second assumption is correct. > There is indeed some things holding the references to a particular dst > which preventing it to be gc'ed. Excellent! > > I added logging to each dst_hold (or d

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
On Thu, Jan 26, 2017 at 05:01:38PM -0800, Cong Wang wrote: > I'd suggest to you add some debugging printk's to the dst refcount functions, > or maybe just inside dst_gc_task(). I think the last dst referring to > the loopback > dev is still being referred at that point, which prevents GC from destr

Re: loopback device reference count leakage

2017-01-26 Thread Cong Wang
On Thu, Jan 26, 2017 at 2:51 PM, Kaiwen Xu wrote: > Hi Cong, > > I tested out your patch, it does seem to be preventing the issue from > happening. Here are the dev_put/dev_hold() calls with your patch > applied. Good. Now we narrow down the bug to those dst's referring loopback_dev. > However,

Re: loopback device reference count leakage

2017-01-26 Thread Kaiwen Xu
Hi Cong, I tested out your patch, it does seem to be preventing the issue from happening. Here are the dev_put/dev_hold() calls with your patch applied. Jan 26 00:29:08 kernel: [ 4385.940243] lo: dev_hold 1 rx_queue_add_kobject Jan 26 00:29:08 kernel: [ 4385.940255] lo: dev_hold 2 netdev_queu

Re: loopback device reference count leakage

2017-01-25 Thread Cong Wang
Hello, On Mon, Jan 23, 2017 at 9:17 PM, Kaiwen Xu wrote: > Hi netdev folks, > > I am currently experiencing an issue related with the loopback during > network devices shutdown inside a network namespace, which mainfested as > > unregister_netdevice: waiting for lo to become free. Usage count

loopback device reference count leakage

2017-01-23 Thread Kaiwen Xu
Hi netdev folks, I am currently experiencing an issue related with the loopback during network devices shutdown inside a network namespace, which mainfested as unregister_netdevice: waiting for lo to become free. Usage count = 1 showing up every 10 seconds or so in the kernel log. It eventua