Re: lan78xx and phy_state_machine

2019-10-17 Thread Andrew Lunn
On Thu, Oct 17, 2019 at 07:52:32PM +0200, Stefan Wahren wrote: > Hi Daniel, > > Am 17.10.19 um 19:41 schrieb Daniel Wagner: > > Hi Stefan, > > > > On Thu, Oct 17, 2019 at 07:05:32PM +0200, Stefan Wahren wrote: > >> Am 17.10.19 um 08:52 schrieb Daniel Wagner: > >>> On Wed, Oct 16, 2019 at 05:51:07P

Re: lan78xx and phy_state_machine

2019-10-17 Thread Daniel Wagner
> >> Unfortunately, you didn't wrote which kernel version works for you > >> (except of this splat). Only 5.3 or 5.4-rc3 too? > > With v5.2.20 I was able to boot the system. But after this discussion > > I would say that was just luck. The race seems to exist for longer and > > only with my 'specia

Re: lan78xx and phy_state_machine

2019-10-17 Thread Stefan Wahren
Hi Daniel, Am 17.10.19 um 19:41 schrieb Daniel Wagner: > Hi Stefan, > > On Thu, Oct 17, 2019 at 07:05:32PM +0200, Stefan Wahren wrote: >> Am 17.10.19 um 08:52 schrieb Daniel Wagner: >>> On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: Please could you give this a go. It is totally

Re: lan78xx and phy_state_machine

2019-10-17 Thread Daniel Wagner
Hi Stefan, On Thu, Oct 17, 2019 at 07:05:32PM +0200, Stefan Wahren wrote: > Am 17.10.19 um 08:52 schrieb Daniel Wagner: > > On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: > >> Please could you give this a go. It is totally untested, not even > >> compile tested... > > Sure. The syste

Re: lan78xx and phy_state_machine

2019-10-17 Thread Stefan Wahren
Hi Daniel, Am 17.10.19 um 08:52 schrieb Daniel Wagner: > On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: >> Hi Daniel >> >> Please could you give this a go. It is totally untested, not even >> compile tested... > Sure. The system boots but ther is one splat: > this is a known issues s

Re: lan78xx and phy_state_machine

2019-10-17 Thread Andrew Lunn
On Thu, Oct 17, 2019 at 08:52:30AM +0200, Daniel Wagner wrote: > On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: > > Hi Daniel > > > > Please could you give this a go. It is totally untested, not even > > compile tested... > > Sure. The system boots but ther is one splat: Cool. So w

Re: lan78xx and phy_state_machine

2019-10-16 Thread Daniel Wagner
On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: > Hi Daniel > > Please could you give this a go. It is totally untested, not even > compile tested... Sure. The system boots but ther is one splat: [2.213987] usb 1-1: new high-speed USB device number 2 using dwc2 [2.426789] h

Re: lan78xx and phy_state_machine

2019-10-16 Thread Andrew Lunn
Hi Daniel Please could you give this a go. It is totally untested, not even compile tested... Thanks Andrew >From 235549a687ad91c1500289fb32ee1c775d06d16d Mon Sep 17 00:00:00 2001 From: Andrew Lunn Date: Wed, 16 Oct 2019 10:42:07 -0500 Subject: [PATCH] net: usb: lan78xx: Connect PHY bef

Re: lan78xx and phy_state_machine

2019-10-16 Thread Andrew Lunn
> > - lan78xx_phy_init() (incl. the call to phy_connect_direct()) is called > > after register_netdev(). This may cause races. > > That isn't a problem. We have lots of network device drivers that do > this - in their open() function. Hi Russell Actually, here is it. lan7801_phy_init() finds

Re: lan78xx and phy_state_machine

2019-10-16 Thread Daniel Wagner
On Tue, Oct 15, 2019 at 07:16:53PM +0200, Daniel Wagner wrote: > Could it be that the networking interface is still running (from > u-boot and PXE) when the drivers is setting it up and the workqueue is > premature kicked to work? I've dump the registers before the device is setup and verified wit

Re: lan78xx and phy_state_machine

2019-10-15 Thread Stefan Wahren
Am 15.10.19 um 21:38 schrieb Heiner Kallweit: > On 15.10.2019 00:12, Russell King - ARM Linux admin wrote: >> On Mon, Oct 14, 2019 at 10:20:15PM +0200, Heiner Kallweit wrote: >>> On 14.10.2019 21:51, Stefan Wahren wrote: [add more recipients] Am 14.10.19 um 21:25 schrieb Daniel Wagne

Re: lan78xx and phy_state_machine

2019-10-15 Thread Russell King - ARM Linux admin
On Tue, Oct 15, 2019 at 09:38:22PM +0200, Heiner Kallweit wrote: > On 15.10.2019 00:12, Russell King - ARM Linux admin wrote: > > On Mon, Oct 14, 2019 at 10:20:15PM +0200, Heiner Kallweit wrote: > >> On 14.10.2019 21:51, Stefan Wahren wrote: > >>> [add more recipients] > >>> > >>> Am 14.10.19 um 21

Re: lan78xx and phy_state_machine

2019-10-15 Thread Heiner Kallweit
On 15.10.2019 00:12, Russell King - ARM Linux admin wrote: > On Mon, Oct 14, 2019 at 10:20:15PM +0200, Heiner Kallweit wrote: >> On 14.10.2019 21:51, Stefan Wahren wrote: >>> [add more recipients] >>> >>> Am 14.10.19 um 21:25 schrieb Daniel Wagner: Moving the phy_prepare_link() up in phy_conne

Re: lan78xx and phy_state_machine

2019-10-15 Thread Daniel Wagner
Hi Andrew, On Tue, Oct 15, 2019 at 02:53:27AM +0200, Andrew Lunn wrote: > On Mon, Oct 14, 2019 at 04:06:04PM +0200, Daniel Wagner wrote: > > Hi, > > > > I've trying to boot a RPi 3 Model B+ in 64 bit mode. While I can get > > my configuratin booting with v5.2.20, the current kernel v5.3.6 hangs >

Re: lan78xx and phy_state_machine

2019-10-14 Thread Russell King - ARM Linux admin
On Mon, Oct 14, 2019 at 10:20:15PM +0200, Heiner Kallweit wrote: > On 14.10.2019 21:51, Stefan Wahren wrote: > > [add more recipients] > > > > Am 14.10.19 um 21:25 schrieb Daniel Wagner: > >> Moving the phy_prepare_link() up in phy_connect_direct() ensures that > >> phydev->adjust_link is set when

Re: lan78xx and phy_state_machine

2019-10-14 Thread Heiner Kallweit
On 14.10.2019 21:51, Stefan Wahren wrote: > [add more recipients] > > Am 14.10.19 um 21:25 schrieb Daniel Wagner: >> On Mon, Oct 14, 2019 at 05:30:04PM +0100, Russell King - ARM Linux admin >> wrote: >>> On Mon, Oct 14, 2019 at 04:06:04PM +0200, Daniel Wagner wrote: Hi, I've trying

Re: lan78xx and phy_state_machine

2019-10-14 Thread Stefan Wahren
[add more recipients] Am 14.10.19 um 21:25 schrieb Daniel Wagner: > On Mon, Oct 14, 2019 at 05:30:04PM +0100, Russell King - ARM Linux admin > wrote: >> On Mon, Oct 14, 2019 at 04:06:04PM +0200, Daniel Wagner wrote: >>> Hi, >>> >>> I've trying to boot a RPi 3 Model B+ in 64 bit mode. While I can