Re: kmap_atomic() oopses in current mainline

2007-07-19 Thread Dan Williams
On 7/19/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: On Thu, Jul 19, 2007 at 02:38:31AM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > > > is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be > > > set. We'll end up using the same kmap slot for both src add dest and w

Re: kmap_atomic() oopses in current mainline

2007-07-19 Thread Evgeniy Polyakov
On Thu, Jul 19, 2007 at 02:38:31AM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > > > is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be > > > set. We'll end up using the same kmap slot for both src add dest and we > > > get either corrupted data or a BUG. > > > > So fa

Re: kmap_atomic() oopses in current mainline

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 13:28:56 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > Hi. > > On Thu, Jul 19, 2007 at 01:33:04AM -0700, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > I don't think the 2-year-old Vaio has offload engine support ;) Dan, this: > > > > + if (flags & ASYNC_TX_K

Re: kmap_atomic() oopses in current mainline

2007-07-19 Thread Evgeniy Polyakov
Hi. On Thu, Jul 19, 2007 at 01:33:04AM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > I don't think the 2-year-old Vaio has offload engine support ;) Dan, this: > > + if (flags & ASYNC_TX_KMAP_DST) > + dest_buf = kmap_atomic(dest, KM_USER0) + dest_offset; > +

kmap_atomic() oopses in current mainline

2007-07-19 Thread Andrew Morton
I've had a handful of random mystery oopses associated with no particular activity. A typical trace is at: http://userweb.kernel.org/~akpm/dsc03659.jpg the trace is messy and it doesn't seem to want to happen now I've turned on frame pointers, but it looks networky to me. So if anyone