Re: kernel panic with the newly merged md5 signature support

2006-12-13 Thread David Miller
From: "Leigh Brown" <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 23:43:50 - (GMT) > I just had to kill the parameter:- > > --- net/ipv4/tcp.c.orig 2006-12-10 21:46:26.0 + > +++ net/ipv4/tcp.c2006-12-13 17:38:29.0 + > @@ -2362,7 +2362,7 @@ struct tcp_md5sig_pool

Re: kernel panic with the newly merged md5 signature support

2006-12-13 Thread Leigh Brown
On Wed, December 13, 2006 1:29 am, David Miller said: > I think we're still not onto the right fix. > > I took a look, and the issue seems to simply be that the > __tcp_put_md5sig_pool() is not doing the reference count > thing that __tcp_get_md5sig_pool() does (via tcp_md5sig_users). > > The direc

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread David Miller
From: "Leigh Brown" <[EMAIL PROTECTED]> Date: Tue, 12 Dec 2006 23:03:34 - (GMT) > Well, the inline functions seem okay in that regard, but I'll bow to > your superior judgement. I think we're still not onto the right fix. I took a look, and the issue seems to simply be that the __tcp_put_md5

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread Leigh Brown
On Tue, December 12, 2006 10:25 pm, David Miller said: > From: "Leigh Brown" <[EMAIL PROTECTED]> > Date: Tue, 12 Dec 2006 22:22:13 - (GMT) > >> I'm not sure what the correct way forward is. Could these functions >> not be just: >> >> struct tcp_md5sig_pool *__tcp_get_md5sig_pool(int cpu) >> {

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread David Miller
From: "Leigh Brown" <[EMAIL PROTECTED]> Date: Tue, 12 Dec 2006 22:22:13 - (GMT) > I'm not sure what the correct way forward is. Could these functions > not be just: > > struct tcp_md5sig_pool *__tcp_get_md5sig_pool(int cpu) > { > struct tcp_md5sig_pool **p = tcp_md5_sig_pool; >

Re: kernel panic with the newly merged md5 signature support

2006-12-12 Thread Leigh Brown
On Mon, December 11, 2006 9:38 pm, I said: > I decided to try out the md5 signature support, with a view to eventually > fixing up Quagga to make use of it. As the API has changed quite a bit, > I modified a simple echo client/server as a simple test. I compiled > up 2.6.19-git17 and ran it under

kernel panic with the newly merged md5 signature support

2006-12-11 Thread Leigh Brown
Hello, I decided to try out the md5 signature support, with a view to eventually fixing up Quagga to make use of it. As the API has changed quite a bit, I modified a simple echo client/server as a simple test. I compiled up 2.6.19-git17 and ran it under debian etch. Unfortunately, both the clie