Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-16 Thread David Ahern
On 4/16/17 6:44 PM, Subash Abhinov Kasiviswanathan wrote: > Can you try this > > --- > net/ipv6/udp.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c > index b793ed1..0e307e5 100644 > --- a/net/ipv6/udp.c > +++ b/net

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-16 Thread Subash Abhinov Kasiviswanathan
Can you try this --- net/ipv6/udp.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index b793ed1..0e307e5 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -46,6 +46,7 @@ #include #include #include +#include #in

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-16 Thread David Ahern
On 4/15/17 8:23 PM, Subash Abhinov Kasiviswanathan wrote: >>> It should be fixed for 4.12. Basically, __udp6_lib_demux_lookup needs to >>> be more like __udp4_lib_demux_lookup > > Hi David > > Would it be possible for you to test this with udp_l3mdev_accept=0 formatting was botched so it does no

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-15 Thread Subash Abhinov Kasiviswanathan
It should be fixed for 4.12. Basically, __udp6_lib_demux_lookup needs to be more like __udp4_lib_demux_lookup Hi David Would it be possible for you to test this with udp_l3mdev_accept=0 diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index b793ed1..0e307e5 100644 --- a/net/ipv6/udp.c +++ b/net/i

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-15 Thread David Miller
From: David Ahern Date: Fri, 14 Apr 2017 18:42:14 -0600 > On 4/14/17 6:38 PM, Subash Abhinov Kasiviswanathan wrote: >> On 2017-04-14 16:23, David Ahern wrote: >>> Subash: >>> >>> My understanding of early demux is that it should only match connected >>> sockets (src/sport + dst/dport are all set)

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-14 Thread David Ahern
On 4/14/17 6:38 PM, Subash Abhinov Kasiviswanathan wrote: > On 2017-04-14 16:23, David Ahern wrote: >> Subash: >> >> My understanding of early demux is that it should only match connected >> sockets (src/sport + dst/dport are all set). The ipv6 udp early demux >> code added in 5425077d73e0c is doin

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-14 Thread Subash Abhinov Kasiviswanathan
On 2017-04-14 16:23, David Ahern wrote: Subash: My understanding of early demux is that it should only match connected sockets (src/sport + dst/dport are all set). The ipv6 udp early demux code added in 5425077d73e0c is doing a generic socket lookup which does not require an exact match and acco

ipv6 udp early demux breaks udp_l3mdev_accept=0

2017-04-14 Thread David Ahern
Subash: My understanding of early demux is that it should only match connected sockets (src/sport + dst/dport are all set). The ipv6 udp early demux code added in 5425077d73e0c is doing a generic socket lookup which does not require an exact match and accordingly breaks udp_l3mdev_accept=0. Please