Re: ip6_forward / NF_HOOK and counters

2018-03-30 Thread David Ahern
On 3/26/18 7:35 PM, Jeff Barnhill wrote: > At the end of ip6_forward(), is there a good reason why > IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented > before the NF_HOOK? If the hook steals or drops the packet, this > counts still go up, which seems incorrect. > > v4/ip_for

ip6_forward / NF_HOOK and counters

2018-03-26 Thread Jeff Barnhill
At the end of ip6_forward(), is there a good reason why IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented before the NF_HOOK? If the hook steals or drops the packet, this counts still go up, which seems incorrect. v4/ip_forward() increments these counters in ip_forward_finish