Re: [PATCH net v2 7/7] igc: fix link speed advertising

2021-01-27 Thread Nguyen, Anthony L
On Wed, 2021-01-27 at 08:04 +0100, Heiner Kallweit wrote: > On 26.01.2021 23:10, Tony Nguyen wrote: > > From: Corinna Vinschen > > > > Link speed advertising in igc has two problems: > > > > - When setting the advertisement via ethtool, the link speed is > > converted > > to the legacy 32 bit

Re: [Intel-wired-lan] igc: fix link speed advertising

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 11:30:37 +0100 Corinna Vinschen wrote: > Ping? > > It looks like this patch got lost somehow. Without this patch, > setting link speed advertising is broken. Adding Intel maintainers.

Re: [Intel-wired-lan] igc: fix link speed advertising

2021-01-27 Thread Nguyen, Anthony L
On Tue, 2021-01-26 at 12:00 -0800, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 11:30:37 +0100 Corinna Vinschen wrote: > > Ping? > > > > It looks like this patch got lost somehow. Without this patch, > > setting link speed advertising is broken. > > Adding Intel maintainers. I talked to the team

Re: [PATCH net v2 7/7] igc: fix link speed advertising

2021-01-26 Thread Heiner Kallweit
On 26.01.2021 23:10, Tony Nguyen wrote: > From: Corinna Vinschen > > Link speed advertising in igc has two problems: > > - When setting the advertisement via ethtool, the link speed is converted > to the legacy 32 bit representation for the intel PHY code. > This inadvertently drops ETHTOOL_

[PATCH net v2 7/7] igc: fix link speed advertising

2021-01-26 Thread Tony Nguyen
From: Corinna Vinschen Link speed advertising in igc has two problems: - When setting the advertisement via ethtool, the link speed is converted to the legacy 32 bit representation for the intel PHY code. This inadvertently drops ETHTOOL_LINK_MODE_2500baseT_Full_BIT (being beyond bit 31).

Re: [Intel-wired-lan] igc: fix link speed advertising

2021-01-26 Thread Corinna Vinschen
Ping? It looks like this patch got lost somehow. Without this patch, setting link speed advertising is broken. Thanks, Corinna On Nov 17 20:50, Corinna Vinschen wrote: > Link speed advertising in igc has two problems: > > - When setting the advertisement via ethtool, the link speed is conver

igc: fix link speed advertising

2020-11-17 Thread Corinna Vinschen
Link speed advertising in igc has two problems: - When setting the advertisement via ethtool, the link speed is converted to the legacy 32 bit representation for the intel PHY code. This inadvertently drops ETHTOOL_LINK_MODE_2500baseT_Full_BIT (being beyond bit 31). As a result, any call to

Re: [Intel-wired-lan] [RHEL8.4 PATCH] igc: fix link speed advertising

2020-11-17 Thread Corinna Vinschen
On Nov 17 20:46, Corinna Vinschen wrote: > Link speed advertising in igc has two problems: Sorry for the RHEL tag in the subject, I'll resend the patch without this. Corinna

[RHEL8.4 PATCH] igc: fix link speed advertising

2020-11-17 Thread Corinna Vinschen
Link speed advertising in igc has two problems: - When setting the advertisement via ethtool, the link speed is converted to the legacy 32 bit representation for the intel PHY code. This inadvertently drops ETHTOOL_LINK_MODE_2500baseT_Full_BIT (being beyond bit 31). As a result, any call to