RE: how is the bpfilter sockopt processing supposed to work

2020-07-20 Thread David Laight
From: Alexei Starovoitov > Sent: 17 July 2020 18:29 > On Fri, Jul 17, 2020 at 9:25 AM Christoph Hellwig wrote: > > > > On Fri, Jul 17, 2020 at 09:13:07AM -0700, Alexei Starovoitov wrote: > > > On Thu, Jul 16, 2020 at 10:52 PM Christoph Hellwig wrote: > > > > > > > > Hi Alexei, > > > > > > > > I'v

Re: how is the bpfilter sockopt processing supposed to work

2020-07-17 Thread Alexei Starovoitov
On Fri, Jul 17, 2020 at 9:25 AM Christoph Hellwig wrote: > > On Fri, Jul 17, 2020 at 09:13:07AM -0700, Alexei Starovoitov wrote: > > On Thu, Jul 16, 2020 at 10:52 PM Christoph Hellwig wrote: > > > > > > Hi Alexei, > > > > > > I've just been auditing the sockopt code, and bpfilter looks really > >

Re: how is the bpfilter sockopt processing supposed to work

2020-07-17 Thread Christoph Hellwig
On Fri, Jul 17, 2020 at 09:13:07AM -0700, Alexei Starovoitov wrote: > On Thu, Jul 16, 2020 at 10:52 PM Christoph Hellwig wrote: > > > > Hi Alexei, > > > > I've just been auditing the sockopt code, and bpfilter looks really > > odd. Both getsockopts and setsockopt eventually end up > > in__bpfilte

Re: how is the bpfilter sockopt processing supposed to work

2020-07-17 Thread Alexei Starovoitov
On Thu, Jul 16, 2020 at 10:52 PM Christoph Hellwig wrote: > > Hi Alexei, > > I've just been auditing the sockopt code, and bpfilter looks really > odd. Both getsockopts and setsockopt eventually end up > in__bpfilter_process_sockopt, which then passes record to the > userspace helper containing t

how is the bpfilter sockopt processing supposed to work

2020-07-16 Thread Christoph Hellwig
Hi Alexei, I've just been auditing the sockopt code, and bpfilter looks really odd. Both getsockopts and setsockopt eventually end up in__bpfilter_process_sockopt, which then passes record to the userspace helper containing the address of the optval buffer. Which depending on bpf-cgroup might be