Re: general protection fault in inet_unhash

2020-05-29 Thread Andrii Nakryiko
On 5/29/20 10:32 AM, Eric Dumazet wrote: On 5/28/20 11:32 PM, Andrii Nakryiko wrote: On 5/28/20 11:23 PM, Dmitry Vyukov wrote: On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD

Re: general protection fault in inet_unhash

2020-05-29 Thread Eric Dumazet
On 5/29/20 10:32 AM, Eric Dumazet wrote: > L2TP seems to use sk->sk_node to insert sockets into l2tp_ip_table, _and_ > uses l2tp_ip_prot.unhash == inet_unhash > > So if/when BPF_CGROUP_RUN_PROG_INET_SOCK(sk) returns an error and > inet_create() calls sk_common_release() > bad things happen,

Re: general protection fault in inet_unhash

2020-05-29 Thread Eric Dumazet
On 5/28/20 11:32 PM, Andrii Nakryiko wrote: > On 5/28/20 11:23 PM, Dmitry Vyukov wrote: >> On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs >> wrote: >>> >>> On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit: 

Re: general protection fault in inet_unhash

2020-05-28 Thread Andrii Nakryiko
On 5/28/20 11:23 PM, Dmitry Vyukov wrote: On Thu, May 28, 2020 at 11:01 PM 'Andrii Nakryiko' via syzkaller-bugs wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree: n

Re: general protection fault in inet_unhash

2020-05-28 Thread Andrii Nakryiko
On 5/28/20 2:27 PM, Eric Dumazet wrote: On 5/28/20 2:01 PM, Andrii Nakryiko wrote: On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:    dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree:   net-next console output: https://url

Re: general protection fault in inet_unhash

2020-05-28 Thread Eric Dumazet
On 5/28/20 2:01 PM, Andrii Nakryiko wrote: > On 5/28/20 9:44 AM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:    dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. >> git tree:   net-next >> console output: >> https://urldefense.proofpoint.

Re: general protection fault in inet_unhash

2020-05-28 Thread Andrii Nakryiko
On 5/28/20 9:44 AM, syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree: net-next console output: https://urldefense.proofpoint.com/v2/url?u=https-3A__syzkaller.appspot.com_x_log.txt-3Fx-3D17289cd

general protection fault in inet_unhash

2020-05-28 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:dc0f3ed1 net: phy: at803x: add cable diagnostics support f.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=17289cd210 kernel config: https://syzkaller.appspot.com/x/.config?x=7e1bc97341edbea6 das