Re: general protection fault in encode_rpcb_string

2018-05-08 Thread Bruce Fields
On Tue, May 08, 2018 at 12:34:48PM -0400, Chuck Lever wrote: > > > > On May 8, 2018, at 12:15 PM, bfie...@fieldses.org wrote: > > > > On Tue, Apr 17, 2018 at 09:54:36PM +, Trond Myklebust wrote: > >> Yes, and we can probably convert it, and the other GFP_ATOMIC > >> allocations in the rpcbin

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread Chuck Lever
> On May 8, 2018, at 12:15 PM, bfie...@fieldses.org wrote: > > On Tue, Apr 17, 2018 at 09:54:36PM +, Trond Myklebust wrote: >> Yes, and we can probably convert it, and the other GFP_ATOMIC >> allocations in the rpcbind client to use GFP_NOFS in order to improve >> reliability. > > Chuck, I

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread bfie...@fieldses.org
On Tue, Apr 17, 2018 at 09:54:36PM +, Trond Myklebust wrote: > Yes, and we can probably convert it, and the other GFP_ATOMIC > allocations in the rpcbind client to use GFP_NOFS in order to improve > reliability. Chuck, I think the GFP_ATOMIC is unnecessary here as well? --b. diff --git a/net

Re: general protection fault in encode_rpcb_string

2018-05-08 Thread bfie...@fieldses.org
From: "J. Bruce Fields" Date: Tue, 8 May 2018 11:47:03 -0400 Subject: [PATCH 2/2] sunrpc: convert unnecessary GFP_ATOMIC to GFP_NOFS It's OK to sleep here, we just don't want to recurse into the filesystem as this writeout could be waiting on this. As a next step: the documentation for GFP_NOFS

Re: general protection fault in encode_rpcb_string

2018-04-17 Thread Trond Myklebust
On Tue, 2018-04-17 at 17:33 -0400, J. Bruce Fields wrote: > On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > > syzbot hit the following crash on bpf-next commit > > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 > > +) > > Merge git://git.kernel.org/pub/scm/linux/ke

Re: general protection fault in encode_rpcb_string

2018-04-17 Thread J. Bruce Fields
On Mon, Apr 16, 2018 at 09:02:01PM -0700, syzbot wrote: > syzbot hit the following crash on bpf-next commit > 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) > Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net > syzbot dashboard link: > https://syzkaller.appspo

general protection fault in encode_rpcb_string

2018-04-16 Thread syzbot
Hello, syzbot hit the following crash on bpf-next commit 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=4b98281f2401ab849f4b So far this cras