Re: fib6_del_route has redundant code

2007-12-28 Thread Gui Jianfeng
> From: Gui Jianfeng <[EMAIL PROTECTED]> > Date: Fri, 28 Dec 2007 13:58:21 +0800 > I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) 1126 fn->leaf = &ip6_null_entry;

Re: fib6_del_route has redundant code

2007-12-28 Thread David Miller
From: Gui Jianfeng <[EMAIL PROTECTED]> Date: Fri, 28 Dec 2007 13:58:21 +0800 > >> I think the following code in fib6_del_route in the latest kernel is > >> useless. > >> 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) > >> 1126 fn->leaf = &ip6_null_entry; > >> > >>

Re: fib6_del_route has redundant code

2007-12-27 Thread Gui Jianfeng
>> I think the following code in fib6_del_route in the latest kernel is useless. >> 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) >> 1126 fn->leaf = &ip6_null_entry; >> >> ip6_null_entry will never be unlinked from fn->leaf now, that is, >> fn->leaf == NULL will nev

Re: fib6_del_route has redundant code

2007-12-27 Thread David Miller
From: Gui Jianfeng <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 15:26:46 +0800 > I think the following code in fib6_del_route in the latest kernel is useless. > 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) > 1126 fn->leaf = &ip6_null_entry; > > ip6_null_entry will

fib6_del_route has redundant code

2007-12-26 Thread Gui Jianfeng
Hi all, I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) 1126 fn->leaf = &ip6_null_entry; ip6_null_entry will never be unlinked from fn->leaf now, that is, fn->leaf == NULL will never meet.