Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-28 Thread Bruno Thomsen
Hi Andrew, Den ons. 22. jul. 2020 kl. 15.26 skrev Andrew Lunn : > Is it held in reset, and the reset is released, or is the reset line > toggled active and then inactive? When the kernel boots PHY reset is not active (gpio level low). The device needs a reset pulse. > > if (d) > > if (d >

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Heiner Kallweit
On 22.07.2020 12:59, Bruno Thomsen wrote: > Hi Andrew,  > I have been having issues with Ethernet PHY type ID auto-detection when changing from the deprecated fec phy-reset-{gpios,duration,post-delay} properties to the modern mdio reset-{assert-us,deassert-us,gpios} proper

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Andrew Lunn
Hi Bruno Is it held in reset, and the reset is released, or is the reset line toggled active and then inactive? > > void mdio_device_reset(struct mdio_device *mdiodev, int value) > > { > > unsigned int d; > > > > .. > > > > d = value ? mdiodev->reset_assert_delay : mdiodev->rese

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-22 Thread Bruno Thomsen
Hi Andrew,  > > > I have been having issues with Ethernet PHY type ID > > > auto-detection when changing from the deprecated fec > > > phy-reset-{gpios,duration,post-delay} properties to the > > > modern mdio reset-{assert-us,deassert-us,gpios} > > > properties in the device tree. > > > > Kernel e

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-17 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 12:52:08PM -0300, Fabio Estevam wrote: > Hi Bruno, > > I have been having issues with Ethernet PHY type ID > > auto-detection when changing from the deprecated fec > > phy-reset-{gpios,duration,post-delay} properties to the > > modern mdio reset-{assert-us,deassert-us,gpios

Re: fec: micrel: Ethernet PHY type ID auto-detection issue

2020-07-17 Thread Fabio Estevam
Hi Bruno, Adding netdev and the Ethernet PHY folks. On Fri, Jul 17, 2020 at 12:48 PM Bruno Thomsen wrote: > > Hi > > I have been having issues with Ethernet PHY type ID > auto-detection when changing from the deprecated fec > phy-reset-{gpios,duration,post-delay} properties to the > modern mdio