Re: ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread Maciej Żenczykowski
Eh, I think this patch can simply be reverted. This is a dupe. ethtool-copy.h is only included from internal.h which already includes: ... #ifndef ETHTOOL_INTERNAL_H__ #define ETHTOOL_INTERNAL_H__ /* Some platforms (eg. ppc64) need __SANE_USERSPACE_TYPES__ before * to select 'int-ll64.h' and a

Re: ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread Maciej Żenczykowski
On Tue, Jan 29, 2019 at 1:00 PM John W. Linville wrote: > > On Tue, Jan 29, 2019 at 09:28:42PM +0100, Michal Kubecek wrote: > > Hello, > > > > I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d > > ("ethtool: change to new sane powerpc64 kernel headers") adds changes to > > ethtool-

Re: ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread John W. Linville
On Tue, Jan 29, 2019 at 09:28:42PM +0100, Michal Kubecek wrote: > Hello, > > I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d > ("ethtool: change to new sane powerpc64 kernel headers") adds changes to > ethtool-copy.h which are not in sync with kernel file it is generated > from.

ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread Michal Kubecek
Hello, I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d ("ethtool: change to new sane powerpc64 kernel headers") adds changes to ethtool-copy.h which are not in sync with kernel file it is generated from. This file is supposed to be a copy of the sanitized kernel UAPI header, i.e