Thanks Pete,
This is correct, the array should contain 3 elements. The bug was we were
accessing a 4th element ([3]) which did not exist. We should be modifying the
last element ([2]) instead.
-Scott
Hans-Peter Jansen wrote:
[from the nitpick department..]
Hi Jeff, hi Scott,
Adrian wrote:
[from the nitpick department..]
Hi Jeff, hi Scott,
Adrian wrote:
>The Coverity checker spotted the following two array overflows in
>drivers/net/chelsio/sge.c (in both cases, the arrays contain 3
>elements):
Am Freitag, 17. März 2006 01:21 schrieb Jeff Garzik:
> Scott Bardone wrote:
> > Adrian
Scott Bardone wrote:
Adrian,
This is a bug. The array should contain 2 elements.
Attached is a patch which fixes it.
Thanks.
Signed-off-by: Scott Bardone <[EMAIL PROTECTED]>
applied. please avoid attachments and use a proper patch description in
the future. I had to hand-edit and hand-app
I had meant to say the array contains 3 elements but should only access index 2.
Sorry for the confusion.
-Scott
Ingo Oeser wrote:
Hi Scott,
You wrote:
This is a bug. The array should contain 2 elements.
Sure? It either contains 3 elements or your patch is not fixing the issue.
Please com
Adrian,
This is a bug. The array should contain 2 elements.
Attached is a patch which fixes it.
Thanks.
Signed-off-by: Scott Bardone <[EMAIL PROTECTED]>
Adrian Bunk wrote:
The Coverity checker spotted the following two array overflows in
drivers/net/chelsio/sge.c (in both cases, the arrays c
The Coverity checker spotted the following two array overflows in
drivers/net/chelsio/sge.c (in both cases, the arrays contain 3 elements):
<-- snip -->
...
static void restart_tx_queues(struct sge *sge)
{
...
sge->stats.cmdQ_restarted[3]++;
...
static int t1_sg
